| Message ID | 20220118190922.1557074-3-dlatypov@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 89aa72cd3052b70ade40fa02a018f8f509355790 |
| Delegated to: | Brendan Higgins |
| Headers | show |
| Series | [1/5] kunit: tool: drop mostly unused KunitResult.result field | expand |
On Wed, Jan 19, 2022 at 3:09 AM Daniel Latypov <dlatypov@google.com> wrote: > > Commit be886ba90cce ("kunit: run kunit_tool from any directory") > introduced this variable, but it was unused even in that commit. > > Since it's still unused now and callers can instead use > get_kernel_root_path(), delete this var. > > Signed-off-by: Daniel Latypov <dlatypov@google.com> > --- Reviewed-by: David Gow <davidgow@google.com> Cheers, -- David > tools/testing/kunit/kunit.py | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py > index bd2f7f088c72..4cb91d191f1d 100755 > --- a/tools/testing/kunit/kunit.py > +++ b/tools/testing/kunit/kunit.py > @@ -63,8 +63,6 @@ class KunitRequest(KunitExecRequest, KunitBuildRequest): > pass > > > -KernelDirectoryPath = sys.argv[0].split('tools/testing/kunit/')[0] > - > def get_kernel_root_path() -> str: > path = sys.argv[0] if not __file__ else __file__ > parts = os.path.realpath(path).split('tools/testing/kunit') > -- > 2.34.1.703.g22d0c6ccf7-goog >
On Tue, Jan 18, 2022 at 2:09 PM Daniel Latypov <dlatypov@google.com> wrote: > > Commit be886ba90cce ("kunit: run kunit_tool from any directory") > introduced this variable, but it was unused even in that commit. > > Since it's still unused now and callers can instead use > get_kernel_root_path(), delete this var. > > Signed-off-by: Daniel Latypov <dlatypov@google.com> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py index bd2f7f088c72..4cb91d191f1d 100755 --- a/tools/testing/kunit/kunit.py +++ b/tools/testing/kunit/kunit.py @@ -63,8 +63,6 @@ class KunitRequest(KunitExecRequest, KunitBuildRequest): pass -KernelDirectoryPath = sys.argv[0].split('tools/testing/kunit/')[0] - def get_kernel_root_path() -> str: path = sys.argv[0] if not __file__ else __file__ parts = os.path.realpath(path).split('tools/testing/kunit')
Commit be886ba90cce ("kunit: run kunit_tool from any directory") introduced this variable, but it was unused even in that commit. Since it's still unused now and callers can instead use get_kernel_root_path(), delete this var. Signed-off-by: Daniel Latypov <dlatypov@google.com> --- tools/testing/kunit/kunit.py | 2 -- 1 file changed, 2 deletions(-)