mbox series

[wpan-next,0/4] ieee802154: General preparation to scan support

Message ID 20220120004350.308866-1-miquel.raynal@bootlin.com (mailing list archive)
Headers show
Series ieee802154: General preparation to scan support | expand

Message

Miquel Raynal Jan. 20, 2022, 12:43 a.m. UTC
These few patches are preparation patches and light cleanups before the
introduction of scan support.

David Girault (4):
  net: ieee802154: Move IEEE 802.15.4 Kconfig main entry
  net: mac802154: Include the softMAC stack inside the IEEE 802.15.4
    menu
  net: ieee802154: Move the address structure earlier
  net: ieee802154: Add a kernel doc header to the ieee802154_addr
    structure

 include/net/cfg802154.h | 28 +++++++++++++++++++---------
 net/Kconfig             |  3 +--
 net/ieee802154/Kconfig  |  1 +
 3 files changed, 21 insertions(+), 11 deletions(-)

Comments

Kalle Valo Jan. 20, 2022, 1:10 p.m. UTC | #1
Miquel Raynal <miquel.raynal@bootlin.com> writes:

> These few patches are preparation patches and light cleanups before the
> introduction of scan support.
>
> David Girault (4):
>   net: ieee802154: Move IEEE 802.15.4 Kconfig main entry
>   net: mac802154: Include the softMAC stack inside the IEEE 802.15.4
>     menu
>   net: ieee802154: Move the address structure earlier
>   net: ieee802154: Add a kernel doc header to the ieee802154_addr
>     structure
>
>  include/net/cfg802154.h | 28 +++++++++++++++++++---------
>  net/Kconfig             |  3 +--
>  net/ieee802154/Kconfig  |  1 +
>  3 files changed, 21 insertions(+), 11 deletions(-)

Is there a reason why you cc linux-wireless? It looks like there's a
separate linux-wpan list now and people who are interested about wpan
can join that list, right?
Miquel Raynal Jan. 20, 2022, 2:28 p.m. UTC | #2
Hi Kalle,

kvalo@kernel.org wrote on Thu, 20 Jan 2022 15:10:37 +0200:

> Miquel Raynal <miquel.raynal@bootlin.com> writes:
> 
> > These few patches are preparation patches and light cleanups before the
> > introduction of scan support.
> >
> > David Girault (4):
> >   net: ieee802154: Move IEEE 802.15.4 Kconfig main entry
> >   net: mac802154: Include the softMAC stack inside the IEEE 802.15.4
> >     menu
> >   net: ieee802154: Move the address structure earlier
> >   net: ieee802154: Add a kernel doc header to the ieee802154_addr
> >     structure
> >
> >  include/net/cfg802154.h | 28 +++++++++++++++++++---------
> >  net/Kconfig             |  3 +--
> >  net/ieee802154/Kconfig  |  1 +
> >  3 files changed, 21 insertions(+), 11 deletions(-)  
> 
> Is there a reason why you cc linux-wireless? It looks like there's a
> separate linux-wpan list now and people who are interested about wpan
> can join that list, right?
> 

I originally was advised to cc linux-wireless@ on my scanning series,
and I ended up with too many patches, leading to numerous smaller
series.

I actually forgot to drop this list from the Cc list in the preparation
patches for this version, I did however dropped it in the v2. Sorry for
the noise.

Thanks,
Miquèl
Alexander Aring Jan. 20, 2022, 11:31 p.m. UTC | #3
Hi Kalle and Miquel,

On Thu, 20 Jan 2022 at 08:10, Kalle Valo <kvalo@kernel.org> wrote:
>
> Miquel Raynal <miquel.raynal@bootlin.com> writes:
>
> > These few patches are preparation patches and light cleanups before the
> > introduction of scan support.
> >
> > David Girault (4):
> >   net: ieee802154: Move IEEE 802.15.4 Kconfig main entry
> >   net: mac802154: Include the softMAC stack inside the IEEE 802.15.4
> >     menu
> >   net: ieee802154: Move the address structure earlier
> >   net: ieee802154: Add a kernel doc header to the ieee802154_addr
> >     structure
> >
> >  include/net/cfg802154.h | 28 +++++++++++++++++++---------
> >  net/Kconfig             |  3 +--
> >  net/ieee802154/Kconfig  |  1 +
> >  3 files changed, 21 insertions(+), 11 deletions(-)
>
> Is there a reason why you cc linux-wireless? It looks like there's a
> separate linux-wpan list now and people who are interested about wpan
> can join that list, right?
>

I thought it would make sense to cc wireless as they have similar
paradigms constructs (probably due the fact both are IEEE standards?).
As well we took some ideas from wireless as base. Moreover we were
talking about things which wireless already solved.
I was hoping to get some feedback if somebody knows the right do's and
don'ts of managing a wireless subsystem and I am pretty sure some
802.11 developers have more knowledge about it than some 802.15.4
developers (including myself).

I apologise for this. Please Miquel drop wireless for your future patch-series.

Miquel please slow down the amount of patches. First sending the
fixes, then new features in small series one by one. And with one by
one I mean after they are applied.

- Alex
Miquel Raynal Jan. 21, 2022, 8:31 a.m. UTC | #4
Hi Alexander,

alex.aring@gmail.com wrote on Thu, 20 Jan 2022 18:31:58 -0500:

> Hi Kalle and Miquel,
> 
> On Thu, 20 Jan 2022 at 08:10, Kalle Valo <kvalo@kernel.org> wrote:
> >
> > Miquel Raynal <miquel.raynal@bootlin.com> writes:
> >  
> > > These few patches are preparation patches and light cleanups before the
> > > introduction of scan support.
> > >
> > > David Girault (4):
> > >   net: ieee802154: Move IEEE 802.15.4 Kconfig main entry
> > >   net: mac802154: Include the softMAC stack inside the IEEE 802.15.4
> > >     menu
> > >   net: ieee802154: Move the address structure earlier
> > >   net: ieee802154: Add a kernel doc header to the ieee802154_addr
> > >     structure
> > >
> > >  include/net/cfg802154.h | 28 +++++++++++++++++++---------
> > >  net/Kconfig             |  3 +--
> > >  net/ieee802154/Kconfig  |  1 +
> > >  3 files changed, 21 insertions(+), 11 deletions(-)  
> >
> > Is there a reason why you cc linux-wireless? It looks like there's a
> > separate linux-wpan list now and people who are interested about wpan
> > can join that list, right?
> >  
> 
> I thought it would make sense to cc wireless as they have similar
> paradigms constructs (probably due the fact both are IEEE standards?).
> As well we took some ideas from wireless as base. Moreover we were
> talking about things which wireless already solved.
> I was hoping to get some feedback if somebody knows the right do's and
> don'ts of managing a wireless subsystem and I am pretty sure some
> 802.11 developers have more knowledge about it than some 802.15.4
> developers (including myself).
> 
> I apologise for this. Please Miquel drop wireless for your future patch-series.

Ok, no problem!
 
> Miquel please slow down the amount of patches. First sending the
> fixes, then new features in small series one by one. And with one by
> one I mean after they are applied.

Yes no problem, I didn't want to flood you, but I was eager to share
the new sync tx implementation that we discussed earlier this week,
which meant I also needed to share the two 'small' series in between.

Thanks,
Miquèl