[PATCHv2,0/5] ext4/jbd2: inline_data fixes and minor cleanups

Message

Ritesh Harjani Jan. 17, 2022, 12:11 p.m. UTC

Hello,

Please find v2 of the inline_data fixes and some minor cleanups found during
code review.

I have dropped patch-6 in v2 which was removing use of t_handle_lock (spinlock)
from within jbd2_journal_wait_updates(). Based on Jan comments, I feel we can
push that as killing of t_handle_lock into a separate series (which will be on
top of this).

v1 -> v2
========
1. Added Jan's Reviewed-by tag & addressed one of his comment on no need to make
jbd2_journal_wait_updates() function inline.
2. Dropped patch-6 as described above.

Description
============
Patch[1]: fixes BUG_ON with inline_data which was reported [1] with generic/475.

Patch[2]: is mostly cleanup found during code review of inline_data code.

Patch[3]: is a possible memory corruption fix in case of krealloc failure.

Patch[4-5]: Cleanups.

[v1]: https://lore.kernel.org/linux-ext4/[e-mail]/T/

Ritesh Harjani (5):
  ext4: Fix error handling in ext4_restore_inline_data()
  ext4: Remove redundant max inline_size check in ext4_da_write_inline_data_begin()
  ext4: Fix error handling in ext4_fc_record_modified_inode()
  jbd2: Cleanup unused functions declarations from jbd2.h
  jbd2: Refactor wait logic for transaction updates into a common function

 fs/ext4/fast_commit.c | 64 ++++++++++++++++++++-----------------------
 fs/ext4/inline.c      | 23 +++++++++-------
 fs/jbd2/commit.c      | 19 ++-----------
 fs/jbd2/transaction.c | 53 +++++++++++++++++++++--------------
 include/linux/jbd2.h  | 11 ++------
 5 files changed, 80 insertions(+), 90 deletions(-)

--
2.31.1

Comments

Theodore Ts'o Jan. 20, 2022, 3:58 p.m. UTC | #1

On Mon, 17 Jan 2022 17:41:46 +0530, Ritesh Harjani wrote:
> Please find v2 of the inline_data fixes and some minor cleanups found during
> code review.
> 
> I have dropped patch-6 in v2 which was removing use of t_handle_lock (spinlock)
> from within jbd2_journal_wait_updates(). Based on Jan comments, I feel we can
> push that as killing of t_handle_lock into a separate series (which will be on
> top of this).
> 
> [...]

Applied, thanks!

[1/5] ext4: Fix error handling in ext4_restore_inline_data()
      commit: 2fdd85005f708691a64270ecb67d98191d668c4c
[2/5] ext4: Remove redundant max inline_size check in ext4_da_write_inline_data_begin()
      commit: c7fc77e512a432bba754f969c4eb72b33cda3431
[3/5] ext4: Fix error handling in ext4_fc_record_modified_inode()
      commit: 6dcee78ea266fb736a3357c2e04d81ee7ec7b6e4
[4/5] jbd2: Cleanup unused functions declarations from jbd2.h
      commit: 16263b9820b0d40c778c8ee867f853d3fe638f37
[5/5] jbd2: Refactor wait logic for transaction updates into a common function
      commit: b0544c1f23ddeabd89480d842867ca1c6894e021

Best regards,