| Message ID | 20220112103609.17421-2-leilk.liu@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add compatible for Mediatek MT8186 | expand |
On Wed, Jan 12, 2022 at 06:36:07PM +0800, Leilk Liu wrote: > Convert Mediatek ARM SOC's SPI Slave controller binding > to json-schema format. > > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com> > --- > .../spi/mediatek,spi-slave-mt27xx.yaml | 73 +++++++++++++++++++ > .../bindings/spi/spi-slave-mt27xx.txt | 33 --------- > 2 files changed, 73 insertions(+), 33 deletions(-) > create mode 100644 Documentation/devicetree/bindings/spi/mediatek,spi-slave-mt27xx.yaml > delete mode 100644 Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-slave-mt27xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-slave-mt27xx.yaml > new file mode 100644 > index 000000000000..3364fff08cca > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-slave-mt27xx.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/mediatek,spi-slave-mt27xx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: SPI Slave controller for MediaTek ARM SoCs > + > +maintainers: > + - Leilk Liu <leilk.liu@mediatek.com> > + > +allOf: > + - $ref: /spi/spi-controller.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - mediatek,mt2712-spi-slave > + - items: > + - enum: > + - mediatek,mt8195-spi-slave Just: enum: - mediatek,mt2712-spi-slave - mediatek,mt8195-spi-slave > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: clock used for the clock gate Just 'maxItems: 1' > + > + clock-names: > + items: > + - const: spi > + > + assigned-clocks: > + maxItems: 1 > + description: | > + The mux clock for the given platform. > + > + assigned-clock-parents: > + maxItems: 1 > + description: | > + The parent of mux clock for the given platform. You can drop assigned-clocks. They are always allowed on nodes with 'clocks'. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/mt2712-clk.h> > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + spi@10013000 { > + compatible = "mediatek,mt2712-spi-slave"; > + reg = <0x10013000 0x100>; > + interrupts = <GIC_SPI 283 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&infracfg CLK_INFRA_AO_SPI1>; > + clock-names = "spi"; > + assigned-clocks = <&topckgen CLK_TOP_SPISLV_SEL>; > + assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL1_D2>; > + };
On Fri, 2022-01-21 at 18:53 -0600, Rob Herring wrote: > On Wed, Jan 12, 2022 at 06:36:07PM +0800, Leilk Liu wrote: > > Convert Mediatek ARM SOC's SPI Slave controller binding > > to json-schema format. > > > > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com> > > --- > > .../spi/mediatek,spi-slave-mt27xx.yaml | 73 > > +++++++++++++++++++ > > .../bindings/spi/spi-slave-mt27xx.txt | 33 --------- > > 2 files changed, 73 insertions(+), 33 deletions(-) > > create mode 100644 > > Documentation/devicetree/bindings/spi/mediatek,spi-slave- > > mt27xx.yaml > > delete mode 100644 Documentation/devicetree/bindings/spi/spi- > > slave-mt27xx.txt > > > > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi- > > slave-mt27xx.yaml > > b/Documentation/devicetree/bindings/spi/mediatek,spi-slave- > > mt27xx.yaml > > new file mode 100644 > > index 000000000000..3364fff08cca > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-slave- > > mt27xx.yaml > > @@ -0,0 +1,73 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > http://devicetree.org/schemas/spi/mediatek,spi-slave-mt27xx.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: SPI Slave controller for MediaTek ARM SoCs > > + > > +maintainers: > > + - Leilk Liu <leilk.liu@mediatek.com> > > + > > +allOf: > > + - $ref: /spi/spi-controller.yaml# > > + > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - mediatek,mt2712-spi-slave > > + - items: > > + - enum: > > + - mediatek,mt8195-spi-slave > > Just: > > enum: > - mediatek,mt2712-spi-slave > - mediatek,mt8195-spi-slave > OK, I'll fix it. > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: clock used for the clock gate > > Just 'maxItems: 1' > OK, I'll fix it. > > + > > + clock-names: > > + items: > > + - const: spi > > + > > + assigned-clocks: > > + maxItems: 1 > > + description: | > > + The mux clock for the given platform. > > + > > + assigned-clock-parents: > > + maxItems: 1 > > + description: | > > + The parent of mux clock for the given platform. > > You can drop assigned-clocks. They are always allowed on nodes with > 'clocks'. > OK, I'll fix it. > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/mt2712-clk.h> > > + #include <dt-bindings/gpio/gpio.h> > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/interrupt-controller/irq.h> > > + > > + spi@10013000 { > > + compatible = "mediatek,mt2712-spi-slave"; > > + reg = <0x10013000 0x100>; > > + interrupts = <GIC_SPI 283 IRQ_TYPE_LEVEL_LOW>; > > + clocks = <&infracfg CLK_INFRA_AO_SPI1>; > > + clock-names = "spi"; > > + assigned-clocks = <&topckgen CLK_TOP_SPISLV_SEL>; > > + assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL1_D2>; > > + };
diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-slave-mt27xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-slave-mt27xx.yaml new file mode 100644 index 000000000000..3364fff08cca --- /dev/null +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-slave-mt27xx.yaml @@ -0,0 +1,73 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/spi/mediatek,spi-slave-mt27xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: SPI Slave controller for MediaTek ARM SoCs + +maintainers: + - Leilk Liu <leilk.liu@mediatek.com> + +allOf: + - $ref: /spi/spi-controller.yaml# + +properties: + compatible: + oneOf: + - items: + - enum: + - mediatek,mt2712-spi-slave + - items: + - enum: + - mediatek,mt8195-spi-slave + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: clock used for the clock gate + + clock-names: + items: + - const: spi + + assigned-clocks: + maxItems: 1 + description: | + The mux clock for the given platform. + + assigned-clock-parents: + maxItems: 1 + description: | + The parent of mux clock for the given platform. + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/mt2712-clk.h> + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + + spi@10013000 { + compatible = "mediatek,mt2712-spi-slave"; + reg = <0x10013000 0x100>; + interrupts = <GIC_SPI 283 IRQ_TYPE_LEVEL_LOW>; + clocks = <&infracfg CLK_INFRA_AO_SPI1>; + clock-names = "spi"; + assigned-clocks = <&topckgen CLK_TOP_SPISLV_SEL>; + assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL1_D2>; + }; diff --git a/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt b/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt deleted file mode 100644 index 9192724540fd..000000000000 --- a/Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt +++ /dev/null @@ -1,33 +0,0 @@ -Binding for MTK SPI Slave controller - -Required properties: -- compatible: should be one of the following. - - mediatek,mt2712-spi-slave: for mt2712 platforms - - mediatek,mt8195-spi-slave: for mt8195 platforms -- reg: Address and length of the register set for the device. -- interrupts: Should contain spi interrupt. -- clocks: phandles to input clocks. - It's clock gate, and should be <&infracfg CLK_INFRA_AO_SPI1>. -- clock-names: should be "spi" for the clock gate. - -Optional properties: -- assigned-clocks: it's mux clock, should be <&topckgen CLK_TOP_SPISLV_SEL>. -- assigned-clock-parents: parent of mux clock. - It's PLL, and should be one of the following. - - <&topckgen CLK_TOP_UNIVPLL1_D2>: specify parent clock 312MHZ. - It's the default one. - - <&topckgen CLK_TOP_UNIVPLL1_D4>: specify parent clock 156MHZ. - - <&topckgen CLK_TOP_UNIVPLL2_D4>: specify parent clock 104MHZ. - - <&topckgen CLK_TOP_UNIVPLL1_D8>: specify parent clock 78MHZ. - -Example: -- SoC Specific Portion: -spis1: spi@10013000 { - compatible = "mediatek,mt2712-spi-slave"; - reg = <0 0x10013000 0 0x100>; - interrupts = <GIC_SPI 283 IRQ_TYPE_LEVEL_LOW>; - clocks = <&infracfg CLK_INFRA_AO_SPI1>; - clock-names = "spi"; - assigned-clocks = <&topckgen CLK_TOP_SPISLV_SEL>; - assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL1_D2>; -};
Convert Mediatek ARM SOC's SPI Slave controller binding to json-schema format. Signed-off-by: Leilk Liu <leilk.liu@mediatek.com> --- .../spi/mediatek,spi-slave-mt27xx.yaml | 73 +++++++++++++++++++ .../bindings/spi/spi-slave-mt27xx.txt | 33 --------- 2 files changed, 73 insertions(+), 33 deletions(-) create mode 100644 Documentation/devicetree/bindings/spi/mediatek,spi-slave-mt27xx.yaml delete mode 100644 Documentation/devicetree/bindings/spi/spi-slave-mt27xx.txt