| Message ID | 20211231032354.793092-1-yukuai3@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | block, bfq: minor cleanup and fix | expand |
在 2021/12/31 11:23, Yu Kuai 写道: > Chagnes in v2: > - add comment in patch 2 > - remove patch 4, since the problem do not exist. > friendly ping ... > Yu Kuai (3): > block, bfq: cleanup bfq_bfqq_to_bfqg() > block, bfq: avoid moving bfqq to it's parent bfqg > block, bfq: don't move oom_bfqq > > block/bfq-cgroup.c | 16 +++++++++++++++- > block/bfq-iosched.c | 4 ++-- > block/bfq-iosched.h | 1 - > block/bfq-wf2q.c | 15 --------------- > 4 files changed, 17 insertions(+), 19 deletions(-) >
在 2022/01/11 9:40, yukuai (C) 写道: > 在 2021/12/31 11:23, Yu Kuai 写道: >> Chagnes in v2: >> - add comment in patch 2 >> - remove patch 4, since the problem do not exist. >> > friendly ping ... Hi, Jens Can this patchset be applied? Thanks >> Yu Kuai (3): >> block, bfq: cleanup bfq_bfqq_to_bfqg() >> block, bfq: avoid moving bfqq to it's parent bfqg >> block, bfq: don't move oom_bfqq >> >> block/bfq-cgroup.c | 16 +++++++++++++++- >> block/bfq-iosched.c | 4 ++-- >> block/bfq-iosched.h | 1 - >> block/bfq-wf2q.c | 15 --------------- >> 4 files changed, 17 insertions(+), 19 deletions(-) >>
On Fri 14-01-22 16:23:36, yukuai (C) wrote: > 在 2022/01/11 9:40, yukuai (C) 写道: > > 在 2021/12/31 11:23, Yu Kuai 写道: > > > Chagnes in v2: > > > - add comment in patch 2 > > > - remove patch 4, since the problem do not exist. > > > > > friendly ping ... > > Hi, Jens > > Can this patchset be applied? Maybe Jens is waiting for Paolo's ack as a BFQ maintainer. Paolo, what do you think about the cleanups? They seem mostly obvious to me... Honza > > Thanks > > > Yu Kuai (3): > > > block, bfq: cleanup bfq_bfqq_to_bfqg() > > > block, bfq: avoid moving bfqq to it's parent bfqg > > > block, bfq: don't move oom_bfqq > > > > > > block/bfq-cgroup.c | 16 +++++++++++++++- > > > block/bfq-iosched.c | 4 ++-- > > > block/bfq-iosched.h | 1 - > > > block/bfq-wf2q.c | 15 --------------- > > > 4 files changed, 17 insertions(+), 19 deletions(-) > > >
> Il giorno 31 dic 2021, alle ore 04:23, Yu Kuai <yukuai3@huawei.com> ha scritto: > > Chagnes in v2: > - add comment in patch 2 > - remove patch 4, since the problem do not exist. > > Yu Kuai (3): > block, bfq: cleanup bfq_bfqq_to_bfqg() > block, bfq: avoid moving bfqq to it's parent bfqg > block, bfq: don't move oom_bfqq > All Acked-by: Paolo Valente <paolo.valente@linaro.org> Thanks, Paolo > block/bfq-cgroup.c | 16 +++++++++++++++- > block/bfq-iosched.c | 4 ++-- > block/bfq-iosched.h | 1 - > block/bfq-wf2q.c | 15 --------------- > 4 files changed, 17 insertions(+), 19 deletions(-) > > -- > 2.31.1 >
在 2021/12/31 11:23, Yu Kuai 写道: > Chagnes in v2: > - add comment in patch 2 > - remove patch 4, since the problem do not exist. > > Yu Kuai (3): > block, bfq: cleanup bfq_bfqq_to_bfqg() > block, bfq: avoid moving bfqq to it's parent bfqg > block, bfq: don't move oom_bfqq > > block/bfq-cgroup.c | 16 +++++++++++++++- > block/bfq-iosched.c | 4 ++-- > block/bfq-iosched.h | 1 - > block/bfq-wf2q.c | 15 --------------- > 4 files changed, 17 insertions(+), 19 deletions(-) > Hi, jens Now that with acked-by Paolo, can you please applied this pathset? Thanks, Kuai
在 2022/01/24 11:46, yukuai (C) 写道: > 在 2021/12/31 11:23, Yu Kuai 写道: >> Chagnes in v2: >> - add comment in patch 2 >> - remove patch 4, since the problem do not exist. >> >> Yu Kuai (3): >> block, bfq: cleanup bfq_bfqq_to_bfqg() >> block, bfq: avoid moving bfqq to it's parent bfqg >> block, bfq: don't move oom_bfqq >> >> block/bfq-cgroup.c | 16 +++++++++++++++- >> block/bfq-iosched.c | 4 ++-- >> block/bfq-iosched.h | 1 - >> block/bfq-wf2q.c | 15 --------------- >> 4 files changed, 17 insertions(+), 19 deletions(-) >> > Hi, jens > > Now that with acked-by Paolo, can you please applied this pathset? friendly ping ... > > Thanks, > Kuai
On Fri, 31 Dec 2021 11:23:51 +0800, Yu Kuai wrote: > Chagnes in v2: > - add comment in patch 2 > - remove patch 4, since the problem do not exist. > > Yu Kuai (3): > block, bfq: cleanup bfq_bfqq_to_bfqg() > block, bfq: avoid moving bfqq to it's parent bfqg > block, bfq: don't move oom_bfqq > > [...] Applied, thanks! [1/3] block, bfq: cleanup bfq_bfqq_to_bfqg() commit: a9c77f6ec0b566439182a10b64dd3e60a0408849 [2/3] block, bfq: avoid moving bfqq to it's parent bfqg commit: 36ad7fe0ec7485ee435f7a40452c7a58598779d4 [3/3] block, bfq: don't move oom_bfqq commit: a0b98e6fba18a40aa9672cc3e0abf980456f3ae6 Best regards,
On 1/28/22 7:45 AM, Jens Axboe wrote: > On Fri, 31 Dec 2021 11:23:51 +0800, Yu Kuai wrote: >> Chagnes in v2: >> - add comment in patch 2 >> - remove patch 4, since the problem do not exist. >> >> Yu Kuai (3): >> block, bfq: cleanup bfq_bfqq_to_bfqg() >> block, bfq: avoid moving bfqq to it's parent bfqg >> block, bfq: don't move oom_bfqq >> >> [...] > > Applied, thanks! > > [1/3] block, bfq: cleanup bfq_bfqq_to_bfqg() > commit: a9c77f6ec0b566439182a10b64dd3e60a0408849 > [2/3] block, bfq: avoid moving bfqq to it's parent bfqg > commit: 36ad7fe0ec7485ee435f7a40452c7a58598779d4 > [3/3] block, bfq: don't move oom_bfqq > commit: a0b98e6fba18a40aa9672cc3e0abf980456f3ae6 For all those pings, this patchset sure didn't see a lot of compiles: block/bfq-cgroup.c: In function ‘bfq_bfqq_move’: block/bfq-cgroup.c:648:40: error: implicit declaration of function ‘bfq_group’; did you mean ‘bfqq_group’? [-Werror=implicit-function-declaration] 648 | struct bfq_group *old_parent = bfq_group(bfqq); | ^~~~~~~~~ | bfqq_group block/bfq-cgroup.c:648:40: error: initialization of ‘struct bfq_group *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion] cc1: all warnings being treated as errors make[1]: *** [scripts/Makefile.build:288: block/bfq-cgroup.o] Error 1 make: *** [Makefile:1831: block] Error 2 Dropped.
在 2022/01/29 3:27, Jens Axboe 写道: > On 1/28/22 7:45 AM, Jens Axboe wrote: >> On Fri, 31 Dec 2021 11:23:51 +0800, Yu Kuai wrote: >>> Chagnes in v2: >>> - add comment in patch 2 >>> - remove patch 4, since the problem do not exist. >>> >>> Yu Kuai (3): >>> block, bfq: cleanup bfq_bfqq_to_bfqg() >>> block, bfq: avoid moving bfqq to it's parent bfqg >>> block, bfq: don't move oom_bfqq >>> >>> [...] >> >> Applied, thanks! >> >> [1/3] block, bfq: cleanup bfq_bfqq_to_bfqg() >> commit: a9c77f6ec0b566439182a10b64dd3e60a0408849 >> [2/3] block, bfq: avoid moving bfqq to it's parent bfqg >> commit: 36ad7fe0ec7485ee435f7a40452c7a58598779d4 >> [3/3] block, bfq: don't move oom_bfqq >> commit: a0b98e6fba18a40aa9672cc3e0abf980456f3ae6 > > For all those pings, this patchset sure didn't see a lot of compiles: > > block/bfq-cgroup.c: In function ‘bfq_bfqq_move’: > block/bfq-cgroup.c:648:40: error: implicit declaration of function ‘bfq_group’; did you mean ‘bfqq_group’? [-Werror=implicit-function-declaration] > 648 | struct bfq_group *old_parent = bfq_group(bfqq); > | ^~~~~~~~~ > | bfqq_group > block/bfq-cgroup.c:648:40: error: initialization of ‘struct bfq_group *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion] > cc1: all warnings being treated as errors > make[1]: *** [scripts/Makefile.build:288: block/bfq-cgroup.o] Error 1 > make: *** [Makefile:1831: block] Error 2 > > Dropped. > Hi, I'm sincerely sorry for this, I do forget to compiles this patchset, and let this stupid clerical error exposure to you... I'll send anothor version of patch 2. Thanks, Kuai