| Message ID | 20220123184035.112785-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9f16e0fa1079022632880da3e8346537ba4eeecc |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: usb: asix: remove redundant assignment to variable reg | expand |
On Sun, Jan 23, 2022 at 06:40:35PM +0000, Colin Ian King wrote: > Variable reg is being masked however the variable is never read > after this. The assignment is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de> Thank you! > --- > drivers/net/usb/asix_devices.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c > index 4514d35ef4c4..9b72334aabb6 100644 > --- a/drivers/net/usb/asix_devices.c > +++ b/drivers/net/usb/asix_devices.c > @@ -858,7 +858,6 @@ static int marvell_phy_init(struct usbnet *dev) > reg = asix_mdio_read(dev->net, dev->mii.phy_id, > MII_MARVELL_LED_CTRL); > netdev_dbg(dev->net, "MII_MARVELL_LED_CTRL (2) = 0x%04x\n", reg); > - reg &= 0xfc0f; > } > > return 0; > -- > 2.33.1 > >
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Sun, 23 Jan 2022 18:40:35 +0000 you wrote: > Variable reg is being masked however the variable is never read > after this. The assignment is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/net/usb/asix_devices.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - net: usb: asix: remove redundant assignment to variable reg https://git.kernel.org/netdev/net-next/c/9f16e0fa1079 You are awesome, thank you!
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c index 4514d35ef4c4..9b72334aabb6 100644 --- a/drivers/net/usb/asix_devices.c +++ b/drivers/net/usb/asix_devices.c @@ -858,7 +858,6 @@ static int marvell_phy_init(struct usbnet *dev) reg = asix_mdio_read(dev->net, dev->mii.phy_id, MII_MARVELL_LED_CTRL); netdev_dbg(dev->net, "MII_MARVELL_LED_CTRL (2) = 0x%04x\n", reg); - reg &= 0xfc0f; } return 0;
Variable reg is being masked however the variable is never read after this. The assignment is redundant and can be removed. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/usb/asix_devices.c | 1 - 1 file changed, 1 deletion(-)