| Message ID | 20220124151357.2467149-1-carsten.haitzler@foss.arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER | expand |
Sorry - noise. Ignore this one. Following one is fixed. On 1/24/22 15:13, carsten.haitzler@foss.arm.com wrote: > From: Carsten Haitzler <carsten.haitzler@arm.com> > > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too. > > Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com> > --- > drivers/gpu/drm/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig > index 58a242871b28..6e3f1d600541 100644 > --- a/drivers/gpu/drm/arm/Kconfig > +++ b/drivers/gpu/drm/arm/Kconfig > @@ -6,6 +6,7 @@ config DRM_HDLCD > depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) > depends on COMMON_CLK > select DRM_KMS_HELPER > + select DRM_GEM_CMA_HELPER > help > Choose this option if you have an ARM High Definition Colour LCD > controller.
On 24/01/2022 15:13, carsten.haitzler@foss.arm.com wrote: > From: Carsten Haitzler <carsten.haitzler@arm.com> > > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too. > > Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com> To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that was removed in commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option"). DRM_KMS_CMA_HELPER would select DRM_GEM_CMA_HELPER but that transitive dependency was lost and apparently the fixup was missed in that commit. So we need a: Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") and with that... Reviewed-by: Steven Price <steven.price@arm.com> Steve > --- > drivers/gpu/drm/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig > index 58a242871b28..6e3f1d600541 100644 > --- a/drivers/gpu/drm/arm/Kconfig > +++ b/drivers/gpu/drm/arm/Kconfig > @@ -6,6 +6,7 @@ config DRM_HDLCD > depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) > depends on COMMON_CLK > select DRM_KMS_HELPER > + select DRM_GEM_CMA_HELPER > help > Choose this option if you have an ARM High Definition Colour LCD > controller. >
I sent an updated patch with the Fixes: On 1/24/22 16:13, Steven Price wrote: > On 24/01/2022 15:13, carsten.haitzler@foss.arm.com wrote: >> From: Carsten Haitzler <carsten.haitzler@arm.com> >> >> Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too. >> >> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com> > > To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that > was removed in commit 09717af7d13d ("drm: Remove > CONFIG_DRM_KMS_CMA_HELPER option"). DRM_KMS_CMA_HELPER would select > DRM_GEM_CMA_HELPER but that transitive dependency was lost and > apparently the fixup was missed in that commit. > > So we need a: > > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") > > and with that... > > Reviewed-by: Steven Price <steven.price@arm.com> > > Steve > >> --- >> drivers/gpu/drm/arm/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig >> index 58a242871b28..6e3f1d600541 100644 >> --- a/drivers/gpu/drm/arm/Kconfig >> +++ b/drivers/gpu/drm/arm/Kconfig >> @@ -6,6 +6,7 @@ config DRM_HDLCD >> depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) >> depends on COMMON_CLK >> select DRM_KMS_HELPER >> + select DRM_GEM_CMA_HELPER >> help >> Choose this option if you have an ARM High Definition Colour LCD >> controller. >> >
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index 58a242871b28..6e3f1d600541 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -6,6 +6,7 @@ config DRM_HDLCD depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) depends on COMMON_CLK select DRM_KMS_HELPER + select DRM_GEM_CMA_HELPER help Choose this option if you have an ARM High Definition Colour LCD controller.