| Message ID | 20220125141422.32655-9-cgzones@googlemail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Paul Moore |
| Headers | show |
| Series | [1/9] selinux: check return value of sel_make_avc_files | expand |
On Tue, Jan 25, 2022 at 6:15 AM Christian Göttsche <cgzones@googlemail.com> wrote: > > sel_make_avc_files() might fail and return a negative errno value on > memory allocation failures. Re-add the check of the return value, > dropped in 66f8e2f03c02. > > Reported by clang-analyzer: > > security/selinux/selinuxfs.c:2129:2: warning: Value stored to 'ret' is never read [deadcode.DeadStores] > ret = sel_make_avc_files(dentry); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Fixes: 66f8e2f03c02 ("selinux: sidtab reverse lookup hash table") > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > security/selinux/selinuxfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c > index e4cd7cb856f3..f2f6203e0fff 100644 > --- a/security/selinux/selinuxfs.c > +++ b/security/selinux/selinuxfs.c > @@ -2127,6 +2127,8 @@ static int sel_fill_super(struct super_block *sb, struct fs_context *fc) > } > > ret = sel_make_avc_files(dentry); > + if (ret) > + goto err; > > dentry = sel_make_dir(sb->s_root, "ss", &fsi->last_ino); > if (IS_ERR(dentry)) { > -- > 2.34.1 >
On Tue, Jan 25, 2022 at 9:15 AM Christian Göttsche <cgzones@googlemail.com> wrote: > > sel_make_avc_files() might fail and return a negative errno value on > memory allocation failures. Re-add the check of the return value, > dropped in 66f8e2f03c02. > > Reported by clang-analyzer: > > security/selinux/selinuxfs.c:2129:2: warning: Value stored to 'ret' is never read [deadcode.DeadStores] > ret = sel_make_avc_files(dentry); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Fixes: 66f8e2f03c02 ("selinux: sidtab reverse lookup hash table") > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> > --- > security/selinux/selinuxfs.c | 2 ++ > 1 file changed, 2 insertions(+) Merged into selinux/next, thanks Christian.
diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c index e4cd7cb856f3..f2f6203e0fff 100644 --- a/security/selinux/selinuxfs.c +++ b/security/selinux/selinuxfs.c @@ -2127,6 +2127,8 @@ static int sel_fill_super(struct super_block *sb, struct fs_context *fc) } ret = sel_make_avc_files(dentry); + if (ret) + goto err; dentry = sel_make_dir(sb->s_root, "ss", &fsi->last_ino); if (IS_ERR(dentry)) {
sel_make_avc_files() might fail and return a negative errno value on memory allocation failures. Re-add the check of the return value, dropped in 66f8e2f03c02. Reported by clang-analyzer: security/selinux/selinuxfs.c:2129:2: warning: Value stored to 'ret' is never read [deadcode.DeadStores] ret = sel_make_avc_files(dentry); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 66f8e2f03c02 ("selinux: sidtab reverse lookup hash table") Signed-off-by: Christian Göttsche <cgzones@googlemail.com> --- security/selinux/selinuxfs.c | 2 ++ 1 file changed, 2 insertions(+)