Message ID | 20220124141644.71052-1-alim.akhtar@samsung.com (mailing list archive) |
---|---|
Headers | show |
Series | Add support for Tesla Full Self-Driving (FSD) SoC | expand |
On 24/01/2022 15:16, Alim Akhtar wrote: > Adds basic support for the Tesla Full Self-Driving (FSD) > SoC. This SoC contains three clusters of four Cortex-A72 CPUs, > as well as several IPs. > > Patches 1 to 9 provide support for the clock controller > (which is designed similarly to Exynos SoCs). > > The remaining changes provide pinmux support, initial device tree support. > > - Changes since v4 > * fixed 'make dtbs_check' warnings on patch 14/16 > > - Changes since v3 > * Addressed Stefen's review comments on patch 14/16 > * Fixed kernel test robot warning on patch 04/16 > * rebsaed this series on Krzysztof's pinmux new binding schema work [1] > > - Changes since v2 > * Addressed Krzysztof's and Stephen's review comments > * Added Reviewed-by and Acked-by tags > * Rebased on next-20220120 > > - Changes since v1 > * fixed make dt_binding_check error as pointed by Rob > * Addressed Krzysztof's and Rob's review comments > * Added Reviewed-by and Acked-by tags > * Dropped SPI, MCT and ADC from this series (to be posted in small sets) > > NOTE: These patches are based on Krzysztof's pinmux for-next branch > commit 832ae134ccc1 ("pinctrl: samsung: add support for Exynos850 and ExynosAutov9 wake-ups") > [1] https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/samsung.git/log/?h=for-next > > Thanks, applied DTS/soc and pinctrl patches. I expect Sylwester will pick up the clock ones. Otherwise please let me know to pick it up as well. Best regards, Krzysztof
On 25/01/2022 18:12, Krzysztof Kozlowski wrote: > On 24/01/2022 15:16, Alim Akhtar wrote: >> Adds basic support for the Tesla Full Self-Driving (FSD) >> SoC. This SoC contains three clusters of four Cortex-A72 CPUs, >> as well as several IPs. >> >> Patches 1 to 9 provide support for the clock controller >> (which is designed similarly to Exynos SoCs). >> >> The remaining changes provide pinmux support, initial device tree support. >> >> - Changes since v4 >> * fixed 'make dtbs_check' warnings on patch 14/16 >> >> - Changes since v3 >> * Addressed Stefen's review comments on patch 14/16 >> * Fixed kernel test robot warning on patch 04/16 >> * rebsaed this series on Krzysztof's pinmux new binding schema work [1] >> >> - Changes since v2 >> * Addressed Krzysztof's and Stephen's review comments >> * Added Reviewed-by and Acked-by tags >> * Rebased on next-20220120 >> >> - Changes since v1 >> * fixed make dt_binding_check error as pointed by Rob >> * Addressed Krzysztof's and Rob's review comments >> * Added Reviewed-by and Acked-by tags >> * Dropped SPI, MCT and ADC from this series (to be posted in small sets) >> >> NOTE: These patches are based on Krzysztof's pinmux for-next branch >> commit 832ae134ccc1 ("pinctrl: samsung: add support for Exynos850 and ExynosAutov9 wake-ups") >> [1] https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/samsung.git/log/?h=for-next >> >> > > Thanks, applied DTS/soc and pinctrl patches. > > I expect Sylwester will pick up the clock ones. Otherwise please let me > know to pick it up as well. I forgot that clock macros are used in DTS. This does not compile and I cannot take drivers into DTS branch. Alim, DTS changes dropped. Please resend with the same trick we did for Exynos850 board - hard-coded clock IDs as defines. See: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/diff/arch/arm64/boot/dts/exynos/exynos850.dtsi?h=samsung-dt64-5.17-2&id=e3493220fd3e474abcdcefbe14fb60485097ce06 Best regards, Krzysztof
Hi Krzysztof >-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >Sent: Tuesday, January 25, 2022 10:56 PM >To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm- >kernel@lists.infradead.org; linux-kernel@vger.kernel.org >Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; >olof@lixom.net; arnd@arndb.de; linus.walleij@linaro.org; >catalin.marinas@arm.com; robh+dt@kernel.org; s.nawrocki@samsung.com; >linux-samsung-soc@vger.kernel.org; pankaj.dubey@samsung.com; >sboyd@kernel.org >Subject: Re: [PATCH v5 00/16] Add support for Tesla Full Self-Driving (FSD) SoC > >On 25/01/2022 18:12, Krzysztof Kozlowski wrote: >> On 24/01/2022 15:16, Alim Akhtar wrote: >>> Adds basic support for the Tesla Full Self-Driving (FSD) SoC. This >>> SoC contains three clusters of four Cortex-A72 CPUs, as well as >>> several IPs. >>> >>> Patches 1 to 9 provide support for the clock controller (which is >>> designed similarly to Exynos SoCs). >>> >>> The remaining changes provide pinmux support, initial device tree support. >>> >>> - Changes since v4 >>> * fixed 'make dtbs_check' warnings on patch 14/16 >>> >>> - Changes since v3 >>> * Addressed Stefen's review comments on patch 14/16 >>> * Fixed kernel test robot warning on patch 04/16 >>> * rebsaed this series on Krzysztof's pinmux new binding schema work >>> [1] >>> >>> - Changes since v2 >>> * Addressed Krzysztof's and Stephen's review comments >>> * Added Reviewed-by and Acked-by tags >>> * Rebased on next-20220120 >>> >>> - Changes since v1 >>> * fixed make dt_binding_check error as pointed by Rob >>> * Addressed Krzysztof's and Rob's review comments >>> * Added Reviewed-by and Acked-by tags >>> * Dropped SPI, MCT and ADC from this series (to be posted in small >>> sets) >>> >>> NOTE: These patches are based on Krzysztof's pinmux for-next branch >>> commit 832ae134ccc1 ("pinctrl: samsung: add support for Exynos850 and >>> ExynosAutov9 wake-ups") [1] >>> https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/samsung.git/l >>> og/?h=for-next >>> >>> >> >> Thanks, applied DTS/soc and pinctrl patches. >> >> I expect Sylwester will pick up the clock ones. Otherwise please let >> me know to pick it up as well. > >I forgot that clock macros are used in DTS. This does not compile and I cannot >take drivers into DTS branch. > >Alim, >DTS changes dropped. Please resend with the same trick we did for >Exynos850 board - hard-coded clock IDs as defines. See: > >https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/diff/arch/arm6 >4/boot/dts/exynos/exynos850.dtsi?h=samsung-dt64-5.17- >2&id=e3493220fd3e474abcdcefbe14fb60485097ce06 > Ok, I will resend patch 14 and 15 (DTS changes) only as suggested above. > >Best regards, >Krzysztof
>-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >Sent: Tuesday, January 25, 2022 10:42 PM >To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm- >kernel@lists.infradead.org; linux-kernel@vger.kernel.org >Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; >olof@lixom.net; arnd@arndb.de; linus.walleij@linaro.org; >catalin.marinas@arm.com; robh+dt@kernel.org; s.nawrocki@samsung.com; >linux-samsung-soc@vger.kernel.org; pankaj.dubey@samsung.com; >sboyd@kernel.org >Subject: Re: [PATCH v5 00/16] Add support for Tesla Full Self-Driving (FSD) SoC > >On 24/01/2022 15:16, Alim Akhtar wrote: >> Adds basic support for the Tesla Full Self-Driving (FSD) SoC. This SoC >> contains three clusters of four Cortex-A72 CPUs, as well as several >> IPs. >> >> Patches 1 to 9 provide support for the clock controller (which is >> designed similarly to Exynos SoCs). >> >> The remaining changes provide pinmux support, initial device tree support. >> >> - Changes since v4 >> * fixed 'make dtbs_check' warnings on patch 14/16 >> >> - Changes since v3 >> * Addressed Stefen's review comments on patch 14/16 >> * Fixed kernel test robot warning on patch 04/16 >> * rebsaed this series on Krzysztof's pinmux new binding schema work >> [1] >> >> - Changes since v2 >> * Addressed Krzysztof's and Stephen's review comments >> * Added Reviewed-by and Acked-by tags >> * Rebased on next-20220120 >> >> - Changes since v1 >> * fixed make dt_binding_check error as pointed by Rob >> * Addressed Krzysztof's and Rob's review comments >> * Added Reviewed-by and Acked-by tags >> * Dropped SPI, MCT and ADC from this series (to be posted in small >> sets) >> >> NOTE: These patches are based on Krzysztof's pinmux for-next branch >> commit 832ae134ccc1 ("pinctrl: samsung: add support for Exynos850 and >> ExynosAutov9 wake-ups") [1] >> https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/samsung.git/lo >> g/?h=for-next >> >> > >Thanks, applied DTS/soc and pinctrl patches. > Thanks Krzysztof >I expect Sylwester will pick up the clock ones. Otherwise please let me know >to pick it up as well. > Hi Sylwester, hope you will be taking clock changes, or let Krzysztof know otherwise. Thanks > >Best regards, >Krzysztof
On 26/01/2022 07:50, Alim Akhtar wrote: > Hi Krzysztof > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >> Sent: Tuesday, January 25, 2022 10:56 PM >> To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm- >> kernel@lists.infradead.org; linux-kernel@vger.kernel.org >> Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; >> olof@lixom.net; arnd@arndb.de; linus.walleij@linaro.org; >> catalin.marinas@arm.com; robh+dt@kernel.org; s.nawrocki@samsung.com; >> linux-samsung-soc@vger.kernel.org; pankaj.dubey@samsung.com; >> sboyd@kernel.org >> Subject: Re: [PATCH v5 00/16] Add support for Tesla Full Self-Driving (FSD) SoC >> >> On 25/01/2022 18:12, Krzysztof Kozlowski wrote: >>> On 24/01/2022 15:16, Alim Akhtar wrote: >>>> Adds basic support for the Tesla Full Self-Driving (FSD) SoC. This >>>> SoC contains three clusters of four Cortex-A72 CPUs, as well as >>>> several IPs. >>>> >>>> Patches 1 to 9 provide support for the clock controller (which is >>>> designed similarly to Exynos SoCs). >>>> >>>> The remaining changes provide pinmux support, initial device tree support. >>>> >>>> - Changes since v4 >>>> * fixed 'make dtbs_check' warnings on patch 14/16 >>>> >>>> - Changes since v3 >>>> * Addressed Stefen's review comments on patch 14/16 >>>> * Fixed kernel test robot warning on patch 04/16 >>>> * rebsaed this series on Krzysztof's pinmux new binding schema work >>>> [1] >>>> >>>> - Changes since v2 >>>> * Addressed Krzysztof's and Stephen's review comments >>>> * Added Reviewed-by and Acked-by tags >>>> * Rebased on next-20220120 >>>> >>>> - Changes since v1 >>>> * fixed make dt_binding_check error as pointed by Rob >>>> * Addressed Krzysztof's and Rob's review comments >>>> * Added Reviewed-by and Acked-by tags >>>> * Dropped SPI, MCT and ADC from this series (to be posted in small >>>> sets) >>>> >>>> NOTE: These patches are based on Krzysztof's pinmux for-next branch >>>> commit 832ae134ccc1 ("pinctrl: samsung: add support for Exynos850 and >>>> ExynosAutov9 wake-ups") [1] >>>> https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/samsung.git/l >>>> og/?h=for-next >>>> >>>> >>> >>> Thanks, applied DTS/soc and pinctrl patches. >>> >>> I expect Sylwester will pick up the clock ones. Otherwise please let >>> me know to pick it up as well. >> >> I forgot that clock macros are used in DTS. This does not compile and I cannot >> take drivers into DTS branch. >> >> Alim, >> DTS changes dropped. Please resend with the same trick we did for >> Exynos850 board - hard-coded clock IDs as defines. See: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/diff/arch/arm6 >> 4/boot/dts/exynos/exynos850.dtsi?h=samsung-dt64-5.17- >> 2&id=e3493220fd3e474abcdcefbe14fb60485097ce06 >> > Ok, I will resend patch 14 and 15 (DTS changes) only as suggested above. I see Sylwester acked clock patches, so I will take them. No need to resend, I'll organize the patches so they will compile. Best regards, Krzysztof
Hi, On 26.01.2022 07:52, Alim Akhtar wrote: >> >> Thanks, applied DTS/soc and pinctrl patches. >> > Thanks Krzysztof > >> I expect Sylwester will pick up the clock ones. Otherwise please let me know >> to pick it up as well. >> > Hi Sylwester, hope you will be taking clock changes, or let Krzysztof know otherwise. > Thanks Krzysztof, can you also take the clk patches through your tree? If you prefer to avoid it I will create a topic branch with the clk headers and DT bindings documentation.
On 26/01/2022 10:21, Sylwester Nawrocki wrote: > Hi, > > On 26.01.2022 07:52, Alim Akhtar wrote: >>> >>> Thanks, applied DTS/soc and pinctrl patches. >>> >> Thanks Krzysztof >> >>> I expect Sylwester will pick up the clock ones. Otherwise please let me know >>> to pick it up as well. >>> >> Hi Sylwester, hope you will be taking clock changes, or let Krzysztof know otherwise. >> Thanks > > Krzysztof, can you also take the clk patches through your tree? > If you prefer to avoid it I will create a topic branch with the > clk headers and DT bindings documentation. No problem, I'll consume everything I encounter :) Best regards, Krzysztof
On Mon, 24 Jan 2022 19:46:28 +0530, Alim Akhtar wrote: > Adds basic support for the Tesla Full Self-Driving (FSD) > SoC. This SoC contains three clusters of four Cortex-A72 CPUs, > as well as several IPs. > > Patches 1 to 9 provide support for the clock controller > (which is designed similarly to Exynos SoCs). > > [...] Applied also clock parts, thanks! [01/16] dt-bindings: add vendor prefix for Tesla commit: a5a93e9b9ab9b4f367a773b32bbe1687006d75b7 [02/16] dt-bindings: clock: Add bindings definitions for FSD CMU blocks commit: d6dc675377261472adda696da456b4ebcc5bb9d9 [03/16] dt-bindings: clock: Document FSD CMU bindings commit: ed68db7b7f2fd01e930fa3e6fbb75954dc25e41c [04/16] clk: samsung: fsd: Add initial clock support commit: 4f346005aaed641042ca18171c4383a6a85f6a8b [05/16] clk: samsung: fsd: Add cmu_peric block clock information commit: e3f3dc3810d3765128d28b241f4afb761d81678a [06/16] clk: samsung: fsd: Add cmu_fsys0 clock information commit: a15e367b02543f96ae845baf7be4526080437305 [07/16] clk: samsung: fsd: Add cmu_fsys1 clock information commit: bfbce52e4649b9a2c7296a6296ffbdfc3b07de2e [08/16] clk: samsung: fsd: Add cmu_imem block clock information commit: ca0fdfd131c7d33984d8feeda23a99e883ffb0cb [09/16] clk: samsung: fsd: Add cmu_mfc block clock information commit: 75c50afaa0d9a3e8f96940451bed6d0ccc6a0a03 [10/16] clk: samsung: fsd: Add cam_csi block clock information commit: b826c3e4de1a44ad8e5536d86d5ef062a54ed2b2 [13/16] dt-bindings: arm: add Tesla FSD ARM SoC commit: d25c5eb511df3439cd91517bcbce4b274f8972b9 [14/16] arm64: dts: fsd: Add initial device tree support commit: 18b1db6a162c29695920fdf212ccb8d7d5c07e9a [15/16] arm64: dts: fsd: Add initial pinctrl support commit: 684dac402f212d8ededbe7d97bc42a5e49533f40 [16/16] arm64: defconfig: Enable Tesla FSD SoC commit: 0d525a653b03a25190650f783026c8e655268b48 Best regards,
>-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >Sent: Wednesday, January 26, 2022 2:50 PM >To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm- >kernel@lists.infradead.org; linux-kernel@vger.kernel.org >Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; >olof@lixom.net; arnd@arndb.de; linus.walleij@linaro.org; >catalin.marinas@arm.com; robh+dt@kernel.org; s.nawrocki@samsung.com; >linux-samsung-soc@vger.kernel.org; pankaj.dubey@samsung.com; >sboyd@kernel.org >Subject: Re: [PATCH v5 00/16] Add support for Tesla Full Self-Driving (FSD) SoC > >On 26/01/2022 07:50, Alim Akhtar wrote: >> Hi Krzysztof >> >>> -----Original Message----- >>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >>> Sent: Tuesday, January 25, 2022 10:56 PM >>> To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm- >>> kernel@lists.infradead.org; linux-kernel@vger.kernel.org >>> Cc: soc@kernel.org; linux-clk@vger.kernel.org; >>> devicetree@vger.kernel.org; olof@lixom.net; arnd@arndb.de; >>> linus.walleij@linaro.org; catalin.marinas@arm.com; >>> robh+dt@kernel.org; s.nawrocki@samsung.com; >>> linux-samsung-soc@vger.kernel.org; pankaj.dubey@samsung.com; >>> sboyd@kernel.org >>> Subject: Re: [PATCH v5 00/16] Add support for Tesla Full Self-Driving >>> (FSD) SoC >>> >>> On 25/01/2022 18:12, Krzysztof Kozlowski wrote: >>>> On 24/01/2022 15:16, Alim Akhtar wrote: >>>>> Adds basic support for the Tesla Full Self-Driving (FSD) SoC. This >>>>> SoC contains three clusters of four Cortex-A72 CPUs, as well as >>>>> several IPs. >>>>> >>>>> Patches 1 to 9 provide support for the clock controller (which is >>>>> designed similarly to Exynos SoCs). >>>>> >>>>> The remaining changes provide pinmux support, initial device tree >support. >>>>> >>>>> - Changes since v4 >>>>> * fixed 'make dtbs_check' warnings on patch 14/16 >>>>> >>>>> - Changes since v3 >>>>> * Addressed Stefen's review comments on patch 14/16 >>>>> * Fixed kernel test robot warning on patch 04/16 >>>>> * rebsaed this series on Krzysztof's pinmux new binding schema work >>>>> [1] >>>>> >>>>> - Changes since v2 >>>>> * Addressed Krzysztof's and Stephen's review comments >>>>> * Added Reviewed-by and Acked-by tags >>>>> * Rebased on next-20220120 >>>>> >>>>> - Changes since v1 >>>>> * fixed make dt_binding_check error as pointed by Rob >>>>> * Addressed Krzysztof's and Rob's review comments >>>>> * Added Reviewed-by and Acked-by tags >>>>> * Dropped SPI, MCT and ADC from this series (to be posted in small >>>>> sets) >>>>> >>>>> NOTE: These patches are based on Krzysztof's pinmux for-next branch >>>>> commit 832ae134ccc1 ("pinctrl: samsung: add support for Exynos850 >>>>> and >>>>> ExynosAutov9 wake-ups") [1] >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/pinctrl/samsung.git >>>>> /l >>>>> og/?h=for-next >>>>> >>>>> >>>> >>>> Thanks, applied DTS/soc and pinctrl patches. >>>> >>>> I expect Sylwester will pick up the clock ones. Otherwise please let >>>> me know to pick it up as well. >>> >>> I forgot that clock macros are used in DTS. This does not compile and >>> I cannot take drivers into DTS branch. >>> >>> Alim, >>> DTS changes dropped. Please resend with the same trick we did for >>> Exynos850 board - hard-coded clock IDs as defines. See: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/diff/a >>> rch/arm6 >>> 4/boot/dts/exynos/exynos850.dtsi?h=samsung-dt64-5.17- >>> 2&id=e3493220fd3e474abcdcefbe14fb60485097ce06 >>> >> Ok, I will resend patch 14 and 15 (DTS changes) only as suggested above. > >I see Sylwester acked clock patches, so I will take them. No need to resend, I'll >organize the patches so they will compile. > Awesome, thanks Krzysztof and Sylwester > >Best regards, >Krzysztof