| Message ID | 20220126132116.11070-1-zajec5@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | dt-bindings: watchdog: brcm, bcm7038: add more compatible strings | expand |
On Wed, 26 Jan 2022 14:21:16 +0100, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > This hardware block is used on almost all BCM63xx family chipsets and > BCM4908 which reuses a lot of BCM63xx parts. Add relevant compatible > strings and also include a generic one. > > The only SoC with a different block I found is BCM6838 (thus not included > in this change). > > It may be worth noting that BCM6338, BCM6345, BCM6348 and BCM63268 don't > include "SoftRst" register but that can be handled by drivers based on > precise compatible string. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > .../bindings/watchdog/brcm,bcm7038-wdt.yaml | 21 +++++++++++++++---- > 1 file changed, 17 insertions(+), 4 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/brcm,twd.example.dt.yaml: timer-mfd@ff800400: watchdog@28:compatible: ['brcm,bcm7038-wdt'] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/brcm,twd.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/brcm,twd.example.dt.yaml: watchdog@28: compatible: ['brcm,bcm7038-wdt'] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1584464 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml index a926809352b8..b663f360f571 100644 --- a/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm7038-wdt.yaml @@ -16,9 +16,22 @@ maintainers: properties: compatible: - enum: - - brcm,bcm6345-wdt - - brcm,bcm7038-wdt + items: + - enum: + - brcm,bcm4908-wdt + - brcm,bcm60333-wdt + - brcm,bcm63138-wdt + - brcm,bcm63148-wdt + - brcm,bcm63268-wdt + - brcm,bcm63381-wdt + - brcm,bcm6848-wdt + - brcm,bcm6858-wdt + - brcm,bcm68360-wdt + - brcm,bcm6338-wdt + - brcm,bcm6345-wdt + - brcm,bcm6348-wdt + - brcm,bcm7038-wdt + - const: brcm,bcm63xx-wdt reg: maxItems: 1 @@ -37,7 +50,7 @@ required: examples: - | watchdog@f040a7e8 { - compatible = "brcm,bcm7038-wdt"; + compatible = "brcm,bcm7038-wdt", "brcm,bcm63xx-wdt"; reg = <0xf040a7e8 0x16>; clocks = <&upg_fixed>; };