| Message ID | 20220107025050.787720-1-wanjiabing@vivo.com |
|---|---|
| State | Accepted |
| Commit | 72319cb14d0f8f282e52b3cc1bbeb96251a8a098 |
| Headers | show |
| Series | phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy | expand |
On Fri, 2022-01-07 at 10:50 +0800, Wan Jiabing wrote: > Fix following coccicheck warning: > ./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument > to && or || > > The efuse_rx_imp is duplicate. Here should be efuse_tx_imp. > > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> > --- > drivers/phy/mediatek/phy-mtk-tphy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c > b/drivers/phy/mediatek/phy-mtk-tphy.c > index 6d307102f4f6..8ee7682b8e93 100644 > --- a/drivers/phy/mediatek/phy-mtk-tphy.c > +++ b/drivers/phy/mediatek/phy-mtk-tphy.c > @@ -992,7 +992,7 @@ static int phy_efuse_get(struct mtk_tphy *tphy, > struct mtk_phy_instance *instanc > /* no efuse, ignore it */ > if (!instance->efuse_intr && > !instance->efuse_rx_imp && > - !instance->efuse_rx_imp) { > + !instance->efuse_tx_imp) { > dev_warn(dev, "no u3 intr efuse, but dts enable > it\n"); > instance->efuse_sw_en = 0; > break; Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Thanks a lot
On 07-01-22, 10:50, Wan Jiabing wrote: > Fix following coccicheck warning: > ./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument > to && or || > > The efuse_rx_imp is duplicate. Here should be efuse_tx_imp. Applied, thanks
diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c index 6d307102f4f6..8ee7682b8e93 100644 --- a/drivers/phy/mediatek/phy-mtk-tphy.c +++ b/drivers/phy/mediatek/phy-mtk-tphy.c @@ -992,7 +992,7 @@ static int phy_efuse_get(struct mtk_tphy *tphy, struct mtk_phy_instance *instanc /* no efuse, ignore it */ if (!instance->efuse_intr && !instance->efuse_rx_imp && - !instance->efuse_rx_imp) { + !instance->efuse_tx_imp) { dev_warn(dev, "no u3 intr efuse, but dts enable it\n"); instance->efuse_sw_en = 0; break;
Fix following coccicheck warning: ./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument to && or || The efuse_rx_imp is duplicate. Here should be efuse_tx_imp. Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> --- drivers/phy/mediatek/phy-mtk-tphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)