| Message ID | YfKPSvnFKOaLr74+@anyang (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: meson-sm1: fix wrong GPIO domain for GPIOE_2 | expand |
Hi, On 27/01/2022 13:25, Dongjin Kim wrote: > GPIOE_2 is in AO domain and "<&gpio GPIOE_2 ...>" changes the state of > GPIOZ_14 connected to INTR of 'RTL8211F' on ODROID-HC and TF_PWR_EN of > 'FC8731' on BPI-M5 > > Fixes: 1f80a5cf74a6 ("arm64: dts: meson-sm1-odroid: add missing enable gpio and supply for tf_io regulator") > Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts") > > Signed-off-by: Dongjin Kim <tobetter@gmail.com> > --- > arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +- > arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > index 212c6aa5a3b8..5751c48620ed 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > @@ -123,7 +123,7 @@ vddio_c: regulator-vddio_c { > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > > - enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>; > + enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>; > enable-active-high; > regulator-always-on; > > diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi > index bf29afac645f..d4349b355e4a 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi > @@ -52,7 +52,7 @@ tf_io: gpio-regulator-tf_io { > regulator-max-microvolt = <3300000>; > vin-supply = <&vcc_5v>; > > - enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>; > + enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>; > enable-active-high; > regulator-always-on; > > Thanks for the fixes, can you send 2 patches fixing each files instead ? Thanks, Neil
On Thu, Jan 27, 2022 at 02:00:11PM +0100, Neil Armstrong wrote: > Hi, > > On 27/01/2022 13:25, Dongjin Kim wrote: > > GPIOE_2 is in AO domain and "<&gpio GPIOE_2 ...>" changes the state of > > GPIOZ_14 connected to INTR of 'RTL8211F' on ODROID-HC and TF_PWR_EN of > > 'FC8731' on BPI-M5 > > > > Fixes: 1f80a5cf74a6 ("arm64: dts: meson-sm1-odroid: add missing enable gpio and supply for tf_io regulator") > > Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts") > > > > Signed-off-by: Dongjin Kim <tobetter@gmail.com> > > --- > > arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +- > > arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > > index 212c6aa5a3b8..5751c48620ed 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > > @@ -123,7 +123,7 @@ vddio_c: regulator-vddio_c { > > regulator-min-microvolt = <1800000>; > > regulator-max-microvolt = <3300000>; > > > > - enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>; > > + enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>; > > enable-active-high; > > regulator-always-on; > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi > > index bf29afac645f..d4349b355e4a 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi > > +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi > > @@ -52,7 +52,7 @@ tf_io: gpio-regulator-tf_io { > > regulator-max-microvolt = <3300000>; > > vin-supply = <&vcc_5v>; > > > > - enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>; > > + enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>; > > enable-active-high; > > regulator-always-on; > > > > > Thanks for the fixes, > can you send 2 patches fixing each files instead ? > > Thanks, > Neil Sure. By the way, I would drop a fix for 'meson-sm1-odroid.dtsi' since I found a patch just now. https://patchwork.kernel.org/project/linux-amlogic/patch/20220127130537.GA187347@odroid-VirtualBox/ Thanks, Dongjin.
Hi, On 27/01/2022 15:53, Dongjin Kim wrote: > On Thu, Jan 27, 2022 at 02:00:11PM +0100, Neil Armstrong wrote: >> Hi, >> >> On 27/01/2022 13:25, Dongjin Kim wrote: >>> GPIOE_2 is in AO domain and "<&gpio GPIOE_2 ...>" changes the state of >>> GPIOZ_14 connected to INTR of 'RTL8211F' on ODROID-HC and TF_PWR_EN of >>> 'FC8731' on BPI-M5 >>> >>> Fixes: 1f80a5cf74a6 ("arm64: dts: meson-sm1-odroid: add missing enable gpio and supply for tf_io regulator") >>> Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts") >>> >>> Signed-off-by: Dongjin Kim <tobetter@gmail.com> >>> --- >>> arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +- >>> arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts >>> index 212c6aa5a3b8..5751c48620ed 100644 >>> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts >>> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts >>> @@ -123,7 +123,7 @@ vddio_c: regulator-vddio_c { >>> regulator-min-microvolt = <1800000>; >>> regulator-max-microvolt = <3300000>; >>> >>> - enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>; >>> + enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>; >>> enable-active-high; >>> regulator-always-on; >>> >>> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi >>> index bf29afac645f..d4349b355e4a 100644 >>> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi >>> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi >>> @@ -52,7 +52,7 @@ tf_io: gpio-regulator-tf_io { >>> regulator-max-microvolt = <3300000>; >>> vin-supply = <&vcc_5v>; >>> >>> - enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>; >>> + enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>; >>> enable-active-high; >>> regulator-always-on; >>> >>> >> Thanks for the fixes, >> can you send 2 patches fixing each files instead ? >> >> Thanks, >> Neil > > Sure. > By the way, I would drop a fix for 'meson-sm1-odroid.dtsi' since I found a > patch just now. > https://patchwork.kernel.org/project/linux-amlogic/patch/20220127130537.GA187347@odroid-VirtualBox/ Sure, you sent the v1 at the same time, and he just resend a new version. Neil > > Thanks, > Dongjin. >
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts index 212c6aa5a3b8..5751c48620ed 100644 --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts @@ -123,7 +123,7 @@ vddio_c: regulator-vddio_c { regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; - enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>; + enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>; enable-active-high; regulator-always-on; diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi index bf29afac645f..d4349b355e4a 100644 --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi @@ -52,7 +52,7 @@ tf_io: gpio-regulator-tf_io { regulator-max-microvolt = <3300000>; vin-supply = <&vcc_5v>; - enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>; + enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>; enable-active-high; regulator-always-on;
GPIOE_2 is in AO domain and "<&gpio GPIOE_2 ...>" changes the state of GPIOZ_14 connected to INTR of 'RTL8211F' on ODROID-HC and TF_PWR_EN of 'FC8731' on BPI-M5 Fixes: 1f80a5cf74a6 ("arm64: dts: meson-sm1-odroid: add missing enable gpio and supply for tf_io regulator") Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts") Signed-off-by: Dongjin Kim <tobetter@gmail.com> --- arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +- arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)