| Message ID | 20220126160544.1179489-1-tobias@waldekranz.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net/fsl: xgmac_mdio: Preamble suppression and custom MDC frequencies | expand |
Hello: This series was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Wed, 26 Jan 2022 17:05:38 +0100 you wrote: > The first patch removes the docs for a binding that has never been > supported by the driver as far as I can see. This is a bit of a > mystery to me, maybe Freescale/NXP had/has support for it in an > internal version? > > We then start working on the xgmac_mdio driver, converting the driver > to exclusively use managed resources, thereby simplifying the error > paths. Suggested by Andrew. > > [...] Here is the summary with links: - [v2,net-next,1/5] dt-bindings: net: xgmac_mdio: Remove unsupported "bus-frequency" https://git.kernel.org/netdev/net-next/c/15ca0518c1b3 - [v2,net-next,2/5] net/fsl: xgmac_mdio: Use managed device resources https://git.kernel.org/netdev/net-next/c/1d14eb15dc2c - [v2,net-next,3/5] net/fsl: xgmac_mdio: Support preamble suppression https://git.kernel.org/netdev/net-next/c/909bea73485f - [v2,net-next,4/5] net/fsl: xgmac_mdio: Support setting the MDC frequency https://git.kernel.org/netdev/net-next/c/dd8f467eda72 - [v2,net-next,5/5] dt-bindings: net: xgmac_mdio: Add "clock-frequency" and "suppress-preamble" https://git.kernel.org/netdev/net-next/c/f7af8fe85aac You are awesome, thank you!
The first patch removes the docs for a binding that has never been supported by the driver as far as I can see. This is a bit of a mystery to me, maybe Freescale/NXP had/has support for it in an internal version? We then start working on the xgmac_mdio driver, converting the driver to exclusively use managed resources, thereby simplifying the error paths. Suggested by Andrew. Preamble suppression is then added, followed by MDC frequency customization. Neither code will change any bits if the corresponding dt properties are not specified, so as to not trample on any setup done by the bootloader, which boards might have relied on up to now. Finally, we document the new bindings. Tested on a T1023 based board. v1 -> v2: - Whitespace (Andrew) - Fail the probe if a custom frequency has been set, but can not be applied. I.e. the input clock is missing or the frequency is out of range (Andrew) Tobias Waldekranz (5): dt-bindings: net: xgmac_mdio: Remove unsupported "bus-frequency" net/fsl: xgmac_mdio: Use managed device resources net/fsl: xgmac_mdio: Support preamble suppression net/fsl: xgmac_mdio: Support setting the MDC frequency dt-bindings: net: xgmac_mdio: Add "clock-frequency" and "suppress-preamble" .../devicetree/bindings/net/fsl-fman.txt | 22 +++-- drivers/net/ethernet/freescale/xgmac_mdio.c | 91 +++++++++++++------ 2 files changed, 77 insertions(+), 36 deletions(-)