diff mbox series

[v2] dt-bindings: PCI: ti,j721e: Add device id for J721S2

Message ID 20211130035608.13492-1-a-govindraju@ti.com (mailing list archive)
State New, archived
Delegated to: Rob Herring
Headers show
Series [v2] dt-bindings: PCI: ti,j721e: Add device id for J721S2 | expand

Commit Message

Aswath Govindraju Nov. 30, 2021, 3:56 a.m. UTC
Document the device id of J721S2 SoC.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---

changes since v1:
- changed (oneOf, items) into enum

 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml   | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

Comments

Rob Herring (Arm) Dec. 7, 2021, 9:14 p.m. UTC | #1
On Tue, 30 Nov 2021 09:26:07 +0530, Aswath Govindraju wrote:
> Document the device id of J721S2 SoC.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
> 
> changes since v1:
> - changed (oneOf, items) into enum
> 
>  .../devicetree/bindings/pci/ti,j721e-pci-host.yaml   | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Aswath Govindraju Jan. 25, 2022, 6:36 a.m. UTC | #2
Hi Bjorn,

On 30/11/21 9:26 am, Aswath Govindraju wrote:
> Document the device id of J721S2 SoC.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
> 

May I know if this patch can be picked up?

Thanks,
Aswath

> changes since v1:
> - changed (oneOf, items) into enum
> 
>  .../devicetree/bindings/pci/ti,j721e-pci-host.yaml   | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index cc900202df29..41df8f1c2d4c 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -64,13 +64,11 @@ properties:
>      const: 0x104c
>  
>    device-id:
> -    oneOf:
> -      - items:
> -          - const: 0xb00d
> -      - items:
> -          - const: 0xb00f
> -      - items:
> -          - const: 0xb010
> +    enum:
> +      - 0xb00d
> +      - 0xb00f
> +      - 0xb010
> +      - 0xb013
>  
>    msi-map: true
>  
>
Bjorn Helgaas Jan. 27, 2022, 3:23 p.m. UTC | #3
[+cc Lorenzo, initial post
https://lore.kernel.org/r/20211130035608.13492-1-a-govindraju@ti.com]

On Tue, Jan 25, 2022 at 12:06:16PM +0530, Aswath Govindraju wrote:
> On 30/11/21 9:26 am, Aswath Govindraju wrote:
> > Document the device id of J721S2 SoC.
> > 
> > Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> > ---
> > 
> 
> May I know if this patch can be picked up?

"git log Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml"
says most changes to this file have been applied by Lorenzo, so I cc'd
him.

> > changes since v1:
> > - changed (oneOf, items) into enum
> > 
> >  .../devicetree/bindings/pci/ti,j721e-pci-host.yaml   | 12 +++++-------
> >  1 file changed, 5 insertions(+), 7 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> > index cc900202df29..41df8f1c2d4c 100644
> > --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> > +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> > @@ -64,13 +64,11 @@ properties:
> >      const: 0x104c
> >  
> >    device-id:
> > -    oneOf:
> > -      - items:
> > -          - const: 0xb00d
> > -      - items:
> > -          - const: 0xb00f
> > -      - items:
> > -          - const: 0xb010
> > +    enum:
> > +      - 0xb00d
> > +      - 0xb00f
> > +      - 0xb010
> > +      - 0xb013
> >    msi-map: true
> >  
> > 
>
Rob Herring Jan. 27, 2022, 6:25 p.m. UTC | #4
On Thu, Jan 27, 2022 at 9:24 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> [+cc Lorenzo, initial post
> https://lore.kernel.org/r/20211130035608.13492-1-a-govindraju@ti.com]
>
> On Tue, Jan 25, 2022 at 12:06:16PM +0530, Aswath Govindraju wrote:
> > On 30/11/21 9:26 am, Aswath Govindraju wrote:
> > > Document the device id of J721S2 SoC.
> > >
> > > Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> > > ---
> > >
> >
> > May I know if this patch can be picked up?
>
> "git log Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml"
> says most changes to this file have been applied by Lorenzo, so I cc'd
> him.

I can take it if there's not other pending changes to this file for 5.18?

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index cc900202df29..41df8f1c2d4c 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -64,13 +64,11 @@  properties:
     const: 0x104c
 
   device-id:
-    oneOf:
-      - items:
-          - const: 0xb00d
-      - items:
-          - const: 0xb00f
-      - items:
-          - const: 0xb010
+    enum:
+      - 0xb00d
+      - 0xb00f
+      - 0xb010
+      - 0xb013
 
   msi-map: true