| Message ID | 20211220134311.683553-1-thierry.reding@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: dts: imx28: Use correct compatible string for RTC | expand |
[Adding Lothar on Cc] On Mon, Dec 20, 2021 at 10:43 AM Thierry Reding <thierry.reding@gmail.com> wrote: > > From: Thierry Reding <treding@nvidia.com> > > The "mxim" vendor prefix does not exit, though it looks like it might > have been a typo'ed "maxim". Still, no compatible string exists that > matches "maxim,ds1339". The closest is the "dallas,ds1339" and since > this node is named "rtc" that's probably the one that was intended. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > arch/arm/boot/dts/imx28-tx28.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts > index 164254c28f8e..a1fd508ee425 100644 > --- a/arch/arm/boot/dts/imx28-tx28.dts > +++ b/arch/arm/boot/dts/imx28-tx28.dts > @@ -356,7 +356,7 @@ touchscreen: tsc2007@48 { > }; > > ds1339: rtc@68 { > - compatible = "mxim,ds1339"; > + compatible = "dallas,ds1339"; Reviewed-by: Fabio Estevam <festevam@gmail.com>
Fabio Estevam <festevam@gmail.com> wrote: > [Adding Lothar on Cc] > > On Mon, Dec 20, 2021 at 10:43 AM Thierry Reding > <thierry.reding@gmail.com> wrote: > > > > From: Thierry Reding <treding@nvidia.com> > > > > The "mxim" vendor prefix does not exit, though it looks like it might > > have been a typo'ed "maxim". Still, no compatible string exists that > > matches "maxim,ds1339". The closest is the "dallas,ds1339" and since > > this node is named "rtc" that's probably the one that was intended. > > > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > --- > > arch/arm/boot/dts/imx28-tx28.dts | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts > > index 164254c28f8e..a1fd508ee425 100644 > > --- a/arch/arm/boot/dts/imx28-tx28.dts > > +++ b/arch/arm/boot/dts/imx28-tx28.dts > > @@ -356,7 +356,7 @@ touchscreen: tsc2007@48 { > > }; > > > > ds1339: rtc@68 { > > - compatible = "mxim,ds1339"; > > + compatible = "dallas,ds1339"; > > Reviewed-by: Fabio Estevam <festevam@gmail.com> Acked-by: Lothar Waßmann <LW@KARO-electronics.de>
On Mon, Dec 20, 2021 at 02:43:10PM +0100, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > The "mxim" vendor prefix does not exit, though it looks like it might > have been a typo'ed "maxim". Still, no compatible string exists that > matches "maxim,ds1339". The closest is the "dallas,ds1339" and since > this node is named "rtc" that's probably the one that was intended. > > Signed-off-by: Thierry Reding <treding@nvidia.com> Applied both, thanks!
diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts index 164254c28f8e..a1fd508ee425 100644 --- a/arch/arm/boot/dts/imx28-tx28.dts +++ b/arch/arm/boot/dts/imx28-tx28.dts @@ -356,7 +356,7 @@ touchscreen: tsc2007@48 { }; ds1339: rtc@68 { - compatible = "mxim,ds1339"; + compatible = "dallas,ds1339"; reg = <0x68>; trickle-resistor-ohms = <250>; trickle-diode-disable;