mbox series

[v2,0/4] Exynos4 media drivers: adapt for the planned ARM IOMMU-DMA changes

Message ID 20200918144833.14618-1-m.szyprowski@samsung.com (mailing list archive)
Headers show
Series Exynos4 media drivers: adapt for the planned ARM IOMMU-DMA changes | expand

Message

Marek Szyprowski Sept. 18, 2020, 2:48 p.m. UTC
Hi,

This patchset updates Exynos4-IS and S5P-MFC drivers for the planned
kernel changes in the area of ARM DMA-mapping and IOMMU integration [1].
Those patches are intedependent, they can be applied separately from the
ARM DMA-mapping changes.

Best regards,
Marek Szyprowski


References:

[1] https://lore.kernel.org/lkml/cover.1597931875.git.robin.murphy@arm.com/


Changelog:

v2:
- added patch for S5P-MFC driver
- simplified code for Exynos4-IS (use the iommu_get_domain_for_dev()
  instead of creating a separate domain)

v1: https://lore.kernel.org/linux-samsung-soc/20200915133256.1210-1-m.szyprowski@samsung.com/T/#t
- initial version (only Exynos4-IS patch)

Patch summary:

Marek Szyprowski (4):
  media: platform: exynos4-is: remove all references to physicall
    addresses
  media: platform: exynos4-is: add support for generic IOMMU-DMA glue
    code
  media: platform: s5p-mfc: properly assign device to both vb2 queues
  media: platform: s5p-mfc: add support for generic DMA-IOMMU glue code

 .../media/platform/exynos4-is/fimc-capture.c  |  6 +-
 drivers/media/platform/exynos4-is/fimc-core.c | 28 ++++----
 drivers/media/platform/exynos4-is/fimc-core.h | 18 ++---
 drivers/media/platform/exynos4-is/fimc-is.c   | 72 +++++++++++++++----
 drivers/media/platform/exynos4-is/fimc-is.h   |  8 ++-
 .../media/platform/exynos4-is/fimc-lite-reg.c |  4 +-
 drivers/media/platform/exynos4-is/fimc-lite.c |  2 +-
 drivers/media/platform/exynos4-is/fimc-lite.h |  4 +-
 drivers/media/platform/exynos4-is/fimc-m2m.c  |  8 +--
 drivers/media/platform/exynos4-is/fimc-reg.c  | 18 ++---
 drivers/media/platform/exynos4-is/fimc-reg.h  |  4 +-
 drivers/media/platform/s5p-mfc/s5p_mfc.c      | 37 +++++++++-
 .../media/platform/s5p-mfc/s5p_mfc_common.h   |  2 +
 13 files changed, 148 insertions(+), 63 deletions(-)

Comments

Hans Verkuil Jan. 28, 2022, 10:07 a.m. UTC | #1
Hi Marek,

I'm going through a bunch of (very) old patches in my patchwork TODO list
that for one reason or another I never processed. This series is one of them.
Patch 1/4 has been accepted, but not the other three.

Patches 2-4 still apply without problems, so is it OK if I apply them?
Better late than never...

Regards,

	Hans

On 18/09/2020 16:48, Marek Szyprowski wrote:
> Hi,
> 
> This patchset updates Exynos4-IS and S5P-MFC drivers for the planned
> kernel changes in the area of ARM DMA-mapping and IOMMU integration [1].
> Those patches are intedependent, they can be applied separately from the
> ARM DMA-mapping changes.
> 
> Best regards,
> Marek Szyprowski
> 
> 
> References:
> 
> [1] https://lore.kernel.org/lkml/cover.1597931875.git.robin.murphy@arm.com/
> 
> 
> Changelog:
> 
> v2:
> - added patch for S5P-MFC driver
> - simplified code for Exynos4-IS (use the iommu_get_domain_for_dev()
>   instead of creating a separate domain)
> 
> v1: https://lore.kernel.org/linux-samsung-soc/20200915133256.1210-1-m.szyprowski@samsung.com/T/#t
> - initial version (only Exynos4-IS patch)
> 
> Patch summary:
> 
> Marek Szyprowski (4):
>   media: platform: exynos4-is: remove all references to physicall
>     addresses
>   media: platform: exynos4-is: add support for generic IOMMU-DMA glue
>     code
>   media: platform: s5p-mfc: properly assign device to both vb2 queues
>   media: platform: s5p-mfc: add support for generic DMA-IOMMU glue code
> 
>  .../media/platform/exynos4-is/fimc-capture.c  |  6 +-
>  drivers/media/platform/exynos4-is/fimc-core.c | 28 ++++----
>  drivers/media/platform/exynos4-is/fimc-core.h | 18 ++---
>  drivers/media/platform/exynos4-is/fimc-is.c   | 72 +++++++++++++++----
>  drivers/media/platform/exynos4-is/fimc-is.h   |  8 ++-
>  .../media/platform/exynos4-is/fimc-lite-reg.c |  4 +-
>  drivers/media/platform/exynos4-is/fimc-lite.c |  2 +-
>  drivers/media/platform/exynos4-is/fimc-lite.h |  4 +-
>  drivers/media/platform/exynos4-is/fimc-m2m.c  |  8 +--
>  drivers/media/platform/exynos4-is/fimc-reg.c  | 18 ++---
>  drivers/media/platform/exynos4-is/fimc-reg.h  |  4 +-
>  drivers/media/platform/s5p-mfc/s5p_mfc.c      | 37 +++++++++-
>  .../media/platform/s5p-mfc/s5p_mfc_common.h   |  2 +
>  13 files changed, 148 insertions(+), 63 deletions(-)
>
Marek Szyprowski Feb. 2, 2022, 11:06 p.m. UTC | #2
On 28.01.2022 11:07, Hans Verkuil wrote:
> Hi Marek,
>
> I'm going through a bunch of (very) old patches in my patchwork TODO list
> that for one reason or another I never processed. This series is one of them.
> Patch 1/4 has been accepted, but not the other three.
>
> Patches 2-4 still apply without problems, so is it OK if I apply them?
> Better late than never...

Well, there is no hurry ;) Patches which switch ARM 32bit architecture 
to DMA-IOMMU framework still didn't reach mainline, so this patchset is 
not really needed yet. I will check them soon (there have been some 
changes in the IOMMU framework last year) and resend also with some 
typos fixed.

Best regards
Hans Verkuil Feb. 8, 2022, 10:39 a.m. UTC | #3
Hi Marek,

On 2/3/22 00:06, Marek Szyprowski wrote:
> On 28.01.2022 11:07, Hans Verkuil wrote:
>> Hi Marek,
>>
>> I'm going through a bunch of (very) old patches in my patchwork TODO list
>> that for one reason or another I never processed. This series is one of them.
>> Patch 1/4 has been accepted, but not the other three.
>>
>> Patches 2-4 still apply without problems, so is it OK if I apply them?
>> Better late than never...
> 
> Well, there is no hurry ;) Patches which switch ARM 32bit architecture 
> to DMA-IOMMU framework still didn't reach mainline, so this patchset is 
> not really needed yet. I will check them soon (there have been some 
> changes in the IOMMU framework last year) and resend also with some 
> typos fixed.

Thank you for the status update. I've marked this series as
'Obsoleted' in patchwork, that way it's out of my queue of pending patches :-)

Regards,

	Hans