| Message ID | 20220129220221.2823127-2-colin.foster@in-advantage.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | add support for VSC7512 control over SPI | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 2 this patch: 2 |
| netdev/cc_maintainers | success | CCed 2 of 2 maintainers |
| netdev/build_clang | success | Errors and warnings before: 18 this patch: 18 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 7 this patch: 7 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 21 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Sat, Jan 29, 2022 at 11:02 PM Colin Foster <colin.foster@in-advantage.com> wrote: > Work is being done to allow external control of Ocelot chips. When pinctrl > drivers are used internally, it wouldn't make much sense to allow them to > be loaded as modules. In the case where the Ocelot chip is controlled > externally, this scenario becomes practical. > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> This is fine to merge through the netdev tree, if you prefer I merge patches 1 & 2 to the pinctrl tree just tell me. Yours, Linus Walleij
On Sun, Jan 30, 2022 at 01:30:57AM +0100, Linus Walleij wrote: > On Sat, Jan 29, 2022 at 11:02 PM Colin Foster > <colin.foster@in-advantage.com> wrote: > > > Work is being done to allow external control of Ocelot chips. When pinctrl > > drivers are used internally, it wouldn't make much sense to allow them to > > be loaded as modules. In the case where the Ocelot chip is controlled > > externally, this scenario becomes practical. > > > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > This is fine to merge through the netdev tree, if you prefer I merge patches > 1 & 2 to the pinctrl tree just tell me. I'd thought about splitting these out, but they really don't make much sense to be anywhere until the MFD is added in. The big one I needed in pinctrl was the regmap conversions that are in 5.17-rc1, so I'm hopeful I won't need to bounce back and forth much moving forward. Thanks for reviewing! > > Yours, > Linus Walleij
On 1/29/2022 2:02 PM, Colin Foster wrote: > Work is being done to allow external control of Ocelot chips. When pinctrl > drivers are used internally, it wouldn't make much sense to allow them to > be loaded as modules. In the case where the Ocelot chip is controlled > externally, this scenario becomes practical. > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 6fc56d6598e2..1b367f423ceb 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -311,7 +311,7 @@ config PINCTRL_MICROCHIP_SGPIO LED controller. config PINCTRL_OCELOT - bool "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" + tristate "Pinctrl driver for the Microsemi Ocelot and Jaguar2 SoCs" depends on OF depends on HAS_IOMEM select GPIOLIB diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c index fc969208d904..b6ad3ffb4596 100644 --- a/drivers/pinctrl/pinctrl-ocelot.c +++ b/drivers/pinctrl/pinctrl-ocelot.c @@ -1778,6 +1778,7 @@ static const struct of_device_id ocelot_pinctrl_of_match[] = { { .compatible = "microchip,lan966x-pinctrl", .data = &lan966x_desc }, {}, }; +MODULE_DEVICE_TABLE(of, ocelot_pinctrl_of_match); static struct regmap *ocelot_pinctrl_create_pincfg(struct platform_device *pdev) { @@ -1866,3 +1867,6 @@ static struct platform_driver ocelot_pinctrl_driver = { .probe = ocelot_pinctrl_probe, }; builtin_platform_driver(ocelot_pinctrl_driver); + +MODULE_DESCRIPTION("Ocelot Chip Pinctrl Driver"); +MODULE_LICENSE("Dual MIT/GPL");
Work is being done to allow external control of Ocelot chips. When pinctrl drivers are used internally, it wouldn't make much sense to allow them to be loaded as modules. In the case where the Ocelot chip is controlled externally, this scenario becomes practical. Signed-off-by: Colin Foster <colin.foster@in-advantage.com> --- drivers/pinctrl/Kconfig | 2 +- drivers/pinctrl/pinctrl-ocelot.c | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-)