| Message ID | 20220202091933.580713-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] usb: gadget: f_uac2: Fix spelling mistake "maxpctksize" -> "maxpcktsize" | expand |
On Wed, 2022-02-02 at 09:19 +0000, Colin Ian King wrote: > There is a spelling mistake in a deb_dbg message. Fix it. [] > diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c [] > @@ -755,7 +755,7 @@ static int set_ep_max_packet_size_bint(struct device *dev, const struct f_uac2_o > > if (max_size_bw <= max_size_ep) > dev_dbg(dev, > - "%s %s: Would use maxpctksize %d and bInterval %d\n", > + "%s %s: Would use maxpcktsize %d and bInterval %d\n", why not just spell it out? or use wMaxPacketSize from the uapi include? --- drivers/usb/gadget/function/f_uac2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c index f2237bcdba7c0..13b59128121a2 100644 --- a/drivers/usb/gadget/function/f_uac2.c +++ b/drivers/usb/gadget/function/f_uac2.c @@ -755,12 +755,12 @@ static int set_ep_max_packet_size_bint(struct device *dev, const struct f_uac2_o if (max_size_bw <= max_size_ep) dev_dbg(dev, - "%s %s: Would use maxpctksize %d and bInterval %d\n", + "%s %s: Would use wMaxPacketSize %d and bInterval %d\n", speed_names[speed], dir, max_size_bw, bint); else { dev_warn(dev, - "%s %s: Req. maxpcktsize %d at bInterval %d > max ISOC %d, may drop data!\n", - speed_names[speed], dir, max_size_bw, bint, max_size_ep); + "%s %s: Req. wMaxPacketSize %d at bInterval %d > max ISOC %d, may drop data!\n", + speed_names[speed], dir, max_size_bw, bint, max_size_ep); max_size_bw = max_size_ep; }
Dne 02. 02. 22 v 10:57 Joe Perches napsal(a): > On Wed, 2022-02-02 at 09:19 +0000, Colin Ian King wrote: >> There is a spelling mistake in a deb_dbg message. Fix it. > [] >> diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c > [] >> @@ -755,7 +755,7 @@ static int set_ep_max_packet_size_bint(struct device *dev, const struct f_uac2_o >> >> if (max_size_bw <= max_size_ep) >> dev_dbg(dev, >> - "%s %s: Would use maxpctksize %d and bInterval %d\n", >> + "%s %s: Would use maxpcktsize %d and bInterval %d\n", > > why not just spell it out? or use wMaxPacketSize from the uapi include? My reason for the ugly abbreviation (prone to misspelling for which I apologize) was to keep the line length limit. I would be happy to see wMaxPacketSize instead :-) Pavel. > --- > drivers/usb/gadget/function/f_uac2.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c > index f2237bcdba7c0..13b59128121a2 100644 > --- a/drivers/usb/gadget/function/f_uac2.c > +++ b/drivers/usb/gadget/function/f_uac2.c > @@ -755,12 +755,12 @@ static int set_ep_max_packet_size_bint(struct device *dev, const struct f_uac2_o > > if (max_size_bw <= max_size_ep) > dev_dbg(dev, > - "%s %s: Would use maxpctksize %d and bInterval %d\n", > + "%s %s: Would use wMaxPacketSize %d and bInterval %d\n", > speed_names[speed], dir, max_size_bw, bint); > else { > dev_warn(dev, > - "%s %s: Req. maxpcktsize %d at bInterval %d > max ISOC %d, may drop data!\n", > - speed_names[speed], dir, max_size_bw, bint, max_size_ep); > + "%s %s: Req. wMaxPacketSize %d at bInterval %d > max ISOC %d, may drop data!\n", > + speed_names[speed], dir, max_size_bw, bint, max_size_ep); > max_size_bw = max_size_ep; > } > > >
diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c index f2237bcdba7c..c9b8d11f9870 100644 --- a/drivers/usb/gadget/function/f_uac2.c +++ b/drivers/usb/gadget/function/f_uac2.c @@ -755,7 +755,7 @@ static int set_ep_max_packet_size_bint(struct device *dev, const struct f_uac2_o if (max_size_bw <= max_size_ep) dev_dbg(dev, - "%s %s: Would use maxpctksize %d and bInterval %d\n", + "%s %s: Would use maxpcktsize %d and bInterval %d\n", speed_names[speed], dir, max_size_bw, bint); else { dev_warn(dev,
There is a spelling mistake in a deb_dbg message. Fix it. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/usb/gadget/function/f_uac2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)