| Message ID | cover.1643972527.git.pabeni@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | gro: a couple of minor optimization | expand |
On Fri, 2022-02-04 at 12:28 +0100, Paolo Abeni wrote: > This series collects a couple of small optimizations for the GRO engine, > reducing slightly the number of cycles for dev_gro_receive(). > The delta is within noise range in tput tests, but with big TCP coming > every cycle saved from the GRO engine will count - I hope ;) > > v1 -> v2: > - a few cleanup suggested from Alexander(s) > - moved away the more controversial 3rd patch > > Paolo Abeni (2): > net: gro: avoid re-computing truesize twice on recycle > net: gro: minor optimization for dev_gro_receive() > > include/net/gro.h | 52 +++++++++++++++++++++++++---------------------- > net/core/gro.c | 16 ++++----------- > 2 files changed, 32 insertions(+), 36 deletions(-) This is really a v2. Please let me know if you prefer a formal repost. Thanks! Paolo
From: Paolo Abeni <pabeni@redhat.com> Date: Fri, 4 Feb 2022 12:28:35 +0100 > This series collects a couple of small optimizations for the GRO engine, > reducing slightly the number of cycles for dev_gro_receive(). > The delta is within noise range in tput tests, but with big TCP coming > every cycle saved from the GRO engine will count - I hope ;) > > v1 -> v2: > - a few cleanup suggested from Alexander(s) > - moved away the more controversial 3rd patch > > Paolo Abeni (2): > net: gro: avoid re-computing truesize twice on recycle > net: gro: minor optimization for dev_gro_receive() Looks nice to me now, thanks! For the series: Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com> > > include/net/gro.h | 52 +++++++++++++++++++++++++---------------------- > net/core/gro.c | 16 ++++----------- > 2 files changed, 32 insertions(+), 36 deletions(-) > > -- > 2.34.1 Al
On Fri, Feb 4, 2022 at 3:29 AM Paolo Abeni <pabeni@redhat.com> wrote: > > This series collects a couple of small optimizations for the GRO engine, > reducing slightly the number of cycles for dev_gro_receive(). > The delta is within noise range in tput tests, but with big TCP coming > every cycle saved from the GRO engine will count - I hope ;) > > v1 -> v2: > - a few cleanup suggested from Alexander(s) > - moved away the more controversial 3rd patch > > Paolo Abeni (2): > net: gro: avoid re-computing truesize twice on recycle > net: gro: minor optimization for dev_gro_receive() > > include/net/gro.h | 52 +++++++++++++++++++++++++---------------------- > net/core/gro.c | 16 ++++----------- > 2 files changed, 32 insertions(+), 36 deletions(-) This addresses the concern I had. Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
From: Paolo Abeni <pabeni@redhat.com> Date: Fri, 04 Feb 2022 12:34:03 +0100 > On Fri, 2022-02-04 at 12:28 +0100, Paolo Abeni wrote: >> This series collects a couple of small optimizations for the GRO engine, >> reducing slightly the number of cycles for dev_gro_receive(). >> The delta is within noise range in tput tests, but with big TCP coming >> every cycle saved from the GRO engine will count - I hope ;) >> >> v1 -> v2: >> - a few cleanup suggested from Alexander(s) >> - moved away the more controversial 3rd patch >> >> Paolo Abeni (2): >> net: gro: avoid re-computing truesize twice on recycle >> net: gro: minor optimization for dev_gro_receive() >> >> include/net/gro.h | 52 +++++++++++++++++++++++++---------------------- >> net/core/gro.c | 16 ++++----------- >> 2 files changed, 32 insertions(+), 36 deletions(-) > > This is really a v2. Please let me know if you prefer a formal repost. Not necessary. Thank you.
Hello: This series was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 4 Feb 2022 12:28:35 +0100 you wrote: > This series collects a couple of small optimizations for the GRO engine, > reducing slightly the number of cycles for dev_gro_receive(). > The delta is within noise range in tput tests, but with big TCP coming > every cycle saved from the GRO engine will count - I hope ;) > > v1 -> v2: > - a few cleanup suggested from Alexander(s) > - moved away the more controversial 3rd patch > > [...] Here is the summary with links: - [net-next,1/2] net: gro: avoid re-computing truesize twice on recycle https://git.kernel.org/netdev/net-next/c/7881453e4adf - [net-next,2/2] net: gro: minor optimization for dev_gro_receive() https://git.kernel.org/netdev/net-next/c/de5a1f3ce4c8 You are awesome, thank you!