| Message ID | 20220207063249.1833066-3-hch@lst.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages | expand |
On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig <hch@lst.de> wrote: > > __KERNEL__ ifdefs don't make sense outside of include/uapi/. Yes. Reviewed-by: Dan Williams <dan.j.williams@intel.com>
On Mon, Feb 07, 2022 at 07:32:43AM +0100, Christoph Hellwig wrote: > __KERNEL__ ifdefs don't make sense outside of include/uapi/. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > include/linux/mm.h | 4 ---- > 1 file changed, 4 deletions(-) Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Jason
On 2/6/22 10:32 PM, Christoph Hellwig wrote: > __KERNEL__ ifdefs don't make sense outside of include/uapi/. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > include/linux/mm.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 213cc569b19223..7b46174989b086 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3,9 +3,6 @@ > #define _LINUX_MM_H > > #include <linux/errno.h> > - > -#ifdef __KERNEL__ > - > #include <linux/mmdebug.h> > #include <linux/gfp.h> > #include <linux/bug.h> > @@ -3381,5 +3378,4 @@ madvise_set_anon_name(struct mm_struct *mm, unsigned long start, > } > #endif > > -#endif /* __KERNEL__ */ > #endif /* _LINUX_MM_H */ > Looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
On Mon, Feb 7, 2022 at 2:42 PM Christoph Hellwig <hch@lst.de> wrote: > > __KERNEL__ ifdefs don't make sense outside of include/uapi/. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Muchun Song <songmuchun@bytedance.com> Thanks.
diff --git a/include/linux/mm.h b/include/linux/mm.h index 213cc569b19223..7b46174989b086 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -3,9 +3,6 @@ #define _LINUX_MM_H #include <linux/errno.h> - -#ifdef __KERNEL__ - #include <linux/mmdebug.h> #include <linux/gfp.h> #include <linux/bug.h> @@ -3381,5 +3378,4 @@ madvise_set_anon_name(struct mm_struct *mm, unsigned long start, } #endif -#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
__KERNEL__ ifdefs don't make sense outside of include/uapi/. Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/mm.h | 4 ---- 1 file changed, 4 deletions(-)