| Message ID | 20220207112657.18246-1-allen-kh.cheng@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: pwm: mtk-disp: add compatible string for MT8183 SoC | expand |
Hello, On Mon, Feb 07, 2022 at 07:26:57PM +0800, Allen-KH Cheng wrote: > From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > > Add compatible string for MT8183 SoC in device tree binding. > > Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > --- > Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt > index 902b271891ae..691e58b6c223 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt > +++ b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt > @@ -6,6 +6,7 @@ Required properties: > - "mediatek,mt6595-disp-pwm": found on mt6595 SoC. > - "mediatek,mt8167-disp-pwm", "mediatek,mt8173-disp-pwm": found on mt8167 SoC. > - "mediatek,mt8173-disp-pwm": found on mt8173 SoC. > + - "mediatek,mt8183-disp-pwm": found on mt8183 SoC.$ The patch looks good in principle. I'd like to see the .txt file converted to .yaml though. Would you care for that please? Also it would be good if you'd care that sender email address and author address match. Best regards Uwe
Hi Uwe Kleine-König, Thank you for your suggestions. We will send another patch for .yaml format. About the last reminder, sorry, I don’t get that. Do you mean upper/lower case letters in an email address? Best regards Allen On Mon, 2022-02-07 at 13:51 +0100, Uwe Kleine-König wrote: > Hello, > > On Mon, Feb 07, 2022 at 07:26:57PM +0800, Allen-KH Cheng wrote: > > From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > > > > Add compatible string for MT8183 SoC in device tree binding. > > > > Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > > --- > > Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt > > b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt > > index 902b271891ae..691e58b6c223 100644 > > --- a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt > > +++ b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt > > @@ -6,6 +6,7 @@ Required properties: > > - "mediatek,mt6595-disp-pwm": found on mt6595 SoC. > > - "mediatek,mt8167-disp-pwm", "mediatek,mt8173-disp-pwm": found > > on mt8167 SoC. > > - "mediatek,mt8173-disp-pwm": found on mt8173 SoC. > > + - "mediatek,mt8183-disp-pwm": found on mt8183 SoC.$ > > The patch looks good in principle. I'd like to see the .txt file > converted to .yaml though. Would you care for that please? > > Also it would be good if you'd care that sender email address and > author > address match. > > Best regards > Uwe >
Hello, On Tue, Feb 08, 2022 at 12:28:23PM +0800, allen-kh.cheng wrote: > Thank you for your suggestions. > We will send another patch for .yaml format. > > About the last reminder, sorry, I don’t get that. > Do you mean upper/lower case letters in an email address? exactly. I don't know how picky Thierry (who is responsible to pick up this patch or not) is, but a 100% match is the safe bet. Best regards Uwe
On Mon, 07 Feb 2022 19:26:57 +0800, Allen-KH Cheng wrote: > From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > > Add compatible string for MT8183 SoC in device tree binding. > > Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > --- > Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, Feb 08, 2022 at 10:10:29AM +0100, Uwe Kleine-König wrote: > Hello, > > On Tue, Feb 08, 2022 at 12:28:23PM +0800, allen-kh.cheng wrote: > > Thank you for your suggestions. > > We will send another patch for .yaml format. > > > > About the last reminder, sorry, I don’t get that. > > Do you mean upper/lower case letters in an email address? > > exactly. I don't know how picky Thierry (who is responsible to pick up > this patch or not) is, but a 100% match is the safe bet. Email isn't generally case sensitive, so I don't care all that much if they case differs. Ultimately the username part of an email address and the domain should match to clarify that both are the same person. There are also circumstances where it can make sense to have sender and author differ, like for example if your corporate email tends to butcher patches. In this case it's fairly obvious that sender and author are the same person, so I've applied this as-is. Thanks, Thierry
diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt index 902b271891ae..691e58b6c223 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt +++ b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt @@ -6,6 +6,7 @@ Required properties: - "mediatek,mt6595-disp-pwm": found on mt6595 SoC. - "mediatek,mt8167-disp-pwm", "mediatek,mt8173-disp-pwm": found on mt8167 SoC. - "mediatek,mt8173-disp-pwm": found on mt8173 SoC. + - "mediatek,mt8183-disp-pwm": found on mt8183 SoC.$ - reg: physical base address and length of the controller's registers. - #pwm-cells: must be 2. See pwm.yaml in this directory for a description of the cell format.