mbox series

[RFC,v2,0/3] Add PCIe enclosure management support

Message ID cover.1643822289.git.stuart.w.hayes@gmail.com
Headers show
Series Add PCIe enclosure management support | expand

Message

stuart hayes Feb. 2, 2022, 5:59 p.m. UTC
This patch set adds support for two PCIe enclosure management methods,
"Native PCIe Enclosure Management" (defined in the PCI Express Base Spec)
and "_DSM Definitions for PCIe SSD Status LED" (defined in the PCI
Firmware Spec). The latter is very similar to the former, but uses a _DSM
interface (which can be provided by firmware) rather than a PCIe
extended capability.  Each provides a way to control up to ten indicator
states (such as locate, fault, etc.)

There are three patches in the set:

(1) Expands the existing enclosure driver to support more
indicators.

(2) Adds an auxiliary driver "pcie_em" that can attach to auxiliary
devices created by the drivers of any devices that can support PCIe
enclosure management (nvme, pcieport, and cxl).  It will register an
enclosure device with one component for each device with an enclosure
management interface.

(3) Modifies the nvme driver to create an auxiliary device to which the
pcie_em driver can attach.

These patches do not modify the cxl or pcieport drivers to add support,
though the driver was designed to make it easy to do so.
---
v2:  fixed compile error related to switch default in enclosure.c
     added documentation of added sysfs attributes
---

Stuart Hayes (3):
  Add support for seven more indicators in enclosure driver
  Add PCIe enclosure management auxiliary driver
  Register auxiliary device for PCIe enclosure management

 .../ABI/testing/sysfs-class-enclosure         |  14 +
 drivers/misc/enclosure.c                      | 191 ++++---
 drivers/nvme/host/pci.c                       |  11 +
 drivers/pci/pcie/Kconfig                      |   8 +
 drivers/pci/pcie/Makefile                     |   1 +
 drivers/pci/pcie/pcie_em.c                    | 473 ++++++++++++++++++
 include/linux/enclosure.h                     |  22 +
 include/linux/pcie_em.h                       |  97 ++++
 include/uapi/linux/pci_regs.h                 |  11 +-
 9 files changed, 749 insertions(+), 79 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-class-enclosure
 create mode 100644 drivers/pci/pcie/pcie_em.c
 create mode 100644 include/linux/pcie_em.h

Comments

Mariusz Tkaczyk Feb. 10, 2022, 11:52 a.m. UTC | #1
On Wed,  2 Feb 2022 11:59:10 -0600
Stuart Hayes <stuart.w.hayes@gmail.com> wrote:

> (3) Modifies the nvme driver to create an auxiliary device to which
> the pcie_em driver can attach.
> 
> These patches do not modify the cxl or pcieport drivers to add
> support, though the driver was designed to make it easy to do so.

Hi Stuart,

I would like to help you with NPEM testing. Currently I have setup with
NPEM enabled in Downstream port. It will require to add support for
pcieport. Could you add it in next version?

I'm also searching for a drive with NPEM to do full validation (when
both Downstream and the SSD are reporting capability). If you can point
me the model, it will be helpful.

Thanks,
Mariusz