[v4,0/3] qapi/ui: change vnc addresses

Message

Vladimir Sementsov-Ogievskiy Feb. 10, 2022, 2:14 p.m. UTC

Hi all!

v4:
01: add Daniel's r-b
02: refactor to add new display-update command instead
03: rebase on 02
    search for free ports, using same range as in tests/qemu-iotests/147
    check connection on ports

Recently our customer requested a possibility to change VNC listen port
dynamically.

Happily in Rhel7-based Qemu we already have this possibility: through
deprecated "change" qmp command.

But since 6.0 "change" qmp command was removed, with recommendation to
use change-vnc-password or blockdev-change-medium instead. Of course,
neither of them allow change VNC listen port.

So, let's reimplement the possibility.

Vladimir Sementsov-Ogievskiy (3):
  ui/vnc: refactor arrays of addresses to SocketAddressList
  qapi/ui: display-update: add possibility to change listen address
  avocado/vnc: add test_change_listen

 docs/about/removed-features.rst |   3 +-
 qapi/ui.json                    |  65 ++++++++++++++
 include/ui/console.h            |   1 +
 monitor/qmp-cmds.c              |  15 ++++
 ui/vnc.c                        | 152 ++++++++++++++++----------------
 tests/avocado/vnc.py            |  63 +++++++++++++
 6 files changed, 220 insertions(+), 79 deletions(-)

Comments

Markus Armbruster Feb. 10, 2022, 3:46 p.m. UTC | #1

I figure there's no real need for more review from me.  But if you'd
like me to review, let me know.

Gerd, should this go through your tree?