| Message ID | 20220130053803.43660-1-samuel@sholland.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] dt-bindings: arm: rockchip: Add Pine64 PineNote board | expand |
On Sat, 29 Jan 2022 23:38:01 -0600, Samuel Holland wrote: > The PineNote is a tablet from Pine64 based on the RK3566 SoC. There are > two existing variants of the board. v1.1 was contained in some early > samples, and v1.2 was sold as the "PineNote Developer Edition". > > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Sat, 29 Jan 2022 23:38:01 -0600, Samuel Holland wrote: > The PineNote is a tablet from Pine64 based on the RK3566 SoC. There are > two existing variants of the board. v1.1 was contained in some early > samples, and v1.2 was sold as the "PineNote Developer Edition". Applied, thanks! [1/3] dt-bindings: arm: rockchip: Add Pine64 PineNote board commit: a7c9013216f399791ca354cc2e0f4a444837fe39 [2/3] arm64: dts: rockchip: rk356x: Add pdm node commit: 79c5f0e52d29a688a951fc818394b529e7e77e3e -> change ordering for pinctrl properties, as suggested by Michael [3/3] arm64: dts: rockchip: Add Pine64 PineNote board commit: d449121e5e8addcee654250cec298c887ecafb32 -> folded in Johan's review comments Though mmc0 can stay at sdhci. I don't think we _need_ aliases for all, but fixing mmc0 for the internal emmc makes a lot of sense. Best regards,
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 4aed16176434..77fedeae8d2e 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -481,6 +481,14 @@ properties: - const: pine64,pinebook-pro - const: rockchip,rk3399 + - description: Pine64 PineNote + items: + - enum: + - pine64,pinenote-v1.1 + - pine64,pinenote-v1.2 + - const: pine64,pinenote + - const: rockchip,rk3566 + - description: Pine64 Rock64 items: - const: pine64,rock64
The PineNote is a tablet from Pine64 based on the RK3566 SoC. There are two existing variants of the board. v1.1 was contained in some early samples, and v1.2 was sold as the "PineNote Developer Edition". Signed-off-by: Samuel Holland <samuel@sholland.org> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)