diff mbox series

[1/8] ARM: dts: imx6ul: add missing properties for sram

Message ID 20220125135014.3041002-2-alexander.stein@ew.tq-group.com (mailing list archive)
State New, archived
Headers show
Series various imx6ul DT fixes | expand

Commit Message

Alexander Stein Jan. 25, 2022, 1:50 p.m. UTC
All 3 properties are required by sram.yaml. Fixes the dt_binding_check
warning:
sram@900000: '#address-cells' is a required property
sram@900000: '#size-cells' is a required property
sram@900000: 'ranges' is a required property

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm/boot/dts/imx6ul.dtsi | 3 +++
 1 file changed, 3 insertions(+)

Comments

Shawn Guo Feb. 11, 2022, 3:42 a.m. UTC | #1
On Tue, Jan 25, 2022 at 02:50:07PM +0100, Alexander Stein wrote:
> All 3 properties are required by sram.yaml. Fixes the dt_binding_check

I guess it's dtbs_check rather than dt_binding_check?

Shawn

> warning:
> sram@900000: '#address-cells' is a required property
> sram@900000: '#size-cells' is a required property
> sram@900000: 'ranges' is a required property
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm/boot/dts/imx6ul.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index afeec01f6522..1d435a46fc5c 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -149,6 +149,9 @@ soc {
>  		ocram: sram@900000 {
>  			compatible = "mmio-sram";
>  			reg = <0x00900000 0x20000>;
> +			ranges = <0 0x00900000 0x20000>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
>  		};
>  
>  		intc: interrupt-controller@a01000 {
> -- 
> 2.25.1
>
Alexander Stein Feb. 11, 2022, 2:36 p.m. UTC | #2
Hi Shawn,

Am Freitag, 11. Februar 2022, 04:42:20 CET schrieb Shawn Guo:
> On Tue, Jan 25, 2022 at 02:50:07PM +0100, Alexander Stein wrote:
> > All 3 properties are required by sram.yaml. Fixes the dt_binding_check
> 
> I guess it's dtbs_check rather than dt_binding_check?

You are right. Will fix in a v2.

Regards,
Alexander

> > warning:
> > sram@900000: '#address-cells' is a required property
> > sram@900000: '#size-cells' is a required property
> > sram@900000: 'ranges' is a required property
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >  arch/arm/boot/dts/imx6ul.dtsi | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> > index afeec01f6522..1d435a46fc5c 100644
> > --- a/arch/arm/boot/dts/imx6ul.dtsi
> > +++ b/arch/arm/boot/dts/imx6ul.dtsi
> > @@ -149,6 +149,9 @@ soc {
> > 
> >  		ocram: sram@900000 {
> >  		
> >  			compatible = "mmio-sram";
> >  			reg = <0x00900000 0x20000>;
> > 
> > +			ranges = <0 0x00900000 0x20000>;
> > +			#address-cells = <1>;
> > +			#size-cells = <1>;
> > 
> >  		};
> >  		
> >  		intc: interrupt-controller@a01000 {
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
index afeec01f6522..1d435a46fc5c 100644
--- a/arch/arm/boot/dts/imx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul.dtsi
@@ -149,6 +149,9 @@  soc {
 		ocram: sram@900000 {
 			compatible = "mmio-sram";
 			reg = <0x00900000 0x20000>;
+			ranges = <0 0x00900000 0x20000>;
+			#address-cells = <1>;
+			#size-cells = <1>;
 		};
 
 		intc: interrupt-controller@a01000 {