diff mbox series

[5/6] dt-bindings: spi: support mediatek,need_ahb_clk flag

Message ID 20220209111938.16137-6-leilk.liu@mediatek.com (mailing list archive)
State New, archived
Headers show
Series [1/6] dt-bindings: spi: Add compatible for Mediatek IPM IP with single mode | expand

Commit Message

Leilk Liu Feb. 9, 2022, 11:19 a.m. UTC
this patch support mediatek,need_ahb_clk flag.

Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
---
 .../devicetree/bindings/spi/mediatek,spi-mt65xx.yaml         | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Herring Feb. 11, 2022, 4:59 p.m. UTC | #1
On Wed, Feb 09, 2022 at 07:19:37PM +0800, Leilk Liu wrote:
> this patch support mediatek,need_ahb_clk flag.
> 
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> ---
>  .../devicetree/bindings/spi/mediatek,spi-mt65xx.yaml         | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> index 241c0f5880d3..af12c1711182 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
> @@ -71,6 +71,11 @@ properties:
>        specify which pins group(ck/mi/mo/cs) spi controller used.
>        This is an array.
>  
> +  mediatek,need_ahb_clk:

s/_/-/

But really, this should be implied by the compatible string or presence 
of the clock in 'clocks'.

Rob
Leilk Liu Feb. 14, 2022, 1:53 a.m. UTC | #2
On Fri, 2022-02-11 at 10:59 -0600, Rob Herring wrote:
> On Wed, Feb 09, 2022 at 07:19:37PM +0800, Leilk Liu wrote:
> > this patch support mediatek,need_ahb_clk flag.
> > 
> > Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>
> > ---
> >  .../devicetree/bindings/spi/mediatek,spi-mt65xx.yaml         | 5
> > +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > index 241c0f5880d3..af12c1711182 100644
> > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > @@ -71,6 +71,11 @@ properties:
> >        specify which pins group(ck/mi/mo/cs) spi controller used.
> >        This is an array.
> >  
> > +  mediatek,need_ahb_clk:
> 
> s/_/-/
> 
> But really, this should be implied by the compatible string or
> presence 
> of the clock in 'clocks'.
so I can only add "spi-hclk" in clocks' and don't need
"mediatek,need_ahb_clk" again? thanks

> 
> Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
index 241c0f5880d3..af12c1711182 100644
--- a/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
+++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mt65xx.yaml
@@ -71,6 +71,11 @@  properties:
       specify which pins group(ck/mi/mo/cs) spi controller used.
       This is an array.
 
+  mediatek,need_ahb_clk:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      specify IC which need control ahb clock.
+
 required:
   - compatible
   - reg