| Message ID | 20220210224933.379149-20-yury.norov@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | None | expand |
On Thu, Feb 10, 2022 at 02:49:03PM -0800, Yury Norov wrote: > drivers/infiniband/hw/hfi1/affinity.c code calls cpumask_weight() to check > if any bit of a given cpumask is set. We can do it more efficiently with > cpumask_empty() because cpumask_empty() stops traversing the cpumask as > soon as it finds first set bit, while cpumask_weight() counts all bits > unconditionally. > > Signed-off-by: Yury Norov <yury.norov@gmail.com> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > --- > drivers/infiniband/hw/hfi1/affinity.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to the rdma tree Thanks, Jason
diff --git a/drivers/infiniband/hw/hfi1/affinity.c b/drivers/infiniband/hw/hfi1/affinity.c index 706b3b659713..877f8e84a672 100644 --- a/drivers/infiniband/hw/hfi1/affinity.c +++ b/drivers/infiniband/hw/hfi1/affinity.c @@ -666,7 +666,7 @@ int hfi1_dev_affinity_init(struct hfi1_devdata *dd) * engines, use the same CPU cores as general/control * context. */ - if (cpumask_weight(&entry->def_intr.mask) == 0) + if (cpumask_empty(&entry->def_intr.mask)) cpumask_copy(&entry->def_intr.mask, &entry->general_intr_mask); } @@ -686,7 +686,7 @@ int hfi1_dev_affinity_init(struct hfi1_devdata *dd) * vectors, use the same CPU core as the general/control * context. */ - if (cpumask_weight(&entry->comp_vect_mask) == 0) + if (cpumask_empty(&entry->comp_vect_mask)) cpumask_copy(&entry->comp_vect_mask, &entry->general_intr_mask); }