| Message ID | 20211110105922.217895-1-bhupesh.sharma@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Enable Qualcomm Crypto Engine on sm8150 & sm8250 | expand |
On Wed, Nov 10, 2021 at 04:29:00PM +0530, Bhupesh Sharma wrote: > Changes since v4: > ================= > - v4 for sm8250 can be seen here: https://lore.kernel.org/linux-arm-msm/20211013105541.68045-1-bhupesh.sharma@linaro.org/ > - v1 for sm8150 qce enablement can be seen here: https://lore.kernel.org/linux-arm-msm/20211013165823.88123-1-bhupesh.sharma@linaro.org/ > - Merged the sm8150 and sm8250 enablement patches in the same patchset, > as per suggestions from Bjorn. > - Dropped a couple of patches from v4, as these have been picked by > Bjorn already via his tree. > - Addressed review comments from Vladimir, Thara and Rob. > - Collect Reviewed-by from Rob and Thara on some of the patches from the > v4 patchset. > > Changes since v3: > ================= > - v3 can be seen here: https://lore.kernel.org/linux-arm-msm/20210519143700.27392-1-bhupesh.sharma@linaro.org/ > - Dropped a couple of patches from v3, on basis of the review comments: > ~ [PATCH 13/17] crypto: qce: core: Make clocks optional > ~ [PATCH 15/17] crypto: qce: Convert the device found dev_dbg() to dev_info() > - Addressed review comments from Thara, Rob and Stephan Gerhold. > - Collect Reviewed-by from Rob and Thara on some of the patches from the > v3 patchset. > > Changes since v2: > ================= > - v2 can be seen here: https://lore.kernel.org/dmaengine/20210505213731.538612-1-bhupesh.sharma@linaro.org/ > - Drop a couple of patches from v1, which tried to address the defered > probing of qce driver in case bam dma driver is not yet probed. > Replace it instead with a single (simpler) patch [PATCH 16/17]. > - Convert bam dma and qce crypto dt-bindings to YAML. > - Addressed review comments from Thara, Bjorn, Vinod and Rob. > > Changes since v1: > ================= > - v1 can be seen here: https://lore.kernel.org/linux-arm-msm/20210310052503.3618486-1-bhupesh.sharma@linaro.org/ > - v1 did not work well as reported earlier by Dmitry, so v2 contains the following > changes/fixes: > ~ Enable the interconnect path b/w BAM DMA and main memory first > before trying to access the BAM DMA registers. > ~ Enable the interconnect path b/w qce crytpo and main memory first > before trying to access the qce crypto registers. > ~ Make sure to document the required and optional properties for both > BAM DMA and qce crypto drivers. > ~ Add a few debug related print messages in case the qce crypto driver > passes or fails to probe. > ~ Convert the qce crypto driver probe to a defered one in case the BAM DMA > or the interconnect driver(s) (needed on specific Qualcomm parts) are not > yet probed. > > Qualcomm crypto engine is also available on sm8150 and sm8250 SoCs. > The qce block supports hardware accelerated algorithms for encryption > and authentication. It also provides support for aes, des, 3des > encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256) > authentication algorithms. > > Tested the enabled crypto algorithms with cryptsetup test utilities > on sm8150-mtp, sa8155p-adp, sm8250-mtp and RB5 boards (see [1]) and > also with crypto self-tests, including the fuzz tests > (CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y). > > [1]. https://linux.die.net/man/8/cryptsetup > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> Extremely random drive-by. Bjorn pointed this series at me today and I verified that it works and works well on sm8250. I agree with the cleanups suggested but otherwise a very enthusiastic: Tested-by: Jordan Crouse <jorcrous@amazon.com> One nitpick possibly for the documentation somewhere. When I tried this on my own I was using the reg base from the downstream kernel which is obviously wrong. Perhaps a line somewhere in the bindings about how you calculate the base address may help future porting efforts. Jordan
Changes since v4: ================= - v4 for sm8250 can be seen here: https://lore.kernel.org/linux-arm-msm/20211013105541.68045-1-bhupesh.sharma@linaro.org/ - v1 for sm8150 qce enablement can be seen here: https://lore.kernel.org/linux-arm-msm/20211013165823.88123-1-bhupesh.sharma@linaro.org/ - Merged the sm8150 and sm8250 enablement patches in the same patchset, as per suggestions from Bjorn. - Dropped a couple of patches from v4, as these have been picked by Bjorn already via his tree. - Addressed review comments from Vladimir, Thara and Rob. - Collect Reviewed-by from Rob and Thara on some of the patches from the v4 patchset. Changes since v3: ================= - v3 can be seen here: https://lore.kernel.org/linux-arm-msm/20210519143700.27392-1-bhupesh.sharma@linaro.org/ - Dropped a couple of patches from v3, on basis of the review comments: ~ [PATCH 13/17] crypto: qce: core: Make clocks optional ~ [PATCH 15/17] crypto: qce: Convert the device found dev_dbg() to dev_info() - Addressed review comments from Thara, Rob and Stephan Gerhold. - Collect Reviewed-by from Rob and Thara on some of the patches from the v3 patchset. Changes since v2: ================= - v2 can be seen here: https://lore.kernel.org/dmaengine/20210505213731.538612-1-bhupesh.sharma@linaro.org/ - Drop a couple of patches from v1, which tried to address the defered probing of qce driver in case bam dma driver is not yet probed. Replace it instead with a single (simpler) patch [PATCH 16/17]. - Convert bam dma and qce crypto dt-bindings to YAML. - Addressed review comments from Thara, Bjorn, Vinod and Rob. Changes since v1: ================= - v1 can be seen here: https://lore.kernel.org/linux-arm-msm/20210310052503.3618486-1-bhupesh.sharma@linaro.org/ - v1 did not work well as reported earlier by Dmitry, so v2 contains the following changes/fixes: ~ Enable the interconnect path b/w BAM DMA and main memory first before trying to access the BAM DMA registers. ~ Enable the interconnect path b/w qce crytpo and main memory first before trying to access the qce crypto registers. ~ Make sure to document the required and optional properties for both BAM DMA and qce crypto drivers. ~ Add a few debug related print messages in case the qce crypto driver passes or fails to probe. ~ Convert the qce crypto driver probe to a defered one in case the BAM DMA or the interconnect driver(s) (needed on specific Qualcomm parts) are not yet probed. Qualcomm crypto engine is also available on sm8150 and sm8250 SoCs. The qce block supports hardware accelerated algorithms for encryption and authentication. It also provides support for aes, des, 3des encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256) authentication algorithms. Tested the enabled crypto algorithms with cryptsetup test utilities on sm8150-mtp, sa8155p-adp, sm8250-mtp and RB5 boards (see [1]) and also with crypto self-tests, including the fuzz tests (CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y). [1]. https://linux.die.net/man/8/cryptsetup Cc: Thara Gopinath <thara.gopinath@linaro.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Rob Herring <robh+dt@kernel.org> Bhupesh Sharma (19): arm64: dts: qcom: msm8996: Fix qcom,controlled-remotely property arm64: dts: qcom: msm8996: Fix 'dma' nodes in dts dt-bindings: qcom-bam: Convert binding to YAML dt-bindings: qcom-bam: Add 'interconnects' & 'interconnect-names' to optional properties dt-bindings: qcom-bam: Add 'iommus' to optional properties dt-bindings: qcom-bam: Add "powered remotely" mode dt-bindings: qcom-qce: Convert bindings to yaml dt-bindings: qcom-qce: Add 'interconnects' and 'interconnect-names' dt-bindings: qcom-qce: Move 'clocks' to optional properties dt-bindings: qcom-qce: Add 'iommus' to optional properties dt-bindings: crypto : Add new compatible strings for qcom-qce arm64/dts: qcom: Use new compatibles for crypto nodes crypto: qce: Add new compatibles for qce crypto driver crypto: qce: Print a failure msg in case probe() fails crypto: qce: Defer probing if BAM dma channel is not yet initialized crypto: qce: Add 'sm8250-qce' compatible string check crypto: qce: Add 'sm8150-qce' compatible string check arm64/dts: qcom: sm8250: Add dt entries to support crypto engine. arm64/dts: qcom: sm8150: Add dt entries to support crypto engine. Thara Gopinath (3): dma: qcom: bam_dma: Add support to initialize interconnect path crypto: qce: core: Add support to initialize interconnect path crypto: qce: core: Make clocks optional .../devicetree/bindings/crypto/qcom-qce.txt | 25 ---- .../devicetree/bindings/crypto/qcom-qce.yaml | 90 ++++++++++++++ .../devicetree/bindings/dma/qcom_bam_dma.txt | 50 -------- .../devicetree/bindings/dma/qcom_bam_dma.yaml | 115 ++++++++++++++++++ arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 +- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8150.dtsi | 28 +++++ arch/arm64/boot/dts/qcom/sm8250.dtsi | 28 +++++ drivers/crypto/qce/core.c | 66 +++++++--- drivers/crypto/qce/core.h | 1 + drivers/dma/qcom/bam_dma.c | 11 ++ 12 files changed, 326 insertions(+), 96 deletions(-) delete mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.txt create mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.yaml delete mode 100644 Documentation/devicetree/bindings/dma/qcom_bam_dma.txt create mode 100644 Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml