diff mbox series

[2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c

Message ID 20220211180216.290133-3-jacopo@jmondi.org (mailing list archive)
State New, archived
Headers show
Series media: De-stage imx7-mipi-csis.c | expand

Commit Message

Jacopo Mondi Feb. 11, 2022, 6:02 p.m. UTC 
Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7.

The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not
specify a SoC version number in the driver name.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 MAINTAINERS                                                     | 2 +-
 .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c}    | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%)

Comments

Laurent Pinchart Feb. 11, 2022, 8:42 p.m. UTC | #1 
Hi Jacopo,

Thank you for the patch.

On Fri, Feb 11, 2022 at 07:02:15PM +0100, Jacopo Mondi wrote:
> Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7.
> 
> The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not
> specify a SoC version number in the driver name.

I'm not against this, but I think we should then rename the symbols in
the source code too. I don't mind keeping the current name if the rename
causes too much churn.

> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  MAINTAINERS                                                     | 2 +-
>  .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c}    | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5bdb8c881b0b..7def3b7d56bc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11891,7 +11891,7 @@ T:	git git://linuxtv.org/media_tree.git
>  F:	Documentation/admin-guide/media/imx7.rst
>  F:	Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
>  F:	Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
> -F:	drivers/media/platform/imx/imx7-mipi-csis.c
> +F:	drivers/media/platform/imx/imx-mipi-csis.c
>  F:	drivers/staging/media/imx/imx7-media-csi.c
>  
>  MEDIA DRIVERS FOR HELENE
> diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c
> similarity index 100%
> rename from drivers/media/platform/imx/imx7-mipi-csis.c
> rename to drivers/media/platform/imx/imx-mipi-csis.c
kernel test robot Feb. 11, 2022, 10:15 p.m. UTC | #2 
Hi Jacopo,

I love your patch! Yet something to improve:

[auto build test ERROR on media-tree/master]
[also build test ERROR on shawnguo/for-next pza/reset/next linus/master v5.17-rc3 next-20220211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jacopo-Mondi/media-De-stage-imx7-mipi-csis-c/20220212-020342
base:   git://linuxtv.org/media_tree.git master
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220212/202202120641.u7xFAEMc-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/18a307fb15879832a050d12ae32bd9d94a9e5c91
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jacopo-Mondi/media-De-stage-imx7-mipi-csis-c/20220212-020342
        git checkout 18a307fb15879832a050d12ae32bd9d94a9e5c91
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash M=drivers/media

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> make[4]: *** No rule to make target 'drivers/media/platform/imx/imx7-mipi-csis.o', needed by 'drivers/media/platform/imx/imx7-mipi-csis.mod'.
   make[4]: Target '__build' not remade because of errors.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
kernel test robot Feb. 11, 2022, 11:57 p.m. UTC | #3 
Hi Jacopo,

I love your patch! Yet something to improve:

[auto build test ERROR on media-tree/master]
[also build test ERROR on shawnguo/for-next pza/reset/next linus/master v5.17-rc3 next-20220211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jacopo-Mondi/media-De-stage-imx7-mipi-csis-c/20220212-020342
base:   git://linuxtv.org/media_tree.git master
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220212/202202120715.pWMiLjja-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/18a307fb15879832a050d12ae32bd9d94a9e5c91
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jacopo-Mondi/media-De-stage-imx7-mipi-csis-c/20220212-020342
        git checkout 18a307fb15879832a050d12ae32bd9d94a9e5c91
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> make[5]: *** No rule to make target 'drivers/media/platform/imx/imx7-mipi-csis.o', needed by 'drivers/media/platform/imx/built-in.a'.
   make[5]: Target '__build' not remade because of errors.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Rui Miguel Silva Feb. 14, 2022, 10:20 a.m. UTC | #4 
Hey Jacopo,
I think you by now saw the kernel test report.

You miss the rename in the makefile also.

------
Cheers,
     Rui
On Fri Feb 11, 2022 at 6:02 PM WET, Jacopo Mondi wrote:

> Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7.
>
> The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not
> specify a SoC version number in the driver name.
>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  MAINTAINERS                                                     | 2 +-
>  .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c}    | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5bdb8c881b0b..7def3b7d56bc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11891,7 +11891,7 @@ T:	git git://linuxtv.org/media_tree.git
>  F:	Documentation/admin-guide/media/imx7.rst
>  F:	Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
>  F:	Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
> -F:	drivers/media/platform/imx/imx7-mipi-csis.c
> +F:	drivers/media/platform/imx/imx-mipi-csis.c
>  F:	drivers/staging/media/imx/imx7-media-csi.c
>  
>  MEDIA DRIVERS FOR HELENE
> diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c
> similarity index 100%
> rename from drivers/media/platform/imx/imx7-mipi-csis.c
> rename to drivers/media/platform/imx/imx-mipi-csis.c
> -- 
> 2.35.0
Rui Miguel Silva Feb. 14, 2022, 10:28 a.m. UTC | #5 
Hi Laurent,
On Fri Feb 11, 2022 at 8:42 PM WET, Laurent Pinchart wrote:

> Hi Jacopo,
>
> Thank you for the patch.
>
> On Fri, Feb 11, 2022 at 07:02:15PM +0100, Jacopo Mondi wrote:
> > Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7.
> > 
> > The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not
> > specify a SoC version number in the driver name.
>
> I'm not against this, but I think we should then rename the symbols in
> the source code too. I don't mind keeping the current name if the rename
> causes too much churn.

I think Jacopo does that in the 3/3 patch in the source and I think he
cover all, since the main symbols namespace is mipi_csis and do not
include imx7 specifically.

Cheers,
   Rui

>
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > ---
> >  MAINTAINERS                                                     | 2 +-
> >  .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c}    | 0
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> >  rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5bdb8c881b0b..7def3b7d56bc 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11891,7 +11891,7 @@ T:	git git://linuxtv.org/media_tree.git
> >  F:	Documentation/admin-guide/media/imx7.rst
> >  F:	Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
> >  F:	Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml

> > -F:	drivers/media/platform/imx/imx7-mipi-csis.c
> > +F:	drivers/media/platform/imx/imx-mipi-csis.c
> >  F:	drivers/staging/media/imx/imx7-media-csi.c
> >  
> >  MEDIA DRIVERS FOR HELENE
> > diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c
> > similarity index 100%
> > rename from drivers/media/platform/imx/imx7-mipi-csis.c
> > rename to drivers/media/platform/imx/imx-mipi-csis.c
>
> -- 
> Regards,
>
> Laurent Pinchart
Jacopo Mondi Feb. 14, 2022, 11:20 a.m. UTC | #6 
Hi Rui,

On Mon, Feb 14, 2022 at 10:20:57AM +0000, Rui Miguel Silva wrote:
> Hey Jacopo,
> I think you by now saw the kernel test report.
>
> You miss the rename in the makefile also.

Yes, that's pretty stupid sorry, I forgot to add the Makefile :(

I'll fix in v2

Laurent, do you want to squash 2/3 and 3/3 to have the symbols and the
file rename in the same patch ?

Thanks
  j

>
> ------
> Cheers,
>      Rui
> On Fri Feb 11, 2022 at 6:02 PM WET, Jacopo Mondi wrote:
>
> > Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7.
> >
> > The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not
> > specify a SoC version number in the driver name.
> >
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > ---
> >  MAINTAINERS                                                     | 2 +-
> >  .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c}    | 0
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> >  rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5bdb8c881b0b..7def3b7d56bc 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11891,7 +11891,7 @@ T:	git git://linuxtv.org/media_tree.git
> >  F:	Documentation/admin-guide/media/imx7.rst
> >  F:	Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
> >  F:	Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
> > -F:	drivers/media/platform/imx/imx7-mipi-csis.c
> > +F:	drivers/media/platform/imx/imx-mipi-csis.c
> >  F:	drivers/staging/media/imx/imx7-media-csi.c
> >
> >  MEDIA DRIVERS FOR HELENE
> > diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c
> > similarity index 100%
> > rename from drivers/media/platform/imx/imx7-mipi-csis.c
> > rename to drivers/media/platform/imx/imx-mipi-csis.c
> > --
> > 2.35.0
>
>
>
Laurent Pinchart Feb. 14, 2022, 11:22 a.m. UTC | #7 
Hi Jacopo,

On Mon, Feb 14, 2022 at 12:20:00PM +0100, Jacopo Mondi wrote:
> On Mon, Feb 14, 2022 at 10:20:57AM +0000, Rui Miguel Silva wrote:
> > Hey Jacopo,
> > I think you by now saw the kernel test report.
> >
> > You miss the rename in the makefile also.
> 
> Yes, that's pretty stupid sorry, I forgot to add the Makefile :(
> 
> I'll fix in v2
> 
> Laurent, do you want to squash 2/3 and 3/3 to have the symbols and the
> file rename in the same patch ?

I think I'd prefer that, but if it ends up being messy you can keep them
separate.

> > ------
> > Cheers,
> >      Rui
> > On Fri Feb 11, 2022 at 6:02 PM WET, Jacopo Mondi wrote:
> >
> > > Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7.
> > >
> > > The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not
> > > specify a SoC version number in the driver name.
> > >
> > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > > ---
> > >  MAINTAINERS                                                     | 2 +-
> > >  .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c}    | 0
> > >  2 files changed, 1 insertion(+), 1 deletion(-)
> > >  rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 5bdb8c881b0b..7def3b7d56bc 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -11891,7 +11891,7 @@ T:	git git://linuxtv.org/media_tree.git
> > >  F:	Documentation/admin-guide/media/imx7.rst
> > >  F:	Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
> > >  F:	Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
> > > -F:	drivers/media/platform/imx/imx7-mipi-csis.c
> > > +F:	drivers/media/platform/imx/imx-mipi-csis.c
> > >  F:	drivers/staging/media/imx/imx7-media-csi.c
> > >
> > >  MEDIA DRIVERS FOR HELENE
> > > diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c
> > > similarity index 100%
> > > rename from drivers/media/platform/imx/imx7-mipi-csis.c
> > > rename to drivers/media/platform/imx/imx-mipi-csis.c
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 5bdb8c881b0b..7def3b7d56bc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11891,7 +11891,7 @@  T:	git git://linuxtv.org/media_tree.git
 F:	Documentation/admin-guide/media/imx7.rst
 F:	Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
 F:	Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
-F:	drivers/media/platform/imx/imx7-mipi-csis.c
+F:	drivers/media/platform/imx/imx-mipi-csis.c
 F:	drivers/staging/media/imx/imx7-media-csi.c
 
 MEDIA DRIVERS FOR HELENE
diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c
similarity index 100%
rename from drivers/media/platform/imx/imx7-mipi-csis.c
rename to drivers/media/platform/imx/imx-mipi-csis.c