| Message ID | 20220208012539.491753-1-houtao1@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | bpf, arm64: fix bpf line info | expand |
ping ? On 2/8/2022 9:25 AM, Hou Tao wrote: > Hi, > > The patchset addresses two issues in bpf line info for arm64: > > (1) insn_to_jit_off only considers the body itself and ignores > prologue before the body. Fixed in patch #1. > > (2) insn_to_jit_off passed to bpf_prog_fill_jited_linfo() is > calculated in instruction granularity instead of bytes > granularity. Fixed in patch #2. > > Comments are always welcome. > > Regards, > Tao > > Change Log: > v3: > * patch #2: explain why bpf2a64_offset() needs update > * add Fixes tags in both patches > > v2: https://lore.kernel.org/bpf/20220125105707.292449-1-houtao1@huawei.com > * split into two independent patches (from Daniel) > * use AARCH64_INSN_SIZE instead of defining INSN_SIZE > > v1: https://lore.kernel.org/bpf/20220104014236.1512639-1-houtao1@huawei.com > > Hou Tao (2): > bpf, arm64: call build_prologue() first in first JIT pass > bpf, arm64: calculate offset as byte-offset for bpf line info > > arch/arm64/net/bpf_jit_comp.c | 29 +++++++++++++++++++---------- > 1 file changed, 19 insertions(+), 10 deletions(-) >
On Tue, Feb 08, 2022 at 09:25:37AM +0800, Hou Tao wrote: > Hi, > > The patchset addresses two issues in bpf line info for arm64: > > (1) insn_to_jit_off only considers the body itself and ignores > prologue before the body. Fixed in patch #1. > > (2) insn_to_jit_off passed to bpf_prog_fill_jited_linfo() is > calculated in instruction granularity instead of bytes > granularity. Fixed in patch #2. > > Comments are always welcome. > > Regards, > Tao > > Change Log: > v3: > * patch #2: explain why bpf2a64_offset() needs update > * add Fixes tags in both patches It makes sense to me on the bpf linfo expectation. It will be useful to also get some eyes from the arm experts. Acked-by: Martin KaFai Lau <kafai@fb.com>
Hi, The patchset addresses two issues in bpf line info for arm64: (1) insn_to_jit_off only considers the body itself and ignores prologue before the body. Fixed in patch #1. (2) insn_to_jit_off passed to bpf_prog_fill_jited_linfo() is calculated in instruction granularity instead of bytes granularity. Fixed in patch #2. Comments are always welcome. Regards, Tao Change Log: v3: * patch #2: explain why bpf2a64_offset() needs update * add Fixes tags in both patches v2: https://lore.kernel.org/bpf/20220125105707.292449-1-houtao1@huawei.com * split into two independent patches (from Daniel) * use AARCH64_INSN_SIZE instead of defining INSN_SIZE v1: https://lore.kernel.org/bpf/20220104014236.1512639-1-houtao1@huawei.com Hou Tao (2): bpf, arm64: call build_prologue() first in first JIT pass bpf, arm64: calculate offset as byte-offset for bpf line info arch/arm64/net/bpf_jit_comp.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-)