diff mbox series

[v6,2/3] dt-bindings: ls2k1000: add the display controller device node

Message ID 20220203082546.3099-3-15330273260@189.cn (mailing list archive)
State New, archived
Headers show
Series drm/lsdc: add drm driver for loongson display controller | expand

Commit Message

Sui Jingfeng Feb. 3, 2022, 8:25 a.m. UTC 
From: suijingfeng <suijingfeng@loongson.cn>

The display controller is a pci device, its vendor id is 0x0014
its device id is 0x7a06.

Signed-off-by: suijingfeng <suijingfeng@loongson.cn>
Signed-off-by: Sui Jingfeng <15330273260@189.cn>
---
 arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Krzysztof Kozlowski Feb. 3, 2022, 8:50 a.m. UTC | #1 
On Thu, 3 Feb 2022 at 09:26, Sui Jingfeng <15330273260@189.cn> wrote:
>
> From: suijingfeng <suijingfeng@loongson.cn>
>
> The display controller is a pci device, its vendor id is 0x0014
> its device id is 0x7a06.

The same as your patch 3 - these are not bindings.

Best regards,
Krzysztof
Sui Jingfeng Feb. 16, 2022, 2:01 p.m. UTC | #2 
On 2022/2/3 16:50, Krzysztof Kozlowski wrote:
> On Thu, 3 Feb 2022 at 09:26, Sui Jingfeng <15330273260@189.cn> wrote:
>> From: suijingfeng <suijingfeng@loongson.cn>
>>
>> The display controller is a pci device, its vendor id is 0x0014
>> its device id is 0x7a06.
> The same as your patch 3 - these are not bindings.
>
> Best regards,
> Krzysztof

Yes, you are right. As there is no compatible string in my driver to match against the compatible
in the dc@6,1 device node.

I don't know how to write YAML document now, it seems no similar case can be reference?
Krzysztof Kozlowski Feb. 17, 2022, 8:38 a.m. UTC | #3 
On 16/02/2022 15:01, Sui Jingfeng wrote:
> 
> On 2022/2/3 16:50, Krzysztof Kozlowski wrote:
>> On Thu, 3 Feb 2022 at 09:26, Sui Jingfeng <15330273260@189.cn> wrote:
>>> From: suijingfeng <suijingfeng@loongson.cn>
>>>
>>> The display controller is a pci device, its vendor id is 0x0014
>>> its device id is 0x7a06.
>> The same as your patch 3 - these are not bindings.
>>
>> Best regards,
>> Krzysztof
> 
> Yes, you are right. As there is no compatible string in my driver to match against the compatible
> in the dc@6,1 device node.
> 
> I don't know how to write YAML document now, it seems no similar case can be reference?

I referred to the subject - this patch is not a "dt-bindings" patch.


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
index 8143a61111e3..6510b0e6928a 100644
--- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
+++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
@@ -198,6 +198,17 @@ 
 				interrupt-parent = <&liointc0>;
 			};
 
+			lsdc: dc@6,0 {
+				compatible = "pci0014,7a06.0",
+						   "pci0014,7a06",
+						   "pciclass030000",
+						   "pciclass0300";
+
+				reg = <0x3000 0x0 0x0 0x0 0x0>;
+				interrupts = <28 IRQ_TYPE_LEVEL_LOW>;
+				interrupt-parent = <&liointc0>;
+			};
+
 			pci_bridge@9,0 {
 				compatible = "pci0014,7a19.0",
 						   "pci0014,7a19",