| Message ID | 20220208213754.3724193-1-mcgrof@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | common/config: fix use of MODPROBE_RM_PATIENT_TIMEOUT_ARGS | expand |
On Tue, Feb 08, 2022 at 01:37:54PM -0800, Luis Chamberlain wrote: > When patient module removal support is detected on kmod > (note that this is not yet even merged onto kmod yet but > work in progress) the arguments required for it are not being > set yet. This was a typo, fix this. > > This issue was spotted using shellcheck from blktests when adding > patient module removal support there. I'll post a patch next to > let folks evaluate if we should embrace shellcheck on fstests as > well. > > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> *Poke* Luis
diff --git a/common/config b/common/config index 2b357746..5fe2a5e8 100644 --- a/common/config +++ b/common/config @@ -280,7 +280,7 @@ else MODPROBE_PATIENT_RM_TIMEOUT_MS="$((MODPROBE_PATIENT_RM_TIMEOUT_SECONDS * 1000))" MODPROBE_RM_PATIENT_TIMEOUT_ARGS="-t $MODPROBE_PATIENT_RM_TIMEOUT_MS" fi - MODPROBE_REMOVE_PATIENT="modprobe -p $MODPROBE_RM_TIMEOUT_ARGS" + MODPROBE_REMOVE_PATIENT="modprobe -p $MODPROBE_RM_PATIENT_TIMEOUT_ARGS" fi export MODPROBE_REMOVE_PATIENT
When patient module removal support is detected on kmod (note that this is not yet even merged onto kmod yet but work in progress) the arguments required for it are not being set yet. This was a typo, fix this. This issue was spotted using shellcheck from blktests when adding patient module removal support there. I'll post a patch next to let folks evaluate if we should embrace shellcheck on fstests as well. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- common/config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)