| Message ID | 1644421175-31943-1-git-send-email-haakon.bugge@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [for-rc,v2] IB/cma: Allow XRG INI QPs to set their local ACK timeout | expand |
On Wed, Feb 09, 2022 at 04:39:35PM +0100, Håkon Bugge wrote: > XRC INI QPs should be able to adjust their local ACK timeout. > > Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set") > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > Suggested-by: Avneesh Pant <avneesh.pant@oracle.com> > > --- > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> On 13 Feb 2022, at 12:56, Leon Romanovsky <leon@kernel.org> wrote: > > On Wed, Feb 09, 2022 at 04:39:35PM +0100, Håkon Bugge wrote: >> XRC INI QPs should be able to adjust their local ACK timeout. >> >> Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set") >> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> >> Suggested-by: Avneesh Pant <avneesh.pant@oracle.com> >> >> --- >> > > Thanks, > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> Thanks Leon. I just saw that we need a s/XRG/XRC/ in $Subject. Shall I send a v3? Thxs, Håkon
On Thu, Feb 17, 2022 at 11:29:41AM +0000, Haakon Bugge wrote: > > > > On 13 Feb 2022, at 12:56, Leon Romanovsky <leon@kernel.org> wrote: > > > > On Wed, Feb 09, 2022 at 04:39:35PM +0100, Håkon Bugge wrote: > >> XRC INI QPs should be able to adjust their local ACK timeout. > >> > >> Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set") > >> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > >> Suggested-by: Avneesh Pant <avneesh.pant@oracle.com> > >> > >> > > > > Thanks, > > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > > Thanks Leon. I just saw that we need a s/XRG/XRC/ in $Subject. Shall I send a v3? I will fix it Jason
On Wed, Feb 09, 2022 at 04:39:35PM +0100, Håkon Bugge wrote: > XRC INI QPs should be able to adjust their local ACK timeout. > > Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set") > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > Suggested-by: Avneesh Pant <avneesh.pant@oracle.com> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > --- > > v1 -> v2: > * Removed WARN_ON as suggested by Leon > --- > drivers/infiniband/core/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index 0f5f0d7..7adacd1 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -2811,7 +2811,7 @@ int rdma_set_ack_timeout(struct rdma_cm_id *id, u8 timeout) { struct rdma_id_private *id_priv; - if (id->qp_type != IB_QPT_RC) + if (id->qp_type != IB_QPT_RC && id->qp_type != IB_QPT_XRC_INI) return -EINVAL; id_priv = container_of(id, struct rdma_id_private, id);
XRC INI QPs should be able to adjust their local ACK timeout. Fixes: 2c1619edef61 ("IB/cma: Define option to set ack timeout and pack tos_set") Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> Suggested-by: Avneesh Pant <avneesh.pant@oracle.com> --- v1 -> v2: * Removed WARN_ON as suggested by Leon --- drivers/infiniband/core/cma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)