| Message ID | 20220217104444.7695-4-zev@bewilderbeest.net (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | misc: Add power-efuse driver | expand |
On Thu, 17 Feb 2022 02:44:43 -0800, Zev Weiss wrote: > This can be used to describe a power output supplied by a regulator > device that the system controls. > > Signed-off-by: Zev Weiss <zev@bewilderbeest.net> > --- > .../devicetree/bindings/misc/power-efuse.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/power-efuse.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/misc/power-efuse.yaml:10:2: [warning] wrong indentation: expected 2 but found 1 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1594124 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Thu, Feb 17, 2022 at 02:44:43AM -0800, Zev Weiss wrote: > This can be used to describe a power output supplied by a regulator > device that the system controls. > > Signed-off-by: Zev Weiss <zev@bewilderbeest.net> > --- > .../devicetree/bindings/misc/power-efuse.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/power-efuse.yaml > > diff --git a/Documentation/devicetree/bindings/misc/power-efuse.yaml b/Documentation/devicetree/bindings/misc/power-efuse.yaml > new file mode 100644 > index 000000000000..cadce15d2ce7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/power-efuse.yaml > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/misc/power-efuse.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic power efuse device No idea what this is, but I doubt any such generic device exists. This needs sufficient description to be convincing that it is indeed generic. > + > +maintainers: > + - Zev Weiss <zev@bewilderbeest.net> > + > +properties: > + compatible: > + const: power-efuse > + > + vout-supply: > + description: > + phandle to the regulator providing power for the efuse > + > + error-flags-cache-ttl-ms: > + description: > + The number of milliseconds the vout-supply regulator's error > + flags should be cached before re-fetching them. What are 'error flags'? Not something I've heard with respect to regulators. > + > +required: > + - compatible > + - vout-supply > + > +additionalProperties: false > + > +examples: > + - | > + efuse { > + compatible = "power-efuse"; > + vout-supply = <&efuse_reg>; > + error-flags-cache-ttl-ms = <500>; > + }; > -- > 2.35.1 > >
On Thu, Feb 17, 2022 at 02:35:12PM PST, Rob Herring wrote: >On Thu, Feb 17, 2022 at 02:44:43AM -0800, Zev Weiss wrote: >> This can be used to describe a power output supplied by a regulator >> device that the system controls. >> >> Signed-off-by: Zev Weiss <zev@bewilderbeest.net> >> --- >> .../devicetree/bindings/misc/power-efuse.yaml | 37 +++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/misc/power-efuse.yaml >> >> diff --git a/Documentation/devicetree/bindings/misc/power-efuse.yaml b/Documentation/devicetree/bindings/misc/power-efuse.yaml >> new file mode 100644 >> index 000000000000..cadce15d2ce7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/misc/power-efuse.yaml >> @@ -0,0 +1,37 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/misc/power-efuse.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Generic power efuse device > >No idea what this is, but I doubt any such generic device exists. This >needs sufficient description to be convincing that it is indeed generic. > I was struggling a bit to come up with a reasonably concise title; this admittedly isn't great. Would a description like the following clarify it adequately? description: | This binding describes a physical power output supplied by a regulator providing efuse functionality (manual on/off control, and auto-shutoff if current, voltage, or thermal limits are exceeded). These may be found on systems such as "smart" network PDUs, and typically supply power to devices entirely separate from the system described by the device-tree by way of an external connector such as an Open19 power cable: https://www.open19.org/marketplace/coolpower-cable-assembly-8ru/ >> + >> +maintainers: >> + - Zev Weiss <zev@bewilderbeest.net> >> + >> +properties: >> + compatible: >> + const: power-efuse >> + >> + vout-supply: >> + description: >> + phandle to the regulator providing power for the efuse >> + >> + error-flags-cache-ttl-ms: >> + description: >> + The number of milliseconds the vout-supply regulator's error >> + flags should be cached before re-fetching them. > >What are 'error flags'? Not something I've heard with respect to >regulators. > That refers to the REGULATOR_ERROR_* flags in include/linux/regulator/consumer.h, in whatever "physical" form those ultimately take -- for example, in the PMBus-based case I'm currently aiming to support, they'd map to the flags returned by PMBus STATUS_* commands. Thanks for the review, Zev
diff --git a/Documentation/devicetree/bindings/misc/power-efuse.yaml b/Documentation/devicetree/bindings/misc/power-efuse.yaml new file mode 100644 index 000000000000..cadce15d2ce7 --- /dev/null +++ b/Documentation/devicetree/bindings/misc/power-efuse.yaml @@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/misc/power-efuse.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Generic power efuse device + +maintainers: + - Zev Weiss <zev@bewilderbeest.net> + +properties: + compatible: + const: power-efuse + + vout-supply: + description: + phandle to the regulator providing power for the efuse + + error-flags-cache-ttl-ms: + description: + The number of milliseconds the vout-supply regulator's error + flags should be cached before re-fetching them. + +required: + - compatible + - vout-supply + +additionalProperties: false + +examples: + - | + efuse { + compatible = "power-efuse"; + vout-supply = <&efuse_reg>; + error-flags-cache-ttl-ms = <500>; + };
This can be used to describe a power output supplied by a regulator device that the system controls. Signed-off-by: Zev Weiss <zev@bewilderbeest.net> --- .../devicetree/bindings/misc/power-efuse.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/power-efuse.yaml