diff mbox series

i2c: brcmstb: fix support for DSL and CM variants

Message ID 20220215072735.17335-1-zajec5@gmail.com (mailing list archive)
State New, archived
Headers show
Series i2c: brcmstb: fix support for DSL and CM variants | expand

Commit Message

Rafał Miłecki Feb. 15, 2022, 7:27 a.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

DSL and CM (Cable Modem) support 8 B max transfer size and have a custom
DT binding for that reason. This driver was checking for a wrong
"compatible" however which resulted in an incorrect setup.

Fixes: e2e5a2c61837 ("i2c: brcmstb: Adding support for CM and DSL SoCs")
Cc: Kamal Dasu <kdasu.kdev@gmail.com>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/i2c/busses/i2c-brcmstb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Florian Fainelli Feb. 15, 2022, 4:10 p.m. UTC | #1 
On 2/14/2022 11:27 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> DSL and CM (Cable Modem) support 8 B max transfer size and have a custom
> DT binding for that reason. This driver was checking for a wrong
> "compatible" however which resulted in an incorrect setup.
> 
> Fixes: e2e5a2c61837 ("i2c: brcmstb: Adding support for CM and DSL SoCs")
> Cc: Kamal Dasu <kdasu.kdev@gmail.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Wolfram Sang Feb. 18, 2022, 9:41 a.m. UTC | #2 
On Tue, Feb 15, 2022 at 08:27:35AM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> DSL and CM (Cable Modem) support 8 B max transfer size and have a custom
> DT binding for that reason. This driver was checking for a wrong
> "compatible" however which resulted in an incorrect setup.
> 
> Fixes: e2e5a2c61837 ("i2c: brcmstb: Adding support for CM and DSL SoCs")
> Cc: Kamal Dasu <kdasu.kdev@gmail.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Applied to for-current, thanks!
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcmstb.c
index 490ee3962645..b00f35c0b066 100644
--- a/drivers/i2c/busses/i2c-brcmstb.c
+++ b/drivers/i2c/busses/i2c-brcmstb.c
@@ -673,7 +673,7 @@  static int brcmstb_i2c_probe(struct platform_device *pdev)
 
 	/* set the data in/out register size for compatible SoCs */
 	if (of_device_is_compatible(dev->device->of_node,
-				    "brcmstb,brcmper-i2c"))
+				    "brcm,brcmper-i2c"))
 		dev->data_regsz = sizeof(u8);
 	else
 		dev->data_regsz = sizeof(u32);