| Message ID | 20220219005221.634-17-bhe@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | Don't use kmalloc() with GFP_DMA | expand |
On Sat, Feb 19, 2022 at 08:52:15AM +0800, Baoquan He wrote: > dma_pool_alloc() uses dma_alloc_coherent() to pre-allocate DMA buffer, > so it's redundent to specify GFP_DMA when calling. Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c index bcba5f9bc5a3..d234de1c62b3 100644 --- a/drivers/usb/gadget/udc/lpc32xx_udc.c +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c @@ -922,7 +922,7 @@ static struct lpc32xx_usbd_dd_gad *udc_dd_alloc(struct lpc32xx_udc *udc) dma_addr_t dma; struct lpc32xx_usbd_dd_gad *dd; - dd = dma_pool_alloc(udc->dd_cache, GFP_ATOMIC | GFP_DMA, &dma); + dd = dma_pool_alloc(udc->dd_cache, GFP_ATOMIC, &dma); if (dd) dd->this_dma = dma;
dma_pool_alloc() uses dma_alloc_coherent() to pre-allocate DMA buffer, so it's redundent to specify GFP_DMA when calling. Signed-off-by: Baoquan He <bhe@redhat.com> --- drivers/usb/gadget/udc/lpc32xx_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)