| Message ID | 20220218155148.2329797-4-schultz.hans+netdev@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b9e8b58fd2cb30cb6e01d72c7d32286810a9bca9 |
| Headers | show |
| Series | Add support for locked bridge ports (for 802.1X) | expand |
On Fri, Feb 18, 2022 at 04:51:46PM +0100, Hans Schultz wrote: > Among the switchcores that support this feature is the Marvell > mv88e6xxx family. > > Signed-off-by: Hans Schultz <schultz.hans+netdev@gmail.com> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Although this doesn't "add support for offloaded locked ports", that passes right through with no DSA-level filtering, from SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS to dsa_port_bridge_flags(), to ds->ops->port_bridge_flags(). Rather, a clearer description of what this does is: net: dsa: include BR_PORT_LOCKED in the list of synced brport flags Make sure the DSA switch driver gets notified of changes to the BR_PORT_LOCKED flag as well, for the case when a DSA port joins or leaves a LAG that is a bridge port.
diff --git a/net/dsa/port.c b/net/dsa/port.c index bd78192e0e47..01ed22ed74a1 100644 --- a/net/dsa/port.c +++ b/net/dsa/port.c @@ -176,7 +176,7 @@ static int dsa_port_inherit_brport_flags(struct dsa_port *dp, struct netlink_ext_ack *extack) { const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD | - BR_BCAST_FLOOD; + BR_BCAST_FLOOD | BR_PORT_LOCKED; struct net_device *brport_dev = dsa_port_to_bridge_port(dp); int flag, err; @@ -200,7 +200,7 @@ static void dsa_port_clear_brport_flags(struct dsa_port *dp) { const unsigned long val = BR_FLOOD | BR_MCAST_FLOOD | BR_BCAST_FLOOD; const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD | - BR_BCAST_FLOOD; + BR_BCAST_FLOOD | BR_PORT_LOCKED; int flag, err; for_each_set_bit(flag, &mask, 32) {
Among the switchcores that support this feature is the Marvell mv88e6xxx family. Signed-off-by: Hans Schultz <schultz.hans+netdev@gmail.com> --- net/dsa/port.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)