| Message ID | 20220221174903.320466-1-jacopo@jmondi.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] media: imx: imx8mq-mipi-csi2: Remove YUV422 2X8 | expand |
On Mon, Feb 21, 2022 at 06:49:03PM +0100, Jacopo Mondi wrote: > The 2X8 variants of MEDIA_BUS_FMT_YUYV8_2X8 does not apply to serial > busses. > > Drop it and while at it also add the canonical UYVY wire format for > packed YUV422 when transmitted on the CSI-2 serial bus. > > Also beautify a little the formats declaration list by putting the > opening curly brace after the comment. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > > v1->v2: > - Fix subject (s/mp/mq) as reported by Adam > - Add UYVY_1X16 as suggested by Laurent > > drivers/staging/media/imx/imx8mq-mipi-csi2.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/imx/imx8mq-mipi-csi2.c b/drivers/staging/media/imx/imx8mq-mipi-csi2.c > index 56ef3b3b2906..7d03cb340ed4 100644 > --- a/drivers/staging/media/imx/imx8mq-mipi-csi2.c > +++ b/drivers/staging/media/imx/imx8mq-mipi-csi2.c > @@ -200,14 +200,16 @@ static const struct csi2_pix_format imx8mq_mipi_csi_formats[] = { > }, { > .code = MEDIA_BUS_FMT_SRGGB14_1X14, > .width = 14, > - }, { > + }, > /* YUV formats */ > - .code = MEDIA_BUS_FMT_YUYV8_2X8, > - .width = 16, > - }, { > + { > .code = MEDIA_BUS_FMT_YUYV8_1X16, > .width = 16, > } Damn me rushing to get stuff out. v3 on its way :( > + { > + .code = MEDIA_BUS_FMT_UYVY8_1X16, > + .width = 16, > + } > }; > > static const struct csi2_pix_format *find_csi2_format(u32 code) > -- > 2.35.0 >
Hi Jacopo, Thank you for the patch. On Mon, Feb 21, 2022 at 06:49:03PM +0100, Jacopo Mondi wrote: > The 2X8 variants of MEDIA_BUS_FMT_YUYV8_2X8 does not apply to serial > busses. > > Drop it and while at it also add the canonical UYVY wire format for > packed YUV422 when transmitted on the CSI-2 serial bus. > > Also beautify a little the formats declaration list by putting the > opening curly brace after the comment. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > > v1->v2: > - Fix subject (s/mp/mq) as reported by Adam > - Add UYVY_1X16 as suggested by Laurent > > drivers/staging/media/imx/imx8mq-mipi-csi2.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/imx/imx8mq-mipi-csi2.c b/drivers/staging/media/imx/imx8mq-mipi-csi2.c > index 56ef3b3b2906..7d03cb340ed4 100644 > --- a/drivers/staging/media/imx/imx8mq-mipi-csi2.c > +++ b/drivers/staging/media/imx/imx8mq-mipi-csi2.c > @@ -200,14 +200,16 @@ static const struct csi2_pix_format imx8mq_mipi_csi_formats[] = { > }, { > .code = MEDIA_BUS_FMT_SRGGB14_1X14, > .width = 14, > - }, { > + }, > /* YUV formats */ > - .code = MEDIA_BUS_FMT_YUYV8_2X8, > - .width = 16, > - }, { > + { > .code = MEDIA_BUS_FMT_YUYV8_1X16, > .width = 16, > } > + { > + .code = MEDIA_BUS_FMT_UYVY8_1X16, > + .width = 16, > + } > }; > > static const struct csi2_pix_format *find_csi2_format(u32 code)
diff --git a/drivers/staging/media/imx/imx8mq-mipi-csi2.c b/drivers/staging/media/imx/imx8mq-mipi-csi2.c index 56ef3b3b2906..7d03cb340ed4 100644 --- a/drivers/staging/media/imx/imx8mq-mipi-csi2.c +++ b/drivers/staging/media/imx/imx8mq-mipi-csi2.c @@ -200,14 +200,16 @@ static const struct csi2_pix_format imx8mq_mipi_csi_formats[] = { }, { .code = MEDIA_BUS_FMT_SRGGB14_1X14, .width = 14, - }, { + }, /* YUV formats */ - .code = MEDIA_BUS_FMT_YUYV8_2X8, - .width = 16, - }, { + { .code = MEDIA_BUS_FMT_YUYV8_1X16, .width = 16, } + { + .code = MEDIA_BUS_FMT_UYVY8_1X16, + .width = 16, + } }; static const struct csi2_pix_format *find_csi2_format(u32 code)
The 2X8 variants of MEDIA_BUS_FMT_YUYV8_2X8 does not apply to serial busses. Drop it and while at it also add the canonical UYVY wire format for packed YUV422 when transmitted on the CSI-2 serial bus. Also beautify a little the formats declaration list by putting the opening curly brace after the comment. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- v1->v2: - Fix subject (s/mp/mq) as reported by Adam - Add UYVY_1X16 as suggested by Laurent drivers/staging/media/imx/imx8mq-mipi-csi2.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) -- 2.35.0