| Message ID | 5e7e06e0cb189bab4586646470894bbda572785d.1645454002.git.baruch@tkos.co.il (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] dt-bindings: net: ipq4019-mdio: Add ipq6018 compatible | expand |
On 21/02/2022 14:33, Baruch Siach wrote: > From: Baruch Siach <baruch.siach@siklu.com> > > The IPQ60xx has the same MDIO bug block as IPQ4019. Add IO range and > clock resources description. > > Signed-off-by: Baruch Siach <baruch.siach@siklu.com> > --- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > index 5eb7dc9cc231..093011d18ca6 100644 > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > @@ -635,6 +635,16 @@ qrtr_requests { > }; > }; > > + mdio: mdio@90000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "qcom,ipq6018-mdio", "qcom,ipq4019-mdio"; > + reg = <0x0 0x90000 0x0 0x64>; > + clocks = <&gcc GCC_MDIO_AHB_CLK>; > + clock-names = "gcc_mdio_ahb_clk"; > + status = "disabled"; > + }; > + > qusb_phy_1: qusb@59000 { > compatible = "qcom,ipq6018-qusb2-phy"; > reg = <0x0 0x059000 0x0 0x180>; LGTM Reviewd-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On 21/02/2022 14:33, Baruch Siach wrote: > From: Baruch Siach <baruch.siach@siklu.com> > > The IPQ60xx has the same MDIO bug block as IPQ4019. Add IO range and > clock resources description. > > Signed-off-by: Baruch Siach <baruch.siach@siklu.com> > --- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > index 5eb7dc9cc231..093011d18ca6 100644 > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > @@ -635,6 +635,16 @@ qrtr_requests { > }; > }; > > + mdio: mdio@90000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "qcom,ipq6018-mdio", "qcom,ipq4019-mdio"; > + reg = <0x0 0x90000 0x0 0x64>; > + clocks = <&gcc GCC_MDIO_AHB_CLK>; > + clock-names = "gcc_mdio_ahb_clk"; > + status = "disabled"; > + }; > + > qusb_phy_1: qusb@59000 { > compatible = "qcom,ipq6018-qusb2-phy"; > reg = <0x0 0x059000 0x0 0x180>; Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
On Mon, Feb 21, 2022 at 04:33:22PM +0200, Baruch Siach wrote: > From: Baruch Siach <baruch.siach@siklu.com> > > The IPQ60xx has the same MDIO bug block as IPQ4019. Add IO range and > clock resources description. > > Signed-off-by: Baruch Siach <baruch.siach@siklu.com> > --- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > index 5eb7dc9cc231..093011d18ca6 100644 > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > @@ -635,6 +635,16 @@ qrtr_requests { > }; > }; > > + mdio: mdio@90000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "qcom,ipq6018-mdio", "qcom,ipq4019-mdio"; This looks correct with the fallback based on your description, but it doesn't match the schema. You tested this with the schemas, right? That's why we have them. > + reg = <0x0 0x90000 0x0 0x64>; > + clocks = <&gcc GCC_MDIO_AHB_CLK>; > + clock-names = "gcc_mdio_ahb_clk"; > + status = "disabled"; > + }; > + > qusb_phy_1: qusb@59000 { > compatible = "qcom,ipq6018-qusb2-phy"; > reg = <0x0 0x059000 0x0 0x180>; > -- > 2.34.1 > >
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index 5eb7dc9cc231..093011d18ca6 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -635,6 +635,16 @@ qrtr_requests { }; }; + mdio: mdio@90000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "qcom,ipq6018-mdio", "qcom,ipq4019-mdio"; + reg = <0x0 0x90000 0x0 0x64>; + clocks = <&gcc GCC_MDIO_AHB_CLK>; + clock-names = "gcc_mdio_ahb_clk"; + status = "disabled"; + }; + qusb_phy_1: qusb@59000 { compatible = "qcom,ipq6018-qusb2-phy"; reg = <0x0 0x059000 0x0 0x180>;