| Message ID | 20220218212511.887059-1-atomlin@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | module: core code clean up | expand |
On Fri, Feb 18, 2022 at 09:24:58PM +0000, Aaron Tomlin wrote: > Hi Luis, > > As per your suggestion [1], this is an attempt to refactor and split > optional code out of core module support code into separate components. > This version is based on Linus' commit 7993e65fdd0f ("Merge tag > 'mtd/fixes-for-5.17-rc5' of > git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux"). > Please let me know your thoughts. Fantastic, thanks for doing all this work, I've pushed this out to modules-next so that the testing can start as this will be in linux-next soon. I'll obviously wait for more reviews, we have a long time before this gets merged to Linus, so just want to start getting testing done now rather than later. And other folks are depending on your changes to start getting their own code up too. Thanks! Luis
On Fri, 18 Feb 2022, Luis Chamberlain wrote: > On Fri, Feb 18, 2022 at 09:24:58PM +0000, Aaron Tomlin wrote: > > Hi Luis, > > > > As per your suggestion [1], this is an attempt to refactor and split > > optional code out of core module support code into separate components. > > This version is based on Linus' commit 7993e65fdd0f ("Merge tag > > 'mtd/fixes-for-5.17-rc5' of > > git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux"). > > Please let me know your thoughts. > > Fantastic, thanks for doing all this work, I've pushed this out to > modules-next so that the testing can start as this will be in linux-next > soon. I'll obviously wait for more reviews, we have a long time before this > gets merged to Linus, so just want to start getting testing done now rather > than later. And other folks are depending on your changes to start > getting their own code up too. Aaron's series is unfortunately split. Could you also push out the remaining 3 patches (20220218212757.888751-1-atomlin@redhat.com), please? Miroslav
Le 19/02/2022 à 03:12, Luis Chamberlain a écrit : > On Fri, Feb 18, 2022 at 09:24:58PM +0000, Aaron Tomlin wrote: >> Hi Luis, >> >> As per your suggestion [1], this is an attempt to refactor and split >> optional code out of core module support code into separate components. >> This version is based on Linus' commit 7993e65fdd0f ("Merge tag >> 'mtd/fixes-for-5.17-rc5' of >> git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux"). >> Please let me know your thoughts. > > Fantastic, thanks for doing all this work, I've pushed this out to > modules-next so that the testing can start as this will be in linux-next > soon. I'll obviously wait for more reviews, we have a long time before this > gets merged to Linus, so just want to start getting testing done now rather > than later. And other folks are depending on your changes to start > getting their own code up too. > Hi Luis, modules-next misses the 3 last patches from Aaron. Aaron's series as build problems, I sent 4 fixups which allows it to build, then I rebased my series on top of that. And I added on top of it some misc cleanups. All this has undergone kisskb build test at http://kisskb.ellerman.id.au/kisskb/head/d8ee36c58284baf315e8aa3532a8d97abae8026d/ This only build failure (indeed a final link failure) is unrelated to my series. Everything is also available on https://github.com/chleroy/linux.git in branch module-v4 Looking forward to getting everything into modules-next hence into linux-next. Christophe
On Fri 2022-02-18 18:12 -0800, Luis Chamberlain wrote: > On Fri, Feb 18, 2022 at 09:24:58PM +0000, Aaron Tomlin wrote: > > Hi Luis, > > > > As per your suggestion [1], this is an attempt to refactor and split > > optional code out of core module support code into separate components. > > This version is based on Linus' commit 7993e65fdd0f ("Merge tag > > 'mtd/fixes-for-5.17-rc5' of > > git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux"). > > Please let me know your thoughts. > > Fantastic, thanks for doing all this work, I've pushed this out to > modules-next so that the testing can start as this will be in linux-next > soon. I'll obviously wait for more reviews, we have a long time before this > gets merged to Linus, so just want to start getting testing done now rather > than later. And other folks are depending on your changes to start > getting their own code up too. Hi Luis, No problem. Unfortunately, this was not the complete series. I can send a v7 later today with the suggested improvements made by Christophe. Kind regards,
Hi Luis, As per your suggestion [1], this is an attempt to refactor and split optional code out of core module support code into separate components. This version is based on Linus' commit 7993e65fdd0f ("Merge tag 'mtd/fixes-for-5.17-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux"). Please let me know your thoughts. Changes since v5 [2]: - Updated MAINTAINERS to include the entire kernel/module/ directory (Christophe Leroy) - Reintroduce commit a97ac8cb24a3 ("module: fix signature check failures when using in-kernel decompression") (Michal Suchánek) - Refactored code to address some (i.e. --ignore=MULTIPLE_ASSIGNMENTS,ASSIGN_IN_IF was used) style violations e.g. "Alignment should match open parenthesis", reported by scripts/checkpatch.pl --strict (Christophe Leroy) - Used PAGE_ALIGN() and PAGE_ALIGNED() instead (Christophe Leroy) - Removed sig_enforce from include/linux/module.h as it is only used in kernel/module/signing.c (Christophe Leroy) - Added static keyword for anything not used outside a source file (Christophe Leroy) - Moved mod_sysfs_teardown() to kernel/module/sysfs.c (Christophe Leroy) - Removed kdb_modules from kernel/debug/kdb/kdb_private.h (Christophe Leroy) Changes since v4 [3]: - Moved is_livepatch_module() and set_livepatch_module() to kernel/module/livepatch.c - Addressed minor compiler warning concerning kernel/module/internal.h (0-day) - Resolved style violations reported by scripts/checkpatch.pl - Dropped patch 5 [4] so external patch [5] can be applied at a later date post merge into module-next (Christophe Leroy) Changes since v3 [6]: - Refactored both is_livepatch_module() and set_livepatch_module(), respectively, to use IS_ENABLED(CONFIG_LIVEPATCH) (Joe Perches) - Addressed various compiler warnings e.g., no previous prototype (0-day) Changes since v2 [7]: - Moved module decompress support to a separate file - Made check_modinfo_livepatch() generic (Petr Mladek) - Removed filename from each newly created file (Luis Chamberlain) - Addressed some (i.e. --ignore=ASSIGN_IN_IF,AVOID_BUG was used) minor scripts/checkpatch.pl concerns e.g., use strscpy over strlcpy and missing a blank line after declarations (Allen) Changes since v1 [8]: - Moved module version support code into a new file [1]: https://lore.kernel.org/lkml/YbEZ4HgSYQEPuRmS@bombadil.infradead.org/ [2]: https://lore.kernel.org/lkml/20220209170358.3266629-1-atomlin@redhat.com/ [3]: https://lore.kernel.org/lkml/20220130213214.1042497-1-atomlin@redhat.com/ [4]: https://lore.kernel.org/lkml/20220130213214.1042497-6-atomlin@redhat.com/ [5]: https://lore.kernel.org/lkml/203348805c9ac9851d8939d15cb9802ef047b5e2.1643919758.git.christophe.leroy@csgroup.eu/ [6]: https://lore.kernel.org/lkml/20220128203934.600247-1-atomlin@redhat.com/ [7]: https://lore.kernel.org/lkml/20220106234319.2067842-1-atomlin@redhat.com/ [8]: https://lore.kernel.org/lkml/20211228213041.1356334-1-atomlin@redhat.com/ Aaron Tomlin (13): module: Move all into module/ module: Simple refactor in preparation for split module: Make internal.h and decompress.c more compliant module: Move livepatch support to a separate file module: Move latched RB-tree support to a separate file module: Move strict rwx support to a separate file module: Move extra signature support out of core code module: Move kmemleak support to a separate file module: Move kallsyms support into a separate file module: Move procfs support into a separate file module: Move sysfs support into a separate file module: Move kdb_modules list out of core code module: Move version support into a separate file MAINTAINERS | 2 +- include/linux/module.h | 9 +- kernel/Makefile | 5 +- kernel/debug/kdb/kdb_main.c | 5 + kernel/debug/kdb/kdb_private.h | 4 - kernel/module-internal.h | 50 - kernel/module/Makefile | 19 + kernel/module/debug_kmemleak.c | 30 + .../decompress.c} | 5 +- kernel/module/internal.h | 284 +++ kernel/module/kallsyms.c | 502 +++++ kernel/module/livepatch.c | 74 + kernel/{module.c => module/main.c} | 1856 +---------------- kernel/module/procfs.c | 142 ++ .../signature.c} | 0 kernel/module/signing.c | 122 ++ kernel/module/strict_rwx.c | 84 + kernel/module/sysfs.c | 436 ++++ kernel/module/tree_lookup.c | 109 + kernel/module/version.c | 109 + kernel/module_signing.c | 45 - 21 files changed, 2010 insertions(+), 1882 deletions(-) delete mode 100644 kernel/module-internal.h create mode 100644 kernel/module/Makefile create mode 100644 kernel/module/debug_kmemleak.c rename kernel/{module_decompress.c => module/decompress.c} (99%) create mode 100644 kernel/module/internal.h create mode 100644 kernel/module/kallsyms.c create mode 100644 kernel/module/livepatch.c rename kernel/{module.c => module/main.c} (64%) create mode 100644 kernel/module/procfs.c rename kernel/{module_signature.c => module/signature.c} (100%) create mode 100644 kernel/module/signing.c create mode 100644 kernel/module/strict_rwx.c create mode 100644 kernel/module/sysfs.c create mode 100644 kernel/module/tree_lookup.c create mode 100644 kernel/module/version.c delete mode 100644 kernel/module_signing.c base-commit: 7993e65fdd0fe07beb9f36f998f9bbef2c0ee391