| Message ID | cover.1645542893.git.christophe.leroy@csgroup.eu (mailing list archive) |
|---|---|
| Headers | show |
| Series | Miscellaneous cleanups | expand |
On Tue, Feb 22, 2022 at 04:16:30PM +0100, Christophe Leroy wrote: > This series applies on top of my series "Allocate module text and data separately" v5. > > It does some cleanup around the settling of modules's layout page flags: > - Make module_enable_x() independent of CONFIG_ARCH_HAS_STRICT_MODULE_RWX > - Reunify everything into strict_rwx.c > - Change big hammer BUG_ON()s into WARN_ON()s > - Change misleading debug_align() to strict_align() > > Changes in v2/v3: > - Rebased on top of my series "Allocate module text and data separately" v5 > - Moved the Kconfig patch out of this series, it is an independent change > > Sorry for the mess in v2. Thanks for all this work! Any chance you can actually submit this prior to your allocate module series? This and the patch, "module: Move module's Kconfig item in kernel/module/". Because *iff* we get enough testing out of Aaron's changes and your cleanups, perhaps those might be candidates for the next merge window. Then we can save all the new functional changes for the other merge window. Luis
Le 23/02/2022 à 01:27, Luis Chamberlain a écrit : > On Tue, Feb 22, 2022 at 04:16:30PM +0100, Christophe Leroy wrote: >> This series applies on top of my series "Allocate module text and data separately" v5. >> >> It does some cleanup around the settling of modules's layout page flags: >> - Make module_enable_x() independent of CONFIG_ARCH_HAS_STRICT_MODULE_RWX >> - Reunify everything into strict_rwx.c >> - Change big hammer BUG_ON()s into WARN_ON()s >> - Change misleading debug_align() to strict_align() >> >> Changes in v2/v3: >> - Rebased on top of my series "Allocate module text and data separately" v5 >> - Moved the Kconfig patch out of this series, it is an independent change >> >> Sorry for the mess in v2. > > Thanks for all this work! Any chance you can actually submit this prior > to your allocate module series? This and the patch, "module: Move > module's Kconfig item in kernel/module/". Because *iff* we get enough > testing out of Aaron's changes and your cleanups, perhaps those might > be candidates for the next merge window. Then we can save all the new > functional changes for the other merge window. > Sure I can switch the two series. The Kconfig patch is independant, you can already apply it in any order, I won't resend unless I get comments on it. Christophe
This series applies on top of my series "Allocate module text and data separately" v5. It does some cleanup around the settling of modules's layout page flags: - Make module_enable_x() independent of CONFIG_ARCH_HAS_STRICT_MODULE_RWX - Reunify everything into strict_rwx.c - Change big hammer BUG_ON()s into WARN_ON()s - Change misleading debug_align() to strict_align() Changes in v2/v3: - Rebased on top of my series "Allocate module text and data separately" v5 - Moved the Kconfig patch out of this series, it is an independent change Sorry for the mess in v2. Christophe Leroy (4): module: Make module_enable_x() independent of CONFIG_ARCH_HAS_STRICT_MODULE_RWX module: Move module_enable_x() and frob_text() in strict_rwx.c module: Rework layout alignment to avoid BUG_ON()s module: Rename debug_align() as strict_align() kernel/module/Makefile | 3 +- kernel/module/internal.h | 26 +++---------- kernel/module/kallsyms.c | 4 +- kernel/module/main.c | 58 ++++++----------------------- kernel/module/strict_rwx.c | 76 +++++++++++++++++++++++++++++++++----- 5 files changed, 88 insertions(+), 79 deletions(-)