| Message ID | 20220223130808.13352-1-cristian.pop@analog.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v7,1/2] dt-bindings: iio: frequency: Add ADMV4420 doc | expand |
On 23/02/2022 14:08, Cristian Pop wrote: > Add device tree bindings for the ADMV4420 K band downconverter. > > Signed-off-by: Cristian Pop <cristian.pop@analog.com> > --- > Changes in v7: > - Fix commit message Please include the tags accumulated in previous reviews. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
On Wed, 23 Feb 2022 15:08:07 +0200, Cristian Pop wrote: > Add device tree bindings for the ADMV4420 K band downconverter. > > Signed-off-by: Cristian Pop <cristian.pop@analog.com> > --- > Changes in v7: > - Fix commit message > .../bindings/iio/frequency/adi,admv4420.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml > Acked-by: Rob Herring <robh@kernel.org>
On Wed, 23 Feb 2022 14:26:05 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > On 23/02/2022 14:08, Cristian Pop wrote: > > Add device tree bindings for the ADMV4420 K band downconverter. > > > > Signed-off-by: Cristian Pop <cristian.pop@analog.com> > > --- > > Changes in v7: > > - Fix commit message > > Please include the tags accumulated in previous reviews. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > > Best regards, > Krzysztof Series applied to the togreg branch of iio.git and pushed out as testing to let 0-day take a look before I go breaking linux-next (again :) You get the same general feedback for future series as I just gave Antoniu: 1) Particularly when doing multiple revisions close together, please give a longer change log covering at least the last few versions as not everyone will have looked at v7 and it saves reviewers time otherwise spent checking back through earlier versions. 2) Cover letters are good for multipatch series because they both provide somewhere for general discussion that overlaps multiple patches and as somewhere for series wide tags to be given and that sometimes makes my life easier (complex cases where some tags are for individual patches and some are series wide which I have to go in an add by hand as no automated tool e.g. b4, could work it out!) Sometimes I like to complain about this trivial stuff that makes me ever so slightly grumpy :) Jonathan
diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml new file mode 100644 index 000000000000..da7fe85ec92e --- /dev/null +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/frequency/adi,admv4420.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ADMV4420 K Band Downconverter + +maintainers: + - Cristian Pop <cristian.pop@analog.com> + +description: + The ADMV4420 is a highly integrated, double balanced, active + mixer with an integrated fractional-N synthesizer, ideally suited + for next generation K band satellite communications + +properties: + compatible: + enum: + - adi,admv4420 + + reg: + maxItems: 1 + + spi-max-frequency: + maximum: 1000000 + + adi,lo-freq-khz: + description: LO Frequency + $ref: /schemas/types.yaml#/definitions/uint32 + + adi,ref-ext-single-ended-en: + description: External reference selected. + type: boolean + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + mixer@0 { + compatible = "adi,admv4420"; + reg = <0>; + spi-max-frequency = <1000000>; + adi,lo-freq-khz = <16750000>; + adi,ref-ext-single-ended-en; + }; + }; +...
Add device tree bindings for the ADMV4420 K band downconverter. Signed-off-by: Cristian Pop <cristian.pop@analog.com> --- Changes in v7: - Fix commit message .../bindings/iio/frequency/adi,admv4420.yaml | 55 +++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml