| Message ID | 20220218070729.3256-3-zajec5@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V3,1/3] dt-bindings: nvmem: make "reg" property optional | expand |
On Fri, 18 Feb 2022 08:07:28 +0100, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > NVRAM doesn't have cells at hardcoded addresses. They are stored in > internal struct (custom & dynamic format). It's still important to > define relevant cells in DT so NVMEM consumers can reference them. > > Update binding to allow including basic cells as NVMEM device subnodes. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > V2: Add children nodes description per Rob's request > V3: Document NVMEM cells as properties > --- > .../devicetree/bindings/nvmem/brcm,nvram.yaml | 25 +++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On 18/02/2022 07:07, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > NVRAM doesn't have cells at hardcoded addresses. They are stored in > internal struct (custom & dynamic format). It's still important to > define relevant cells in DT so NVMEM consumers can reference them. > > Update binding to allow including basic cells as NVMEM device subnodes. > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Applied thanks, --srini > --- > V2: Add children nodes description per Rob's request > V3: Document NVMEM cells as properties > --- > .../devicetree/bindings/nvmem/brcm,nvram.yaml | 25 +++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > index 8c3f0cd22821..25033de3ef6b 100644 > --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > @@ -14,6 +14,8 @@ description: | > NVRAM can be accessed on Broadcom BCM47xx MIPS and Northstar ARM Cortex-A9 > devices usiong I/O mapped memory. > > + NVRAM variables can be defined as NVMEM device subnodes. > + > maintainers: > - Rafał Miłecki <rafal@milecki.pl> > > @@ -27,11 +29,30 @@ properties: > reg: > maxItems: 1 > > + board_id: > + type: object > + description: Board identification name > + > + et0macaddr: > + type: object > + description: First Ethernet interface's MAC address > + > + et1macaddr: > + type: object > + description: Second Ethernet interface's MAC address > + > + et2macaddr: > + type: object > + description: Third Ethernet interface's MAC address > + > unevaluatedProperties: false > > examples: > - | > nvram@1eff0000 { > - compatible = "brcm,nvram"; > - reg = <0x1eff0000 0x10000>; > + compatible = "brcm,nvram"; > + reg = <0x1eff0000 0x10000>; > + > + mac: et0macaddr { > + }; > };
diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml index 8c3f0cd22821..25033de3ef6b 100644 --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml @@ -14,6 +14,8 @@ description: | NVRAM can be accessed on Broadcom BCM47xx MIPS and Northstar ARM Cortex-A9 devices usiong I/O mapped memory. + NVRAM variables can be defined as NVMEM device subnodes. + maintainers: - Rafał Miłecki <rafal@milecki.pl> @@ -27,11 +29,30 @@ properties: reg: maxItems: 1 + board_id: + type: object + description: Board identification name + + et0macaddr: + type: object + description: First Ethernet interface's MAC address + + et1macaddr: + type: object + description: Second Ethernet interface's MAC address + + et2macaddr: + type: object + description: Third Ethernet interface's MAC address + unevaluatedProperties: false examples: - | nvram@1eff0000 { - compatible = "brcm,nvram"; - reg = <0x1eff0000 0x10000>; + compatible = "brcm,nvram"; + reg = <0x1eff0000 0x10000>; + + mac: et0macaddr { + }; };