| Message ID | 20220224110241.9613-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Input: Replace surface3_button code with soc_button_array | expand |
On Thu, Feb 24, 2022 at 12:02:39PM +0100, Hans de Goede wrote: > Hi All, > > I noticed that the surface3_button code was pretty much a 1:1 copy of > soc_button_array. This series adds support to soc_button_array for the > MSHW0028 device on the Microsoft Surface 3 (non pro) and removes the > now no longer needed surface3_button driver. Thanks, I like esp. patch 2 in this series. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Rafael, this includes an addition to ignore_serial_bus_ids[] in > drivers/apci/scan.c, may we have your ack for merging this through > the input or pdx86 tree please ? > > Dmitry, I believe it would be best to keep these 2 patches together > and merge both through either the input or the pdx86 tree. If you > are ok with me merging this through the pdx86 tree may I have your > Ack for that ? > > If you prefer merging this through the input tree please consider > this my ack for also merge 2/2 through the input tree. > > Note both patches can also be merged through separate trees without > issues but keeping them together seems better to me.
Hi All, On 2/24/22 12:02, Hans de Goede wrote: > Hi All, > > I noticed that the surface3_button code was pretty much a 1:1 copy of > soc_button_array. This series adds support to soc_button_array for the > MSHW0028 device on the Microsoft Surface 3 (non pro) and removes the > now no longer needed surface3_button driver. > > Rafael, this includes an addition to ignore_serial_bus_ids[] in > drivers/apci/scan.c, may we have your ack for merging this through > the input or pdx86 tree please ? > > Dmitry, I believe it would be best to keep these 2 patches together > and merge both through either the input or the pdx86 tree. If you > are ok with me merging this through the pdx86 tree may I have your > Ack for that ? > > If you prefer merging this through the input tree please consider > this my ack for also merge 2/2 through the input tree. > > Note both patches can also be merged through separate trees without > issues but keeping them together seems better to me. Thank you all for the reviews + acks, I've added this series to my review-hans (soon to be for-next) branch now. Regards, Hans > Hans de Goede (2): > Input: soc_button_array - add support for Microsoft Surface 3 > (MSHW0028) buttons > platform/surface: Remove Surface 3 Button driver > > drivers/acpi/scan.c | 5 + > drivers/input/misc/soc_button_array.c | 24 +- > drivers/platform/surface/Kconfig | 7 - > drivers/platform/surface/Makefile | 1 - > drivers/platform/surface/surface3_button.c | 247 --------------------- > 5 files changed, 28 insertions(+), 256 deletions(-) > delete mode 100644 drivers/platform/surface/surface3_button.c >
Hi All, I noticed that the surface3_button code was pretty much a 1:1 copy of soc_button_array. This series adds support to soc_button_array for the MSHW0028 device on the Microsoft Surface 3 (non pro) and removes the now no longer needed surface3_button driver. Rafael, this includes an addition to ignore_serial_bus_ids[] in drivers/apci/scan.c, may we have your ack for merging this through the input or pdx86 tree please ? Dmitry, I believe it would be best to keep these 2 patches together and merge both through either the input or the pdx86 tree. If you are ok with me merging this through the pdx86 tree may I have your Ack for that ? If you prefer merging this through the input tree please consider this my ack for also merge 2/2 through the input tree. Note both patches can also be merged through separate trees without issues but keeping them together seems better to me. Regards, Hans Hans de Goede (2): Input: soc_button_array - add support for Microsoft Surface 3 (MSHW0028) buttons platform/surface: Remove Surface 3 Button driver drivers/acpi/scan.c | 5 + drivers/input/misc/soc_button_array.c | 24 +- drivers/platform/surface/Kconfig | 7 - drivers/platform/surface/Makefile | 1 - drivers/platform/surface/surface3_button.c | 247 --------------------- 5 files changed, 28 insertions(+), 256 deletions(-) delete mode 100644 drivers/platform/surface/surface3_button.c