| Message ID | 20220225000753.511996-3-djrscally@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Support OVTI7251 on Microsoft Surface line | expand |
On Fri, Feb 25, 2022 at 12:07:44AM +0000, Daniel Scally wrote: > We have platforms where a camera sensor transmits Y10 data to > the CIO2 device - add support for that (packed) format to the > ipu3-cio2 driver. ... > - }, Why? > + }, { > + .mbus_code = MEDIA_BUS_FMT_Y10_1X10, > + .fourcc = V4L2_PIX_FMT_IPU3_Y10, > + .mipicode = 0x2b, > + .bpp = 10, > + }
Hi Andy On 25/02/2022 16:57, Andy Shevchenko wrote: > On Fri, Feb 25, 2022 at 12:07:44AM +0000, Daniel Scally wrote: >> We have platforms where a camera sensor transmits Y10 data to >> the CIO2 device - add support for that (packed) format to the >> ipu3-cio2 driver. > ... > >> - }, > Why? Why have the open and close brace on the same line you mean? Its just the format that the other entries use, so I copied it. > >> + }, { >> + .mbus_code = MEDIA_BUS_FMT_Y10_1X10, >> + .fourcc = V4L2_PIX_FMT_IPU3_Y10, >> + .mipicode = 0x2b, >> + .bpp = 10, >> + }
On Sat, Feb 26, 2022 at 4:06 AM Daniel Scally <djrscally@gmail.com> wrote: > > Hi Andy > > On 25/02/2022 16:57, Andy Shevchenko wrote: > > On Fri, Feb 25, 2022 at 12:07:44AM +0000, Daniel Scally wrote: > >> We have platforms where a camera sensor transmits Y10 data to > >> the CIO2 device - add support for that (packed) format to the > >> ipu3-cio2 driver. > > ... > > > >> - }, > > Why? > > > Why have the open and close brace on the same line you mean? Its just > the format that the other entries use, so I copied it. I meant why you touched that line and as a consequence removed the comma. > >> + }, { > >> + .mbus_code = MEDIA_BUS_FMT_Y10_1X10, > >> + .fourcc = V4L2_PIX_FMT_IPU3_Y10, > >> + .mipicode = 0x2b, > >> + .bpp = 10, > >> + }
On 26/02/2022 18:14, Andy Shevchenko wrote: > On Sat, Feb 26, 2022 at 4:06 AM Daniel Scally <djrscally@gmail.com> wrote: >> Hi Andy >> >> On 25/02/2022 16:57, Andy Shevchenko wrote: >>> On Fri, Feb 25, 2022 at 12:07:44AM +0000, Daniel Scally wrote: >>>> We have platforms where a camera sensor transmits Y10 data to >>>> the CIO2 device - add support for that (packed) format to the >>>> ipu3-cio2 driver. >>> ... >>> >>>> - }, >>> Why? >> >> Why have the open and close brace on the same line you mean? Its just >> the format that the other entries use, so I copied it. > I meant why you touched that line and as a consequence removed the comma. Ah - I didn't close my new entry in that table with a comma. I can fix that in the next version > >>>> + }, { >>>> + .mbus_code = MEDIA_BUS_FMT_Y10_1X10, >>>> + .fourcc = V4L2_PIX_FMT_IPU3_Y10, >>>> + .mipicode = 0x2b, >>>> + .bpp = 10, >>>> + } > >
diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c index 0e9b0503b62a..ea2f9f70a64e 100644 --- a/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c @@ -65,7 +65,12 @@ static const struct ipu3_cio2_fmt formats[] = { .fourcc = V4L2_PIX_FMT_IPU3_SRGGB10, .mipicode = 0x2b, .bpp = 10, - }, + }, { + .mbus_code = MEDIA_BUS_FMT_Y10_1X10, + .fourcc = V4L2_PIX_FMT_IPU3_Y10, + .mipicode = 0x2b, + .bpp = 10, + } }; /*
We have platforms where a camera sensor transmits Y10 data to the CIO2 device - add support for that (packed) format to the ipu3-cio2 driver. Signed-off-by: Daniel Scally <djrscally@gmail.com> --- Changes in v2: - None drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)