| Message ID | 20220224123248.67073-2-bhupesh.sharma@linaro.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] dt-bindings: phy: qcom, qmp: Mark '#clock-cells' as a 'optional' property | expand |
On Thu, 24 Feb 2022 18:02:48 +0530, Bhupesh Sharma wrote: > Since a few boards based on QCoM qmp phy use the > 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties to > describe the ufs phy nodes, add them to the dt-bindings doc as well. > > This fixes the following '$ make dtbs_check' warning(s): > > sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: > 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of > the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1597137 phy@1c07000: 'lanes@1c06000' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml arch/arm/boot/dts/qcom-sdx55-t55.dt.yaml arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dt.yaml phy@1c0e000: 'lanes@1c0e200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sc7280-crd.dt.yaml arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml phy@1d87000: 'lanes@1d87400' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sm8450-qrd.dt.yaml phy@627000: 'vdda-phy-max-microamp', 'vddp-ref-clk-always-on', 'vddp-ref-clk-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dt.yaml arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dt.yaml phy-wrapper@88e9000: 'vdda-phy-supply' is a required property arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dt.yaml arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml phy-wrapper@88e9000: 'vdda-pll-supply' is a required property arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx214.dt.yaml arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml ssphy@78000: 'lane@78200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml
On Thu, Feb 24, 2022 at 07:59:19AM -0600, Rob Herring wrote: > On Thu, 24 Feb 2022 18:02:48 +0530, Bhupesh Sharma wrote: > > Since a few boards based on QCoM qmp phy use the > > 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties to > > describe the ufs phy nodes, add them to the dt-bindings doc as well. > > > > This fixes the following '$ make dtbs_check' warning(s): > > > > sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: > > 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of > > the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > > > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: Vinod Koul <vkoul@kernel.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1597137 > > > phy@1c07000: 'lanes@1c06000' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml > arch/arm/boot/dts/qcom-sdx55-t55.dt.yaml > arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dt.yaml > > phy@1c0e000: 'lanes@1c0e200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > arch/arm64/boot/dts/qcom/sc7280-crd.dt.yaml > arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml > arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml > arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml > > phy@1d87000: 'lanes@1d87400' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > arch/arm64/boot/dts/qcom/sm8450-qrd.dt.yaml > > phy@627000: 'vdda-phy-max-microamp', 'vddp-ref-clk-always-on', 'vddp-ref-clk-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dt.yaml I'm curious why these are not fixed too? Rob
Hi Rob, On Sat, 26 Feb 2022 at 01:38, Rob Herring <robh@kernel.org> wrote: > > On Thu, Feb 24, 2022 at 07:59:19AM -0600, Rob Herring wrote: > > On Thu, 24 Feb 2022 18:02:48 +0530, Bhupesh Sharma wrote: > > > Since a few boards based on QCoM qmp phy use the > > > 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties to > > > describe the ufs phy nodes, add them to the dt-bindings doc as well. > > > > > > This fixes the following '$ make dtbs_check' warning(s): > > > > > > sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: > > > 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of > > > the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > > > > > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > > Cc: Vinod Koul <vkoul@kernel.org> > > > Cc: Rob Herring <robh+dt@kernel.org> > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > > --- > > > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. > > > > Full log is available here: https://patchwork.ozlabs.org/patch/1597137 > > > > > > phy@1c07000: 'lanes@1c06000' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > > arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml > > arch/arm/boot/dts/qcom-sdx55-t55.dt.yaml > > arch/arm/boot/dts/qcom-sdx55-telit-fn980-tlb.dt.yaml > > > > phy@1c0e000: 'lanes@1c0e200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > > arch/arm64/boot/dts/qcom/sc7280-crd.dt.yaml > > arch/arm64/boot/dts/qcom/sc7280-herobrine.dt.yaml > > arch/arm64/boot/dts/qcom/sc7280-idp2.dt.yaml > > arch/arm64/boot/dts/qcom/sc7280-idp.dt.yaml > > > > phy@1d87000: 'lanes@1d87400' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > > arch/arm64/boot/dts/qcom/sm8450-qrd.dt.yaml > > > > phy@627000: 'vdda-phy-max-microamp', 'vddp-ref-clk-always-on', 'vddp-ref-clk-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > > arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dt.yaml > > arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dt.yaml > > I'm curious why these are not fixed too? Seems I missed this one. Will fix this in v2. Thanks for pointing it out. Regards, Bhupesh
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index 746a929c63bb..a481442c897a 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -92,6 +92,14 @@ properties: minItems: 1 maxItems: 3 + vdda-max-microamp: + description: + Specifies max. load that can be drawn from phy supply. + + vdda-pll-max-microamp: + description: + Specifies max. load that can be drawn from pll supply. + vdda-phy-supply: description: Phandle to a regulator supply to PHY core block.
Since a few boards based on QCoM qmp phy use the 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties to describe the ufs phy nodes, add them to the dt-bindings doc as well. This fixes the following '$ make dtbs_check' warning(s): sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000: 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Vinod Koul <vkoul@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)