diff mbox series

USB: serial: simple: add Nokia phone driver

Message ID 20220224133109.10523-1-johan@kernel.org (mailing list archive)
State Superseded
Headers show
Series USB: serial: simple: add Nokia phone driver | expand

Commit Message

Johan Hovold Feb. 24, 2022, 1:31 p.m. UTC 
Add a new "simple" driver for certain Nokia phones, including Nokia 130
(RM-1035) which exposes two serial ports in "charging only" mode.

Reported-by: Felix Becker <linux.felixbecker2@gmx.de>
Link: https://lore.kernel.org/r/20220208201506.6c65834d@gmx.de
Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/Kconfig             | 1 +
 drivers/usb/serial/usb-serial-simple.c | 7 +++++++
 2 files changed, 8 insertions(+)

Comments

Greg Kroah-Hartman Feb. 24, 2022, 6:23 p.m. UTC | #1 
On Thu, Feb 24, 2022 at 02:31:09PM +0100, Johan Hovold wrote:
> Add a new "simple" driver for certain Nokia phones, including Nokia 130
> (RM-1035) which exposes two serial ports in "charging only" mode.
> 
> Reported-by: Felix Becker <linux.felixbecker2@gmx.de>
> Link: https://lore.kernel.org/r/20220208201506.6c65834d@gmx.de
> Cc: stable@vger.kernel.org
> Signed-off-by: Johan Hovold <johan@kernel.org>


Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Felix Becker Feb. 26, 2022, 5:52 p.m. UTC | #2 
Dear Johan,
dear people.

I see that this includes my email address publicly in a non-obfuscated
form, and this is also available freely on the web at
https://lore.kernel.org/r/20220208201506.6c65834d@gmx.de.

I do not want to have my Email address publicly available (e.g. against
automated email address harvesting).

According to the GPDR, I want that you remove my email address from the
patch before it is published somewhere on the web or/and in
downloadable source code (if already done, I wish that it get's removed
from everything published), and that you remove it from publicly
accessible email list archives.

Please confirm back to me when you have done that, or please refer to
me whom I should contact to get my email address removed.

Regards!


On Thu, 24 Feb 2022 14:31:09 +0100, Johan Hovold <johan@kernel.org>
wrote about "[PATCH] USB: serial: simple: add Nokia phone driver":

> Add a new "simple" driver for certain Nokia phones, including Nokia
> 130 (RM-1035) which exposes two serial ports in "charging only" mode.
> 
> Reported-by: Felix Becker <linux.felixbecker2@gmx.de>
> Link: https://lore.kernel.org/r/20220208201506.6c65834d@gmx.de
> Cc: stable@vger.kernel.org
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/usb/serial/Kconfig             | 1 +
>  drivers/usb/serial/usb-serial-simple.c | 7 +++++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig
> index de5c01257060..ef8d1c73c754 100644
> --- a/drivers/usb/serial/Kconfig
> +++ b/drivers/usb/serial/Kconfig
> @@ -66,6 +66,7 @@ config USB_SERIAL_SIMPLE
>  		- Libtransistor USB console
>  		- a number of Motorola phones
>  		- Motorola Tetra devices
> +		- Nokia mobile phones
>  		- Novatel Wireless GPS receivers
>  		- Siemens USB/MPI adapter.
>  		- ViVOtech ViVOpay USB device.
> diff --git a/drivers/usb/serial/usb-serial-simple.c
> b/drivers/usb/serial/usb-serial-simple.c index
> bd23a7cb1be2..c95dfe4a6f0f 100644 ---
> a/drivers/usb/serial/usb-serial-simple.c +++
> b/drivers/usb/serial/usb-serial-simple.c @@ -91,6 +91,11 @@
> DEVICE(moto_modem, MOTO_IDS); { USB_DEVICE(0x0cad, 0x9016) }
> /* TPG2200 */ DEVICE(motorola_tetra, MOTOROLA_TETRA_IDS);
>  
> +/* Nokia mobile phone driver */
> +#define NOKIA_IDS()			\
> +	{ USB_DEVICE(0x0421, 0x069a) }	/* Nokia 130 (RM-1035)
> */ +DEVICE_N(nokia, NOKIA_IDS, 2);
> +
>  /* Novatel Wireless GPS driver */
>  #define NOVATEL_IDS()			\
>  	{ USB_DEVICE(0x09d7, 0x0100) }	/* NovAtel FlexPack
> GPS */ @@ -123,6 +128,7 @@ static struct usb_serial_driver * const
> serial_drivers[] = { &vivopay_device,
>  	&moto_modem_device,
>  	&motorola_tetra_device,
> +	&nokia_device,
>  	&novatel_gps_device,
>  	&hp4x_device,
>  	&suunto_device,
> @@ -140,6 +146,7 @@ static const struct usb_device_id id_table[] = {
>  	VIVOPAY_IDS(),
>  	MOTO_IDS(),
>  	MOTOROLA_TETRA_IDS(),
> +	NOKIA_IDS(),
>  	NOVATEL_IDS(),
>  	HP4X_IDS(),
>  	SUUNTO_IDS(),
Greg Kroah-Hartman Feb. 27, 2022, 7 a.m. UTC | #3 
On Sat, Feb 26, 2022 at 06:52:44PM +0100, Felix Becker wrote:
> Dear Johan,
> dear people.
> 
> I see that this includes my email address publicly in a non-obfuscated
> form, and this is also available freely on the web at
> https://lore.kernel.org/r/20220208201506.6c65834d@gmx.de.
> 
> I do not want to have my Email address publicly available (e.g. against
> automated email address harvesting).
> 
> According to the GPDR, I want that you remove my email address from the
> patch before it is published somewhere on the web or/and in
> downloadable source code (if already done, I wish that it get's removed
> from everything published), and that you remove it from publicly
> accessible email list archives.
> 
> Please confirm back to me when you have done that, or please refer to
> me whom I should contact to get my email address removed.

When sending a message to a public mailing list, the GPDR does not come
into play, sorry.  There's nothing we can do here.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig
index de5c01257060..ef8d1c73c754 100644
--- a/drivers/usb/serial/Kconfig
+++ b/drivers/usb/serial/Kconfig
@@ -66,6 +66,7 @@  config USB_SERIAL_SIMPLE
 		- Libtransistor USB console
 		- a number of Motorola phones
 		- Motorola Tetra devices
+		- Nokia mobile phones
 		- Novatel Wireless GPS receivers
 		- Siemens USB/MPI adapter.
 		- ViVOtech ViVOpay USB device.
diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
index bd23a7cb1be2..c95dfe4a6f0f 100644
--- a/drivers/usb/serial/usb-serial-simple.c
+++ b/drivers/usb/serial/usb-serial-simple.c
@@ -91,6 +91,11 @@  DEVICE(moto_modem, MOTO_IDS);
 	{ USB_DEVICE(0x0cad, 0x9016) }	/* TPG2200 */
 DEVICE(motorola_tetra, MOTOROLA_TETRA_IDS);
 
+/* Nokia mobile phone driver */
+#define NOKIA_IDS()			\
+	{ USB_DEVICE(0x0421, 0x069a) }	/* Nokia 130 (RM-1035) */
+DEVICE_N(nokia, NOKIA_IDS, 2);
+
 /* Novatel Wireless GPS driver */
 #define NOVATEL_IDS()			\
 	{ USB_DEVICE(0x09d7, 0x0100) }	/* NovAtel FlexPack GPS */
@@ -123,6 +128,7 @@  static struct usb_serial_driver * const serial_drivers[] = {
 	&vivopay_device,
 	&moto_modem_device,
 	&motorola_tetra_device,
+	&nokia_device,
 	&novatel_gps_device,
 	&hp4x_device,
 	&suunto_device,
@@ -140,6 +146,7 @@  static const struct usb_device_id id_table[] = {
 	VIVOPAY_IDS(),
 	MOTO_IDS(),
 	MOTOROLA_TETRA_IDS(),
+	NOKIA_IDS(),
 	NOVATEL_IDS(),
 	HP4X_IDS(),
 	SUUNTO_IDS(),