| Message ID | e96e06d3228d9bbd927da32379ba78d5b4b718a7.1645949914.git.baruch@tkos.co.il (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] dt-bindings: net: ipq4019-mdio: Add ipq6018 compatible | expand |
On Sun, 27 Feb 2022 10:18:33 +0200, Baruch Siach wrote: > From: Baruch Siach <baruch.siach@siklu.com> > > The IPQ60xx MDIO bus is the same as IPQ4019. > > Change 'enum' to 'items' list to allow fallback to older compatible > strings. > > Signed-off-by: Baruch Siach <baruch.siach@siklu.com> > --- > > v2: > > Update the schema to allow fallback compatible (Rob Herring) > --- > Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml: properties:compatible:items: 'anyOf' conditional failed, one must be fixed: ['qcom,ipq4019-mdio', 'qcom,ipq5018-mdio', 'qcom,ipq6018-mdio'] is not of type 'object', 'boolean' 'qcom,ipq4019-mdio' is not of type 'object', 'boolean' 'qcom,ipq5018-mdio' is not of type 'object', 'boolean' 'qcom,ipq6018-mdio' is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml: ignoring, error in schema: properties: compatible: items Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.example.dt.yaml:0:0: /example-0/mdio@90000: failed to match any schema with compatible: ['qcom,ipq4019-mdio'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1598217 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml index 2af304341772..01fa8406fa33 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml @@ -14,9 +14,10 @@ allOf: properties: compatible: - enum: + items: - qcom,ipq4019-mdio - qcom,ipq5018-mdio + - qcom,ipq6018-mdio "#address-cells": const: 1