| Message ID | 20220228123019.382037-9-bhupesh.sharma@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix dtbs_check warning(s) for Qualcomm QMP PHY | expand |
On Mon, Feb 28, 2022 at 06:00:19PM +0530, Bhupesh Sharma wrote: > Fix the following 'make dtbs_check' warnings, by marking the > 'vdda-pll-supply' & 'vdda-phy-supply' properties as 'optional' in > 'qcom,qmp-phy' dt-binding: > > arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml: > phy-wrapper@88e9000: 'vdda-phy-supply' is a required property > > arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml: > phy-wrapper@88e9000: 'vdda-pll-supply' is a required property > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index f8a43acd229a..82b102b7d42c 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -436,9 +436,6 @@ allOf: > items: > - const: phy > - const: common > - required: > - - vdda-phy-supply > - - vdda-pll-supply Not sure this change is correct. In phy-qcom-qmp driver, sm8350_usb3phy_cfg has qmp_phy_vreg_l assignment. static const char * const qmp_phy_vreg_l[] = { "vdda-phy", "vdda-pll", }; static const struct qmp_phy_cfg sm8350_usb3phy_cfg = { .vreg_list = qmp_phy_vreg_l, .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), }; That means for "qcom,sm8350-qmp-usb3-phy" device, these two supplied are required. The sony-xperia-sagami-pdx215 may work only because devm_regulator_bulk_get() call in qcom_qmp_phy_vreg_init() doesn't fail because of dummy regulator support. Shawn > - if: > properties: > compatible: > -- > 2.35.1 >
On Mon 28 Feb 06:30 CST 2022, Bhupesh Sharma wrote: > Fix the following 'make dtbs_check' warnings, by marking the > 'vdda-pll-supply' & 'vdda-phy-supply' properties as 'optional' in > 'qcom,qmp-phy' dt-binding: > > arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml: > phy-wrapper@88e9000: 'vdda-phy-supply' is a required property > > arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml: > phy-wrapper@88e9000: 'vdda-pll-supply' is a required property > These two supplies denotes the power for the bus and the clock of the UFS PHY. As such I think we can expect that if pdx215 has functional UFS then it has these supplies, and the "bug" is in the dts. It's probably safe to assume that the two regulators are the same as on the MTP. So my suggestion is that you just wire them up in the same way as the MTP; and please Cc Konrad. PS. This change is unrelated to the rest of the series, please send such changes alone, because it could have been merged independently of the rest of the series... Regards, Bjorn > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index f8a43acd229a..82b102b7d42c 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -436,9 +436,6 @@ allOf: > items: > - const: phy > - const: common > - required: > - - vdda-phy-supply > - - vdda-pll-supply > - if: > properties: > compatible: > -- > 2.35.1 >
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index f8a43acd229a..82b102b7d42c 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -436,9 +436,6 @@ allOf: items: - const: phy - const: common - required: - - vdda-phy-supply - - vdda-pll-supply - if: properties: compatible:
Fix the following 'make dtbs_check' warnings, by marking the 'vdda-pll-supply' & 'vdda-phy-supply' properties as 'optional' in 'qcom,qmp-phy' dt-binding: arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml: phy-wrapper@88e9000: 'vdda-phy-supply' is a required property arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml: phy-wrapper@88e9000: 'vdda-pll-supply' is a required property Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Rob Herring <robh@kernel.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 3 --- 1 file changed, 3 deletions(-)