| Message ID | 20220228123019.382037-7-bhupesh.sharma@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix dtbs_check warning(s) for Qualcomm QMP PHY | expand |
On Mon, Feb 28, 2022 at 06:00:17PM +0530, Bhupesh Sharma wrote: > Fix the following 'make dtbs_check' warning(s) by > using phy@ instead of lanes@ and by moving '#clock-names' to s/clock-names/clock-cells > sub-node: > > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml: ssphy@78000: > 'lane@78200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh@kernel.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> Other than that: Reviewed-by: Shawn Guo <shawn.guo@linaro.org> > --- > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > index 66ec5615651d..ad7914e49532 100644 > --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > @@ -674,7 +674,6 @@ ssphy_0: ssphy@78000 { > reg = <0x0 0x78000 0x0 0x1C4>; > #address-cells = <2>; > #size-cells = <2>; > - #clock-cells = <1>; > ranges; > > clocks = <&gcc GCC_USB0_AUX_CLK>, > @@ -686,12 +685,13 @@ ssphy_0: ssphy@78000 { > reset-names = "phy","common"; > status = "disabled"; > > - usb0_ssphy: lane@78200 { > + usb0_ssphy: phy@78200 { > reg = <0x0 0x00078200 0x0 0x130>, /* Tx */ > <0x0 0x00078400 0x0 0x200>, /* Rx */ > <0x0 0x00078800 0x0 0x1F8>, /* PCS */ > <0x0 0x00078600 0x0 0x044>; /* PCS misc */ > #phy-cells = <0>; > + #clock-cells = <1>; > clocks = <&gcc GCC_USB0_PIPE_CLK>; > clock-names = "pipe0"; > clock-output-names = "gcc_usb0_pipe_clk_src"; > -- > 2.35.1 >
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index 66ec5615651d..ad7914e49532 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -674,7 +674,6 @@ ssphy_0: ssphy@78000 { reg = <0x0 0x78000 0x0 0x1C4>; #address-cells = <2>; #size-cells = <2>; - #clock-cells = <1>; ranges; clocks = <&gcc GCC_USB0_AUX_CLK>, @@ -686,12 +685,13 @@ ssphy_0: ssphy@78000 { reset-names = "phy","common"; status = "disabled"; - usb0_ssphy: lane@78200 { + usb0_ssphy: phy@78200 { reg = <0x0 0x00078200 0x0 0x130>, /* Tx */ <0x0 0x00078400 0x0 0x200>, /* Rx */ <0x0 0x00078800 0x0 0x1F8>, /* PCS */ <0x0 0x00078600 0x0 0x044>; /* PCS misc */ #phy-cells = <0>; + #clock-cells = <1>; clocks = <&gcc GCC_USB0_PIPE_CLK>; clock-names = "pipe0"; clock-output-names = "gcc_usb0_pipe_clk_src";
Fix the following 'make dtbs_check' warning(s) by using phy@ instead of lanes@ and by moving '#clock-names' to sub-node: arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml: ssphy@78000: 'lane@78200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Rob Herring <robh@kernel.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)